commit 32ec4d1da8455caff8af6ed32ed1e99cbd028d8a
author Miguel <miguelaranda@google.com> Thu Mar 31 13:43:13 2022 +0000
committer Miguel Aranda <miguelaranda@google.com> Mon Aug 22 10:02:26 2022 +0000
tree 4d8f6e129868797cabd4e8d6a7f476b341e16dfa
parent 85eb285fc7400912e00f08132e8caf7f34d6a753

Enable StrictMode checks for explicit garbageCollection from T.

This disallows calls to runtime.gc() in the new version of Android.
Explicit GC calls are blocking and can thus cause runtime overhead.
They used to be performed as a pattern in order to avoid GC_FOR_ALLOC.
However, that was only the case for Dalvik, that is now discouraged for
ART.

Bug: 3400644
Test: m
Test: atest StrictModeTest
Change-Id: I12cee0af955a708b6bf5a3a0c21cddc7f6a19185

tests/tests/os/src/android/os/cts/StrictModeTest.java

diff --git a/tests/tests/os/src/android/os/cts/StrictModeTest.java b/tests/tests/os/src/android/os/cts/StrictModeTest.java
index 3e2bce4..8ff06af 100644
--- a/tests/tests/os/src/android/os/cts/StrictModeTest.java
+++ b/tests/tests/os/src/android/os/cts/StrictModeTest.java
@@ -81,6 +81,8 @@
 import androidx.test.rule.ServiceTestRule;
 import androidx.test.runner.AndroidJUnit4;
 
+import com.android.compatibility.common.util.ApiTest;
+
 import org.junit.After;
 import org.junit.Before;
 import org.junit.Test;
@@ -563,6 +565,16 @@
     }
 
     @Test
+    @ApiTest(apis={"StrictMode.VmPolicy.Builder#permitExplicitGc"})
+    public void testPermitExplicitGc() throws Exception {
+        StrictMode.setThreadPolicy(
+                new StrictMode.ThreadPolicy.Builder().permitExplicitGc().penaltyLog().build());
+
+        assertNoViolation(() -> Runtime.getRuntime().gc());
+    }
+
+    @Test
+    @ApiTest(apis={"StrictMode.VmPolicy.Builder#detectUnbufferedIo"})
     public void testUnbufferedIoGZipInput() throws Exception {
         StrictMode.setThreadPolicy(
                 new StrictMode.ThreadPolicy.Builder().detectUnbufferedIo().penaltyLog().build());