commit c3a483478a6a38caf174c1a439dda6e0c91a0cd6
author Shinichiro Hamaji <shinichiro.hamaji@gmail.com> Tue Mar 15 08:27:43 2016 +0900
committer Shinichiro Hamaji <shinichiro.hamaji@gmail.com> Tue Mar 15 08:35:45 2016 +0900
tree 1997f6e387655eaa1ef536962982b1e42e82f6c8
parent f3ad9e0cec73953592df5143d16d880595c7bc6e

Use subshell even when a command starts with '('

ninja.cc

diff --git a/ninja.cc b/ninja.cc
index 6b1a778..41e5db4 100644
--- a/ninja.cc
+++ b/ninja.cc
@@ -426,9 +426,6 @@
         in++;
 
       bool needs_subshell = command_count > 1;
-      if (*in == '(') {
-        needs_subshell = false;
-      }
 
       if (needs_subshell)
         *cmd_buf += '(';

runtest.rb

diff --git a/runtest.rb b/runtest.rb
index bf42bfe..ab1e26b 100755
--- a/runtest.rb
+++ b/runtest.rb
@@ -108,6 +108,10 @@
     # This test expects ninja fails. Strip ninja specific error logs.
     log.gsub!(/^FAILED: .*\n/, '')
     log.gsub!(/^ninja: .*\n/, '')
+  elsif mk =~ /\/fail_/
+    # Recipes in these tests fail.
+    log.gsub!(/^FAILED: .*/, '*** [test] Error 1')
+    log.gsub!(/^ninja: .*\n/, '')
   end
   log
 end

testcase/fail_subshell_in_recipe.mk

diff --git a/testcase/fail_subshell_in_recipe.mk b/testcase/fail_subshell_in_recipe.mk
new file mode 100644
index 0000000..c2d2b2d
--- /dev/null
+++ b/testcase/fail_subshell_in_recipe.mk
@@ -0,0 +1,5 @@
+# TODO(go-ninja): Fix
+
+test:
+	false
+	(true) ; echo FAIL