commit 0f7af70fb6849c0c4a3cde5df7d0c5b90d8ba99a
author Shinichiro Hamaji <shinichiro.hamaji@gmail.com> Sun Jul 05 02:00:18 2015 +0900
committer Shinichiro Hamaji <shinichiro.hamaji@gmail.com> Sun Jul 05 02:00:18 2015 +0900
tree 22fefc271e26aa6122fd7c82ea81eec3e68696e7
parent 663a35b84071ca20d00e70eed65e197799d8dfdc

[C++] Fix unmatched_paren2.mk

testcase/unmatched_paren2.mk

diff --git a/testcase/unmatched_paren2.mk b/testcase/unmatched_paren2.mk
index c1ba29b..faa947c 100644
--- a/testcase/unmatched_paren2.mk
+++ b/testcase/unmatched_paren2.mk
@@ -1,5 +1,4 @@
-# TODO
-# do we need to support this?
+# TODO(go): do we need to support this?
 
 foo = FOO
 bar = BAR

value.cc

diff --git a/value.cc b/value.cc
index 29a8b45..68a33ce 100644
--- a/value.cc
+++ b/value.cc
@@ -404,11 +404,13 @@
       return new VarSubst(vname->Compact(), pat, subst);
     }
 
-#if 0
+    // GNU make accepts expressions like $((). See unmatched_paren*.mk
+    // for detail.
     size_t found = s.find(cp);
-    if (found
-    return NULL;
-#endif
+    if (found != string::npos) {
+      *index_out = s.size();
+      return new SymRef(Intern(s.substr(2, found-2)));
+    }
     ERROR("%s:%d: *** unterminated variable reference.", LOCF(loc));
   }
 }