commit b1f9b1b2249230115fc966f40e6141eb7486a997
author Treehugger Robot <treehugger-gerrit@google.com> Wed Jan 25 21:34:27 2023 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Wed Jan 25 21:34:27 2023 +0000
tree e8b3e19af25b71790bb5f3907aec5802d3828b7b
parent 8b47a35072a9b32a835b095edb214e1e523001ac
parent d9755064a62bc00e2dd0a61caaa554f7c556fc78

Merge "Nullability check for utmp module"

libc/include/utmp.h

diff --git a/libc/include/utmp.h b/libc/include/utmp.h
index cb72ce2..7aa5718 100644
--- a/libc/include/utmp.h
+++ b/libc/include/utmp.h
@@ -99,7 +99,7 @@
 /**
  * Does nothing.
  */
-int utmpname(const char* __path);
+int utmpname(const char* _Nonnull __path);
 /**
  * Does nothing.
  */
@@ -107,11 +107,11 @@
 /**
  * Does nothing.
  */
-struct utmp* getutent(void);
+struct utmp* _Nullable getutent(void);
 /**
  * Does nothing.
  */
-struct utmp* pututline(const struct utmp* __entry);
+struct utmp* _Nullable pututline(const struct utmp* _Nonnull __entry);
 /**
  * Does nothing.
  */

tests/utmp_test.cpp

diff --git a/tests/utmp_test.cpp b/tests/utmp_test.cpp
index 6d0d6f1..b024818 100644
--- a/tests/utmp_test.cpp
+++ b/tests/utmp_test.cpp
@@ -29,5 +29,6 @@
   setutent();
   ASSERT_EQ(NULL, getutent());
   endutent();
-  ASSERT_EQ(NULL, pututline(NULL));
+  utmp failure = {.ut_type = EMPTY};
+  ASSERT_EQ(NULL, pututline(&failure));
 }