commit 47126edb90126164ba001a5782c3cb11fdea0ca1
author Elliott Hughes <enh@google.com> Tue Sep 06 13:25:53 2016 -0700
committer Elliott Hughes <enh@google.com> Tue Sep 06 13:34:15 2016 -0700
tree 96d28c5710c0ea967f10fec822184934da6b21eb
parent 85b15b1d0bb3e223313171a204fa820c598212c6

Fix time.mktime_EOVERFLOW for LP32.

Times before 1901-12-13 *underflow* on LP32, making the year 1900 a bad
choice for success case.

Bug: http://b/31305222
Change-Id: I20d4885c80b57707225580db044abc8948a55fdc

tests/time_test.cpp

diff --git a/tests/time_test.cpp b/tests/time_test.cpp
index 48c299a..2a46d8b 100644
--- a/tests/time_test.cpp
+++ b/tests/time_test.cpp
@@ -124,7 +124,10 @@
 TEST(time, mktime_EOVERFLOW) {
   struct tm t;
   memset(&t, 0, sizeof(tm));
-  t.tm_year = 0;
+
+  // LP32 year range is 1901-2038, so this year is guaranteed not to overflow.
+  t.tm_year = 2016 - 1900;
+
   t.tm_mon = 2;
   t.tm_mday = 10;
 
@@ -132,7 +135,10 @@
   ASSERT_NE(static_cast<time_t>(-1), mktime(&t));
   ASSERT_EQ(0, errno);
 
+  // This will overflow for LP32 or LP64.
   t.tm_year = INT_MAX;
+
+  errno = 0;
   ASSERT_EQ(static_cast<time_t>(-1), mktime(&t));
   ASSERT_EQ(EOVERFLOW, errno);
 }