commit 2e71c17778021dc0c87d2e4590a637f6919e5431
author Elliott Hughes <enh@google.com> Thu Aug 06 13:53:40 2020 -0700
committer Elliott Hughes <enh@google.com> Thu Aug 06 13:53:40 2020 -0700
tree a248c9d5de6dda67147d20b00121344b34f7baa0
parent 0f4bdb04fb4b803bbf19850c86cc9270d64a06b9

Trivial strxfrm coverage improvement.

Test: treehugger
Change-Id: I450bd3324c3f0f8ab95cecebe0f57dc85acc2996

tests/string_test.cpp

diff --git a/tests/string_test.cpp b/tests/string_test.cpp
index 0ed0598f..53fb18c 100644
--- a/tests/string_test.cpp
+++ b/tests/string_test.cpp
@@ -1592,10 +1592,21 @@
 TEST(STRING_TEST, strxfrm_smoke) {
   const char* src1 = "aab";
   char dst1[16] = {};
-  ASSERT_GT(strxfrm(dst1, src1, sizeof(dst1)), 0U);
+  // Dry run.
+  ASSERT_EQ(strxfrm(dst1, src1, 0), 3U);
+  ASSERT_STREQ(dst1, "");
+  // Really do it.
+  ASSERT_EQ(strxfrm(dst1, src1, sizeof(dst1)), 3U);
+
   const char* src2 = "aac";
   char dst2[16] = {};
-  ASSERT_GT(strxfrm(dst2, src2, sizeof(dst2)), 0U);
+  // Dry run.
+  ASSERT_EQ(strxfrm(dst2, src2, 0), 3U);
+  ASSERT_STREQ(dst2, "");
+  // Really do it.
+  ASSERT_EQ(strxfrm(dst2, src2, sizeof(dst2)), 3U);
+
+  // The "transform" of two different strings should cause different outputs.
   ASSERT_TRUE(strcmp(dst1, dst2) < 0);
 }