commit 064a9800f372b8efd6d7b08150ab5204e5304c84
author Dmitriy Ivanov <dimitry@google.com> Mon May 04 11:11:23 2015 -0700
committer Dimitry Ivanov <dimitry@google.com> Mon May 04 18:35:43 2015 +0000
tree d356fec037b01ef45e9eac481fc3d1c5cdd9cee4
parent dc145b510640202a60b0dfaef9d56cd8fc1c05a9

Do not adjust PT_GNU_STACK segment

Bug: http://b/20687795
Bug: http://b/18051137
Change-Id: Ie8af3892cfbebcc0249e7981284c4ad97ff40317

tools/relocation_packer/src/elf_file.cc

diff --git a/tools/relocation_packer/src/elf_file.cc b/tools/relocation_packer/src/elf_file.cc
index d06bd63..102d614 100644
--- a/tools/relocation_packer/src/elf_file.cc
+++ b/tools/relocation_packer/src/elf_file.cc
@@ -312,6 +312,13 @@
   for (size_t i = 0; i < count; ++i) {
     typename ELF::Phdr* program_header = &program_headers[i];
 
+    // Do not adjust PT_GNU_STACK - it confuses gdb and results
+    // in incorrect unwinding if the executable is stripped after
+    // packing.
+    if (program_header->p_type == PT_GNU_STACK) {
+      continue;
+    }
+
     if (program_header->p_offset > hole_start) {
       // The hole start is past this segment, so adjust offset.
       program_header->p_offset += hole_size;