commit f1235e650e8dd2d2e1ddb604d2fac6d531145546
author Andreas Gampe <agampe@google.com> Thu Sep 06 19:44:11 2018 -0700
committer Andreas Gampe <agampe@google.com> Fri Sep 07 08:55:02 2018 -0700
tree 1e90f798bebc9ad36968300e83afd93776d73802
parent e496a640270c1d02b64c839dbce86eff9128d5e4

ART: Fix fieldnull tidy warning

performance-unnecessary-value-param is supposed to be fatal.

Bug: 32619234
Test: mmma art
Change-Id: Ib2a98ac919a7965c5c477cfaf82317e0d11abc53

tools/field-null-percent/fieldnull.cc

diff --git a/tools/field-null-percent/fieldnull.cc b/tools/field-null-percent/fieldnull.cc
index 86459d2..1bd122a 100644
--- a/tools/field-null-percent/fieldnull.cc
+++ b/tools/field-null-percent/fieldnull.cc
@@ -147,7 +147,7 @@
   delete list;
 }
 
-static void CreateFieldList(jvmtiEnv* jvmti, JNIEnv* env, std::string args) {
+static void CreateFieldList(jvmtiEnv* jvmti, JNIEnv* env, const std::string& args) {
   RequestList* list = nullptr;
   CHECK_JVMTI(jvmti->Allocate(sizeof(*list), reinterpret_cast<unsigned char**>(&list)));
   new (list) RequestList { .fields_ = GetRequestedFields(env, args), };