commit e0447357fa8dece635c213d360cd03160cc2d8a0
author Elliott Hughes <enh@google.com> Mon Jun 11 18:30:31 2012 -0700
committer Elliott Hughes <enh@google.com> Mon Jun 11 18:30:31 2012 -0700
tree e30eb22979d022cedd99552e8c20d7445a2e2301
parent 036eab43bcf86e6ae5d3558f277b7d6797ff2685

Explain why I gave up optimizing Thread::Current for x86.

Change-Id: Ib5da37f8363163f60107005ba0e8b10fc4b0ccc0

src/thread.h

diff --git a/src/thread.h b/src/thread.h
index ef539c0..f621d60 100644
--- a/src/thread.h
+++ b/src/thread.h
@@ -114,6 +114,8 @@
   void InitAfterFork();
 
   static Thread* Current() {
+    // We rely on Thread::Current returning NULL for a detached thread, so it's not obvious
+    // that we can replace this with a direct %fs access on x86.
     void* thread = pthread_getspecific(Thread::pthread_key_self_);
     return reinterpret_cast<Thread*>(thread);
   }