commit cb55b29e466939d222b83f0593a1141221f2425c
author Vladimir Marko <vmarko@google.com> Thu Apr 21 14:52:03 2016 +0100
committer Vladimir Marko <vmarko@google.com> Thu Apr 21 15:17:34 2016 +0100
tree 0f9aef9da0889961b1ce00c324e1c56487b9ef53
parent 0d399c71cb176b0a31d6d51f950c7c32a43668ef

Thumb2: Fix disassembly of the b.w offset.

Bug: 28311085
Change-Id: If729af888be65e1f24362b9c4ed79f124446024d

disassembler/disassembler_arm.cc

diff --git a/disassembler/disassembler_arm.cc b/disassembler/disassembler_arm.cc
index 77efb6b..bcb0438 100644
--- a/disassembler/disassembler_arm.cc
+++ b/disassembler/disassembler_arm.cc
@@ -1262,10 +1262,10 @@
               imm32 = (S << 20) | (J2 << 19) | (J1 << 18) | (imm6 << 12) | (imm11 << 1);
               imm32 = (imm32 << 11) >> 11;  // sign extend 21 bit immediate.
             } else {
-              uint32_t I1 = ~(J1 ^ S);
-              uint32_t I2 = ~(J2 ^ S);
+              uint32_t I1 = (J1 ^ S) ^ 1;
+              uint32_t I2 = (J2 ^ S) ^ 1;
               imm32 = (S << 24) | (I1 << 23) | (I2 << 22) | (imm10 << 12) | (imm11 << 1);
-              imm32 = (imm32 << 8) >> 8;  // sign extend 24 bit immediate.
+              imm32 = (imm32 << 7) >> 7;  // sign extend 25 bit immediate.
             }
             opcode << ".w";
             DumpBranchTarget(args, instr_ptr + 4, imm32);