commit ad7fa6ec6bfe4b04d3985ad896274a4511fcfdef
author Mathieu Chartier <mathieuc@google.com> Wed Mar 27 11:24:29 2019 -0700
committer Mathieu Chartier <mathieuc@google.com> Thu Mar 28 01:45:58 2019 +0000
tree d8451f6122a2a331092d26995544c5c7a9fbdbcc
parent 097d976411caec0b72194523c73e30ebbece14b0

Delete alloc tracker properties

These properties are not officially documented and should not
be supported.

Deleted:
dalvik.vm.allocTrackerMax
dalvik.vm.recentAllocMax

Left debug.allocTracker.stackDepth since it is still used in a few
places.

Bug: 37291459
Test: test-art-host
Change-Id: I6755ea769cf9dcd2872e216cb78161ca7ad38e99

runtime/gc/allocation_record.cc

diff --git a/runtime/gc/allocation_record.cc b/runtime/gc/allocation_record.cc
index 80e3394..40792c4 100644
--- a/runtime/gc/allocation_record.cc
+++ b/runtime/gc/allocation_record.cc
@@ -41,40 +41,8 @@
 
 void AllocRecordObjectMap::SetProperties() {
 #ifdef ART_TARGET_ANDROID
-  // Check whether there's a system property overriding the max number of records.
-  const char* propertyName = "dalvik.vm.allocTrackerMax";
-  std::string allocMaxString = android::base::GetProperty(propertyName, "");
-  if (!allocMaxString.empty()) {
-    char* end;
-    size_t value = strtoul(allocMaxString.c_str(), &end, 10);
-    if (*end != '\0') {
-      LOG(ERROR) << "Ignoring  " << propertyName << " '" << allocMaxString
-                 << "' --- invalid";
-    } else {
-      alloc_record_max_ = value;
-      if (recent_record_max_ > value) {
-        recent_record_max_ = value;
-      }
-    }
-  }
-  // Check whether there's a system property overriding the number of recent records.
-  propertyName = "dalvik.vm.recentAllocMax";
-  std::string recentAllocMaxString = android::base::GetProperty(propertyName, "");
-  if (!recentAllocMaxString.empty()) {
-    char* end;
-    size_t value = strtoul(recentAllocMaxString.c_str(), &end, 10);
-    if (*end != '\0') {
-      LOG(ERROR) << "Ignoring  " << propertyName << " '" << recentAllocMaxString
-                 << "' --- invalid";
-    } else if (value > alloc_record_max_) {
-      LOG(ERROR) << "Ignoring  " << propertyName << " '" << recentAllocMaxString
-                 << "' --- should be less than " << alloc_record_max_;
-    } else {
-      recent_record_max_ = value;
-    }
-  }
   // Check whether there's a system property overriding the max depth of stack trace.
-  propertyName = "debug.allocTracker.stackDepth";
+  const char* propertyName = "debug.allocTracker.stackDepth";
   std::string stackDepthString = android::base::GetProperty(propertyName, "");
   if (!stackDepthString.empty()) {
     char* end;