commit a76605a4bbe93b79aa28a85cdc4a2aeac869c1ca
author Alex Light <allight@google.com> Tue Jan 16 12:51:23 2018 -0800
committer Alex Light <allight@google.com> Thu Jan 18 15:34:38 2018 -0800
tree ff4e1935a48f02fff769bae3c75f8488836e978e
parent ad643b01de3f1152badfb12edb8469d40843d1e7

Change default dalvik.vm.jdwp-provider to adbconnection

This changes the default jdwp implementation to be libjdwp with the
connection mediated by libadbconnection.

Test: ./test.py --host -j50
Test: ./art/tools/run-libjdwp-tests.sh --mode=device
Test: Build and run
Test: use ddms monitor.
Test: Use Android Studio.
Test: Build and debug debuggable app (bandhook-kotlin)
Test: Build and debug non-debuggable app on userdebug build
      (bandhook-kotlin)
Test: Debug running system process on userdebug build
      (com.android.packageinstaller)
Test: adb shell stop &&
      adb shell setprop dalvik.vm.jdwp-provider adbconnection &&
      adb shell start;
      Test debugger with explicit adbconnection jdwp provider set
Test: adb shell stop &&
      adb shell setprop dalvik.vm.jdwp-provider default &&
      adb shell start;
      Test debugger with explicit default jdwp provider set
      Ensure debugger is using the 'adbconnection' provider
Test: adb shell stop &&
      adb shell setprop dalvik.vm.jdwp-provider internal &&
      adb shell start;
      Test debugger with explicit internal jdwp provider set
      Ensure debugger is using the old internal jdwp implementation.

Bug: 62821960
Change-Id: I6470a90e0ca264fb75028f6e7e23878c059b090e

cmdline/cmdline_parser_test.cc

diff --git a/cmdline/cmdline_parser_test.cc b/cmdline/cmdline_parser_test.cc
index 5d67206..70cc07e 100644
--- a/cmdline/cmdline_parser_test.cc
+++ b/cmdline/cmdline_parser_test.cc
@@ -375,7 +375,7 @@
 
 TEST_F(CmdlineParserTest, TestJdwpProviderDefault) {
   const char* opt_args = "-XjdwpProvider:default";
-  EXPECT_SINGLE_PARSE_VALUE(JdwpProvider::kInternal, opt_args, M::JdwpProvider);
+  EXPECT_SINGLE_PARSE_VALUE(JdwpProvider::kAdbConnection, opt_args, M::JdwpProvider);
 }  // TEST_F
 
 TEST_F(CmdlineParserTest, TestJdwpProviderInternal) {

cmdline/cmdline_types.h

diff --git a/cmdline/cmdline_types.h b/cmdline/cmdline_types.h
index d0d6bfd..2bc7409 100644
--- a/cmdline/cmdline_types.h
+++ b/cmdline/cmdline_types.h
@@ -77,10 +77,10 @@
           "Example: -XjdwpProvider:internal for internal jdwp implementation\n"
           "Example: -XjdwpProvider:adbconnection for adb connection mediated jdwp implementation\n"
           "Example: -XjdwpProvider:default for the default jdwp implementation"
-          " (currently internal)\n");
-    } else if (option == "internal" || option == "default") {
+          " (currently adbconnection)\n");
+    } else if (option == "internal") {
       return Result::Success(JdwpProvider::kInternal);
-    } else if (option == "adbconnection") {
+    } else if (option == "adbconnection" || option == "default") {
       return Result::Success(JdwpProvider::kAdbConnection);
     } else if (option == "none") {
       return Result::Success(JdwpProvider::kNone);