commit 917c80f148ea8cef57f7c206c8c7954f2f0d13d6
author Roland Levillain <rpl@google.com> Fri Jun 08 16:27:23 2018 +0100
committer Roland Levillain <rpl@google.com> Mon Jun 11 18:46:41 2018 +0100
tree f0a9f06d16cce9cb1b467b5da8e7be2859433400
parent cf8e60fceee8b622b63f022e7b37f7df0f604320

Simplify the ART Buildbot clean-up script regarding chroot support.

The ART Buildbot is now executing the "setup device" step after the
"device pre-run cleanup" step, and the "tear down device" step before
the "device post-run cleanup" step, so we no longer need to preserve
any part of the chroot directory when cleaning up. Therefore, try to
remove the entire chroot directory during cleanup.

Test: Rely on the ART Buildbot
Bug: 34729697
Change-Id: I6a8c2017bc81f6cb5ed1781d2f97c0169d803532

tools/cleanup-buildbot-device.sh

diff --git a/tools/cleanup-buildbot-device.sh b/tools/cleanup-buildbot-device.sh
index ca5219a..694c739 100755
--- a/tools/cleanup-buildbot-device.sh
+++ b/tools/cleanup-buildbot-device.sh
@@ -28,33 +28,16 @@
     exit 1
   fi
 
-  echo -e "${green}Clean up /system in chroot${nc}"
-  # Remove all files under /system except the potential property_contexts file.
-  #
-  # The current ART Buildbot set-up runs the "setup device" step
-  # (performed by script tools/setup-buildbot-device.sh) before the
-  # "device cleanup" step (implemented by this script). As
-  # property_contexts file aliases are created during the former step,
-  # we need this exception to prevent the property_contexts file under
-  # /system in the chroot from being removed by the latter step.
-  #
-  # TODO: Reorder ART Buildbot steps so that "device cleanup" happens
-  # before "setup device" and remove this special case.
-  adb shell test -d "$ART_TEST_CHROOT/system" \
-    "&&" find "$ART_TEST_CHROOT/system" \
-      ! -path "$ART_TEST_CHROOT/system/etc/selinux/plat_property_contexts" \
-      ! -type d \
-      -exec rm -f \{\} +
+  if adb shell test -d "$ART_TEST_CHROOT"; then
+    echo -e "${green}Remove entire /system directory from chroot directory${nc}"
+    adb shell rm -rf "$ART_TEST_CHROOT/system"
 
-  echo -e "${green}Clean up some subdirs in /data in chroot${nc}"
-  adb shell rm -rf \
-    "$ART_TEST_CHROOT/data/local/tmp/*" \
-    "$ART_TEST_CHROOT/data/art-test" \
-    "$ART_TEST_CHROOT/data/nativetest" \
-    "$ART_TEST_CHROOT/data/nativetest64" \
-    "$ART_TEST_CHROOT/data/run-test" \
-    "$ART_TEST_CHROOT/data/dalvik-cache/*" \
-    "$ART_TEST_CHROOT/data/misc/trace/*"
+    echo -e "${green}Remove entire /data directory from chroot directory${nc}"
+    adb shell rm -rf "$ART_TEST_CHROOT/data"
+
+    echo -e "${green}Remove entire chroot directory${nc}"
+    adb shell rmdir "$ART_TEST_CHROOT" || adb shell ls -la "$ART_TEST_CHROOT"
+  fi
 else
   adb shell rm -rf \
     /data/local/tmp /data/art-test /data/nativetest /data/nativetest64 '/data/misc/trace/*'