commit 797a29b334f2d311135602bf5204ae8b890f4a14
author Dmitriy Ivanov <dimitry@google.com> Tue Jan 06 14:55:26 2015 -0800
committer Dmitriy Ivanov <dimitry@google.com> Tue Jan 06 15:22:10 2015 -0800
tree 0279325edbdd153b4831cab8fd914a28dc230c8c
parent 56e7666fe0df2c1a16b2cc6d12562c3e82199c0d

Fix sigchainlib's implementation of sigaction

  Correctly handles the case when old_action == new_action

Bug: 18740478
Change-Id: I97092318439e4f6f0a2513d4336496c72f8c5599

sigchainlib/sigchain.cc

diff --git a/sigchainlib/sigchain.cc b/sigchainlib/sigchain.cc
index 4f16c7f..938faf1 100644
--- a/sigchainlib/sigchain.cc
+++ b/sigchainlib/sigchain.cc
@@ -162,12 +162,13 @@
   // Note that we check that the signal number is in range here.  An out of range signal
   // number should behave exactly as the libc sigaction.
   if (signal > 0 && signal < _NSIG && user_sigactions[signal].IsClaimed()) {
-    if (old_action != NULL) {
-      *old_action = user_sigactions[signal].GetAction();
-    }
+    struct sigaction saved_action = user_sigactions[signal].GetAction();
     if (new_action != NULL) {
       user_sigactions[signal].SetAction(*new_action);
     }
+    if (old_action != NULL) {
+      *old_action = saved_action;
+    }
     return 0;
   }