commit 666527de37f04d50e52987d5d0878f2de9cc1e8a
author Brian Carlstrom <bdc@google.com> Tue Mar 06 22:35:50 2012 -0800
committer Android (Google) Code Review <android-gerrit@google.com> Tue Mar 06 22:35:50 2012 -0800
tree 35c1a71c9f2a35db3022162b69e751f0e9b481cf
parent be5ff20bc68de0d14f043421815c5f3dbe0c39da
parent 37c44442a0f1b3ae5f95e40d455022bcafb566e4

Merge "Expand test-art to cover rest of run-test" into dalvik-dev

src/compiler.cc

diff --git a/src/compiler.cc b/src/compiler.cc
index 1797530..2ba89d4 100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -983,7 +983,7 @@
   const DexFile::ClassDef& class_def = dex_file.GetClassDef(class_def_index);
 
 #if defined(ART_USE_LLVM_COMPILER)
-  compiler_llvm::CompilerLLVM* compiler_llvm = context->compiler->GetCompilerLLVM();
+  compiler_llvm::CompilerLLVM* compiler_llvm = context->GetCompiler()->GetCompilerLLVM();
 
   MutexLock GUARD(compiler_llvm->compiler_lock_);
   // TODO: Remove this.  We should not lock the compiler_lock_ in CompileClass()

src/compiler_llvm/compiler_llvm.cc

diff --git a/src/compiler_llvm/compiler_llvm.cc b/src/compiler_llvm/compiler_llvm.cc
index b2a6d28..6646b19 100644
--- a/src/compiler_llvm/compiler_llvm.cc
+++ b/src/compiler_llvm/compiler_llvm.cc
@@ -41,11 +41,10 @@
 // ARMISelLowering.cpp, however, it is not in the llvm namespace.
 
 
-namespace {
+namespace art {
+namespace compiler_llvm {
 
-pthread_once_t llvm_initialized = PTHREAD_ONCE_INIT;
-
-void InitializeLLVM() {
+CompilerLLVM::LLVMInitializer::LLVMInitializer() {
   // NOTE: Uncomment following line to show the time consumption of LLVM passes
   //llvm::TimePassesIsEnabled = true;
 
@@ -76,11 +75,13 @@
   llvm::llvm_start_multithreaded();
 }
 
-} // anonymous namespace
+CompilerLLVM::LLVMInitializer::~LLVMInitializer() {
+  llvm::llvm_shutdown();
+}
 
-
-namespace art {
-namespace compiler_llvm {
+// Singleton. Otherwise, multiple CompilerLLVM instances may cause crashes if
+// one shuts down prematurely.
+CompilerLLVM::LLVMInitializer CompilerLLVM::llvm_initialize_guard;
 
 
 llvm::Module* makeLLVMModuleContents(llvm::Module* module);
@@ -89,20 +90,15 @@
 CompilerLLVM::CompilerLLVM(Compiler* compiler, InstructionSet insn_set)
     : compiler_(compiler), compiler_lock_("llvm_compiler_lock"),
       insn_set_(insn_set), curr_cunit_(NULL) {
-
-  // Initialize LLVM libraries
-  pthread_once(&llvm_initialized, InitializeLLVM);
 }
 
 
 CompilerLLVM::~CompilerLLVM() {
   STLDeleteElements(&cunits_);
-  llvm::llvm_shutdown();
 }
 
 
 void CompilerLLVM::EnsureCompilationUnit() {
-  DCHECK_NE(llvm_initialized, PTHREAD_ONCE_INIT);
   compiler_lock_.AssertHeld();
 
   if (curr_cunit_ != NULL) {

src/compiler_llvm/compiler_llvm.h

diff --git a/src/compiler_llvm/compiler_llvm.h b/src/compiler_llvm/compiler_llvm.h
index 7481c8c..6332fb3 100644
--- a/src/compiler_llvm/compiler_llvm.h
+++ b/src/compiler_llvm/compiler_llvm.h
@@ -107,6 +107,13 @@
 
   std::string bitcode_filename_;
 
+  class LLVMInitializer {
+   public:
+    LLVMInitializer();
+    ~LLVMInitializer();
+  };
+  static LLVMInitializer llvm_initialize_guard;
+
   DISALLOW_COPY_AND_ASSIGN(CompilerLLVM);
 };