commit 4ac605e3a0d0b33927dfb9a87b201bad37478657
author Alex Light <allight@google.com> Tue Jul 10 11:34:02 2018 -0700
committer Alex Light <allight@google.com> Tue Jul 10 14:30:03 2018 -0700
tree 756b1a5b63609bdedef53d46b728d56f1d1166a9
parent b8f199705ebd673563fac5cd416a44794d07f692

Make Get/SetLocalVariables not pause jit.

We were unnecessarily pausing the jit when retrieving or setting local
variables. This could cause deadlocks in some situations.

Test: ./test.py --host -j50
Test: ./art/tools/run-libjdwp-tests.sh --mode=host
Test: see b/111131691

Bug: 111131691
Change-Id: If681b52a2dbabc118a252436e5083f99e79b3ddd

openjdkjvmti/ti_method.cc

diff --git a/openjdkjvmti/ti_method.cc b/openjdkjvmti/ti_method.cc
index b83310d..f75dd50 100644
--- a/openjdkjvmti/ti_method.cc
+++ b/openjdkjvmti/ti_method.cc
@@ -783,8 +783,6 @@
     return ERR(ILLEGAL_ARGUMENT);
   }
   art::Thread* self = art::Thread::Current();
-  // Suspend JIT since it can get confused if we deoptimize methods getting jitted.
-  art::jit::ScopedJitSuspend suspend_jit;
   art::ScopedObjectAccess soa(self);
   art::Locks::thread_list_lock_->ExclusiveLock(self);
   art::Thread* target = nullptr;
@@ -919,8 +917,6 @@
   // TODO We should really keep track of this at the Frame granularity.
   DeoptManager::Get()->SetLocalsUpdated();
   art::Thread* self = art::Thread::Current();
-  // Suspend JIT since it can get confused if we deoptimize methods getting jitted.
-  art::jit::ScopedJitSuspend suspend_jit;
   art::ScopedObjectAccess soa(self);
   art::Locks::thread_list_lock_->ExclusiveLock(self);
   art::Thread* target = nullptr;