commit 338403c9000a4ff8fbb73fd107fce25801345626
author Greg Kaiser <gkaiser@google.com> Tue Mar 26 08:22:13 2019 -0700
committer Treehugger Robot <treehugger-gerrit@google.com> Tue Mar 26 17:35:30 2019 +0000
tree 0e949b2cf9199f0b6a46f297bd9720f599e8eb2e
parent f276f957e5293998c1fbf14114434787392a1d12

jni: Avoid extra std::string copies

The methods FindSymbolWith{,out}NativeBridge() take const
std::string references, so it's inefficient to pass in a
std::string::c_str().

Test: TreeHugger
Change-Id: I82e023d22cb2d9639bd4e32d05b0620dc09efd3e

runtime/jni/java_vm_ext.cc

diff --git a/runtime/jni/java_vm_ext.cc b/runtime/jni/java_vm_ext.cc
index 90ac5f6..bbd6d68 100644
--- a/runtime/jni/java_vm_ext.cc
+++ b/runtime/jni/java_vm_ext.cc
@@ -161,8 +161,8 @@
   void* FindSymbol(const std::string& symbol_name, const char* shorty = nullptr)
       REQUIRES(!Locks::mutator_lock_) {
     return NeedsNativeBridge()
-        ? FindSymbolWithNativeBridge(symbol_name.c_str(), shorty)
-        : FindSymbolWithoutNativeBridge(symbol_name.c_str());
+        ? FindSymbolWithNativeBridge(symbol_name, shorty)
+        : FindSymbolWithoutNativeBridge(symbol_name);
   }
 
   // No mutator lock since dlsym may block for a while if another thread is doing dlopen.