commit 20a409c99a649a01cb7c65bd1089988445d8cdfd
author Brian Carlstrom <bdc@google.com> Mon Dec 12 15:30:56 2011 -0800
committer Android (Google) Code Review <android-gerrit@google.com> Mon Dec 12 15:30:56 2011 -0800
tree 8f2b27d449317467d994eb8034559477188376ef
parent 9f1ab126ff140f452c124dddf9b8a1ced6daf89a
parent 2aab947ddafdd7dbabf9858cbf0364c2f68948e1

Merge "Include DexFile::GetLocation() in DexFile LOGs" into dalvik-dev

src/dex_file.cc

diff --git a/src/dex_file.cc b/src/dex_file.cc
index b3d7144..b92760b 100644
--- a/src/dex_file.cc
+++ b/src/dex_file.cc
@@ -72,7 +72,7 @@
 
 void DexFile::ChangePermissions(int prot) const {
   if (mprotect(mem_map_->GetAddress(), mem_map_->GetLength(), prot) != 0) {
-    PLOG(FATAL) << "Failed to change dex file permissions to " << prot;
+    PLOG(FATAL) << "Failed to change dex file permissions to " << prot << " for " << GetLocation();
   }
 }
 
@@ -408,7 +408,7 @@
 bool DexFile::CheckMagic(const byte* magic) {
   CHECK(magic != NULL) << GetLocation();
   if (memcmp(magic, kDexMagic, sizeof(kDexMagic)) != 0) {
-    LOG(ERROR) << "Unrecognized magic number:"
+    LOG(ERROR) << "Unrecognized magic number in "  << GetLocation() << ":"
             << " " << magic[0]
             << " " << magic[1]
             << " " << magic[2]
@@ -417,7 +417,7 @@
   }
   const byte* version = &magic[sizeof(kDexMagic)];
   if (memcmp(version, kDexMagicVersion, sizeof(kDexMagicVersion)) != 0) {
-    LOG(ERROR) << "Unrecognized version number:"
+    LOG(ERROR) << "Unrecognized version number in "  << GetLocation() << ":"
             << " " << version[0]
             << " " << version[1]
             << " " << version[2]
@@ -767,7 +767,7 @@
   for (uint32_t i = 0; i < parameters_size && it.HasNext(); ++i, it.Next()) {
     if (arg_reg >= code_item->registers_size_) {
       LOG(ERROR) << "invalid stream - arg reg >= reg size (" << arg_reg
-                 << " >= " << code_item->registers_size_ << ")";
+                 << " >= " << code_item->registers_size_ << ") in " << GetLocation();
       return;
     }
     uint32_t id = DecodeUnsignedLeb128P1(&stream);
@@ -792,7 +792,7 @@
   }
 
   if (it.HasNext()) {
-    LOG(ERROR) << "invalid stream - problem with parameter iterator";
+    LOG(ERROR) << "invalid stream - problem with parameter iterator in " << GetLocation();
     return;
   }
 
@@ -820,7 +820,7 @@
         reg = DecodeUnsignedLeb128(&stream);
         if (reg > code_item->registers_size_) {
           LOG(ERROR) << "invalid stream - reg > reg size (" << reg << " > "
-                     << code_item->registers_size_ << ")";
+                     << code_item->registers_size_ << ") in " << GetLocation();
           return;
         }
 
@@ -848,7 +848,7 @@
         reg = DecodeUnsignedLeb128(&stream);
         if (reg > code_item->registers_size_) {
           LOG(ERROR) << "invalid stream - reg > reg size (" << reg << " > "
-                     << code_item->registers_size_ << ")";
+                     << code_item->registers_size_ << ") in " << GetLocation();
           return;
         }
 
@@ -862,13 +862,13 @@
         reg = DecodeUnsignedLeb128(&stream);
         if (reg > code_item->registers_size_) {
           LOG(ERROR) << "invalid stream - reg > reg size (" << reg << " > "
-                     << code_item->registers_size_ << ")";
+                     << code_item->registers_size_ << ") in " << GetLocation();
           return;
         }
 
         if (need_locals) {
           if (local_in_reg[reg].name_ == NULL || local_in_reg[reg].descriptor_ == NULL) {
-            LOG(ERROR) << "invalid stream - no name or descriptor";
+            LOG(ERROR) << "invalid stream - no name or descriptor in " << GetLocation();
             return;
           }