commit 167350d9c781c5e3893714bb26ab5cb1c4abf6b4
author Mathieu Chartier <mathieuc@google.com> Wed Aug 20 12:09:38 2014 -0700
committer Mathieu Chartier <mathieuc@google.com> Wed Aug 20 12:37:32 2014 -0700
tree bbc962cd842d343ccc3636931d113a48bfa48eff
parent a846c1ac65b197844380b8d28377a850dfa1fc94

Add null check to CheckVirtualMethod

There was a runtime SIGSEGV that should have been a check jni
failure.

Also added regression test.

Bug: 16320699
Change-Id: If6c8e73959cefb24e4703f1562cdddb343d86630

runtime/check_jni.cc

diff --git a/runtime/check_jni.cc b/runtime/check_jni.cc
index a530594..9036e3d 100644
--- a/runtime/check_jni.cc
+++ b/runtime/check_jni.cc
@@ -353,7 +353,9 @@
       return;
     }
     mirror::Object* o = soa_.Decode<mirror::Object*>(java_object);
-    if (!o->InstanceOf(m->GetDeclaringClass())) {
+    if (o == nullptr) {
+      JniAbortF(function_name_, "can't call %s on null object", PrettyMethod(m).c_str());
+    } else if (!o->InstanceOf(m->GetDeclaringClass())) {
       JniAbortF(function_name_, "can't call %s on instance of %s",
                 PrettyMethod(m).c_str(), PrettyTypeOf(o).c_str());
     }

runtime/jni_internal_test.cc

diff --git a/runtime/jni_internal_test.cc b/runtime/jni_internal_test.cc
index da3080f..bb46321 100644
--- a/runtime/jni_internal_test.cc
+++ b/runtime/jni_internal_test.cc
@@ -314,6 +314,22 @@
   check_jni_abort_catcher.Check("sig == null");
 }
 
+TEST_F(JniInternalTest, CallVoidMethodNullReceiver) {
+  jclass jlobject = env_->FindClass("java/lang/Object");
+  jmethodID method;
+
+  // Check that GetMethodID for java.lang.NoSuchMethodError.<init>(String) finds the constructor.
+  method = env_->GetMethodID(jlobject, "<init>", "()V");
+  EXPECT_NE(nullptr, method);
+  EXPECT_FALSE(env_->ExceptionCheck());
+
+  // Null object to CallVoidMethod.
+  CheckJniAbortCatcher check_jni_abort_catcher;
+  method = env_->GetMethodID(nullptr, "<init>", "(Ljava/lang/String;)V");
+  env_->CallVoidMethod(nullptr, method);
+  check_jni_abort_catcher.Check("null");
+}
+
 TEST_F(JniInternalTest, GetStaticMethodID) {
   jclass jlobject = env_->FindClass("java/lang/Object");
   jclass jlnsme = env_->FindClass("java/lang/NoSuchMethodError");