commit f30e6661a45060e58a3be693b86556557781a620
author Nick Chung <nickchung@google.com> Wed Mar 30 22:07:37 2022 +0800
committer Nick Chung <nickchung@google.com> Wed Mar 30 22:47:58 2022 +0800
tree d0e366e196378b58a9338160289f68dc0c1bb048
parent 697c383e7b8b7a855f96e484c89449ad9465b867

DPM: fix clk_index OOB access

Bug: 225877745
Test: CTS, GCA, test_poc
Signed-off-by: Nick Chung <nickchung@google.com>
Change-Id: If41d2f0f7ccb3d4fb72ac17ca31e5bc84c98648d

lwis_device_dpm.c

diff --git a/lwis_device_dpm.c b/lwis_device_dpm.c
index 748bb06..78d264d 100644
--- a/lwis_device_dpm.c
+++ b/lwis_device_dpm.c
@@ -127,7 +127,7 @@
 
 	for (i = 0; i < num_settings; ++i) {
 		clk_index = clk_settings[i].clk_index;
-		if (clk_index >= lwis_dev->clocks->count) {
+		if (clk_index < 0 || clk_index >= lwis_dev->clocks->count) {
 			dev_err(lwis_dev->dev, "%s clk index %d is invalid\n", lwis_dev->name,
 				clk_index);
 			ret = -EINVAL;