UPSTREAM: mm/kasan: fix false positive invalid-free reports with CONFIG_KASAN_SW_TAGS=y

(Upstream commit 00fb24a42a68b1ee0f6495993fe1be7124433dfb).

The code like this:

	ptr = kmalloc(size, GFP_KERNEL);
	page = virt_to_page(ptr);
	offset = offset_in_page(ptr);
	kfree(page_address(page) + offset);

may produce false-positive invalid-free reports on the kernel with

In the example above we lose the original tag assigned to 'ptr', so
kfree() gets the pointer with 0xFF tag.  In kfree() we check that 0xFF
tag is different from the tag in shadow hence print false report.

Instead of just comparing tags, do the following:

1) Check that shadow doesn't contain KASAN_TAG_INVALID.  Otherwise it's
   double-free and it doesn't matter what tag the pointer have.

2) If pointer tag is different from 0xFF, make sure that tag in the
   shadow is the same as in the pointer.

Fixes: 7f94ffbc4c6a ("kasan: add hooks implementation for tag-based mode")
Signed-off-by: Andrey Ryabinin <>
Reported-by: Walter Wu <>
Reported-by: Mark Rutland <>
Reviewed-by: Andrey Konovalov <>
Cc: Alexander Potapenko <>
Cc: Dmitry Vyukov <>
Cc: Catalin Marinas <>
Cc: Will Deacon <>
Cc: <>
Signed-off-by: Andrew Morton <>
Signed-off-by: Linus Torvalds <>
Signed-off-by: Andrey Konovalov <>
Change-Id: Idea0193d125b9d695b025c00800b06758a37b3ba
Bug: 128674696
diff --git a/mm/kasan/common.c b/mm/kasan/common.c
index d5ea31e..b888980 100644
--- a/mm/kasan/common.c
+++ b/mm/kasan/common.c
@@ -415,8 +415,14 @@
 		return shadow_byte < 0 ||
 			shadow_byte >= KASAN_SHADOW_SCALE_SIZE;
-	else
-		return tag != (u8)shadow_byte;
+	/* else CONFIG_KASAN_SW_TAGS: */
+	if ((u8)shadow_byte == KASAN_TAG_INVALID)
+		return true;
+	if ((tag != KASAN_TAG_KERNEL) && (tag != (u8)shadow_byte))
+		return true;
+	return false;
 static bool __kasan_slab_free(struct kmem_cache *cache, void *object,