| From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 |
| From: Dmitry Torokhov <dtor@chromium.org> |
| Date: Thu, 6 Oct 2016 16:14:16 -0700 |
| Subject: CHROMIUM: cgroups: relax permissions on moving tasks between cgroups |
| |
| Android expects system_server to be able to move tasks between different |
| cgroups/cpusets, but does not want to be running as root. Let's relax |
| permission check so that processes can move other tasks if they have |
| CAP_SYS_NICE in the affected task's user namespace. |
| |
| [CPNOTE: 16/06/21] Lee: Reached out to the author for status |
| [CPNOTE: 17/06/21] Lee: NACKed upstream - pinged the bug to gauge its current usefulness |
| [CPNOTE: 05/08/21] Lee: Reopened the bug, reassigned it and requested an OoT bug to track |
| |
| BUG=b:31790445,chromium:647994 |
| Bug: 147109865 |
| But: 120445593 # OoT |
| TEST=Boot android container, examine logcat |
| |
| Signed-off-by: Dmitry Torokhov <dtor@chromium.org> |
| Reviewed-on: https://chromium-review.googlesource.com/394927 |
| Reviewed-by: Ricky Zhou <rickyz@chromium.org> |
| [AmitP: Refactored original changes to align with upstream commit |
| 201af4c0fab0 ("cgroup: move cgroup files under kernel/cgroup/")] |
| Change-Id: Ia919c66ab6ed6a6daf7c4cf67feb38b13b1ad09b |
| Signed-off-by: Amit Pundir <amit.pundir@linaro.org> |
| (cherry picked from commit ec54762b84a1d06de188bc846655305d3f7acf75) |
| --- |
| kernel/cgroup/cgroup-v1.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| diff --git a/kernel/cgroup/cgroup-v1.c b/kernel/cgroup/cgroup-v1.c |
| --- a/kernel/cgroup/cgroup-v1.c |
| +++ b/kernel/cgroup/cgroup-v1.c |
| @@ -511,7 +511,8 @@ static ssize_t __cgroup1_procs_write(struct kernfs_open_file *of, |
| tcred = get_task_cred(task); |
| if (!uid_eq(cred->euid, GLOBAL_ROOT_UID) && |
| !uid_eq(cred->euid, tcred->uid) && |
| - !uid_eq(cred->euid, tcred->suid)) |
| + !uid_eq(cred->euid, tcred->suid) && |
| + !ns_capable(tcred->user_ns, CAP_SYS_NICE)) |
| ret = -EACCES; |
| put_cred(tcred); |
| if (ret) |
