commit d689771149cebfa998ada5d28a7596f06c48da08
author Dandan Bi <dandan.bi@intel.com> Sat Apr 01 10:31:14 2017 +0800
committer Fathi Boudra <fathi.boudra@linaro.org> Thu Nov 02 13:46:33 2017 +0200
tree 4ddfe73c63be9fd7730b15d833d6ee73544a4b6b
parent 19f735580a73a349e46214f22be5688ad834a334

MdeModulePkg/UefiHiiLib:Fix incorrect comparison expression

Fix the incorrect comparison between pointer and constant zero character.

https://bugzilla.tianocore.org/show_bug.cgi?id=416

V2: The pointer StringPtr points to a string returned
by ExtractConfig/ExportConfig, if it is NULL, function
InternalHiiIfrValueAction will return FALSE. So in
current usage model, the StringPtr can not be NULL before
using it, so we can add ASSERT here.

Cc: Eric Dong <eric.dong@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>

MdeModulePkg/Library/UefiHiiLib/HiiLib.c

diff --git a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
index 8579501..46ca7bc 100644
--- a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
+++ b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
@@ -2180,8 +2180,9 @@
   }

   

   StringPtr = ConfigAltResp;

-  

-  while (StringPtr != L'\0') {

+  ASSERT (StringPtr != NULL);

+

+  while (*StringPtr != L'\0') {

     //

     // 1. Find <ConfigHdr> GUID=...&NAME=...&PATH=...

     //