commit 9ec24f5f7322402e8ac5ba0501cd271dd17bf237
author Dandan Bi <dandan.bi@intel.com> Mon Oct 17 13:51:05 2016 +0800
committer Star Zeng <star.zeng@intel.com> Wed Oct 19 11:37:51 2016 +0800
tree adad9db2d6e20e6678f3fbb5b804e7cbba57e4e6
parent a3475fe0de2e085c73733758026df010b5a6b8ad

MdeModulePkg/BMMUI: Remove the incorrect and useless codes

When updating console page, the "ConsoleCheck" in BmmFakeNvData may maintain
the old uncommitted data, we should not copy it to BmmOldFakeNVData.
And in BootMaintRouteConfig function, when save data successfully,
it will copy the BmmFakeNvData to the BmmOldFakeNVData.
So we can delete the logic here.

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>

MdeModulePkg/Library/BootMaintenanceManagerUiLib/UpdatePage.c

diff --git a/MdeModulePkg/Library/BootMaintenanceManagerUiLib/UpdatePage.c b/MdeModulePkg/Library/BootMaintenanceManagerUiLib/UpdatePage.c
index ee8ff5d..960d0b0 100644
--- a/MdeModulePkg/Library/BootMaintenanceManagerUiLib/UpdatePage.c
+++ b/MdeModulePkg/Library/BootMaintenanceManagerUiLib/UpdatePage.c
@@ -459,8 +459,6 @@
   UINT16              Index2;

   UINT8               CheckFlags;

   UINT8               *ConsoleCheck;

-  UINT8               *OldConsoleCheck;

-  UINTN               ConsoleCheckSize;

   EFI_QUESTION_ID     QuestionIdBase;

   UINT16              VariableOffsetBase;

 

@@ -469,32 +467,24 @@
   UpdatePageStart (CallbackData);

 

   ConsoleCheck       = NULL;

-  OldConsoleCheck    = NULL;

   QuestionIdBase     = 0;

   VariableOffsetBase = 0;

-  ConsoleCheckSize   = 0;

 

   switch (UpdatePageId) {

   case FORM_CON_IN_ID:

     ConsoleCheck       = &CallbackData->BmmFakeNvData.ConsoleInCheck[0];

-    OldConsoleCheck    = &CallbackData->BmmOldFakeNVData.ConsoleInCheck[0];

-    ConsoleCheckSize   = sizeof (CallbackData->BmmFakeNvData.ConsoleInCheck);

     QuestionIdBase     = CON_IN_DEVICE_QUESTION_ID;

     VariableOffsetBase = CON_IN_DEVICE_VAR_OFFSET;

     break;

 

   case FORM_CON_OUT_ID:

     ConsoleCheck       = &CallbackData->BmmFakeNvData.ConsoleOutCheck[0];

-    OldConsoleCheck    = &CallbackData->BmmOldFakeNVData.ConsoleOutCheck[0];

-    ConsoleCheckSize   = sizeof (CallbackData->BmmFakeNvData.ConsoleOutCheck);

     QuestionIdBase     = CON_OUT_DEVICE_QUESTION_ID;

     VariableOffsetBase = CON_OUT_DEVICE_VAR_OFFSET;

     break;

 

   case FORM_CON_ERR_ID:

     ConsoleCheck       = &CallbackData->BmmFakeNvData.ConsoleErrCheck[0];

-    OldConsoleCheck    = &CallbackData->BmmOldFakeNVData.ConsoleErrCheck[0];

-    ConsoleCheckSize   = sizeof (CallbackData->BmmFakeNvData.ConsoleErrCheck);

     QuestionIdBase     = CON_ERR_DEVICE_QUESTION_ID;

     VariableOffsetBase = CON_ERR_DEVICE_VAR_OFFSET;

     break;

@@ -556,8 +546,6 @@
     Index++;

   }

 

-  CopyMem (OldConsoleCheck, ConsoleCheck, ConsoleCheckSize);

-

   UpdatePageEnd (CallbackData);

 }