commit 09bd67f09573ad5a40875f3d7bfbf49c43756cf5
author Laszlo Ersek <lersek@redhat.com> Tue Oct 18 12:53:48 2016 +0200
committer Laszlo Ersek <lersek@redhat.com> Tue Oct 18 19:30:38 2016 +0200
tree d0af6e74fc8bec6cac56777f1321302dc032cd6e
parent bfa97024df7c0c4bd94157a1e9c3eb5e89cba656

ShellPkg/Shell: fix CopyGuid() arg order in EfiShellGetGuidFromName()

The destination GUID comes first; from
"MdePkg/Include/Library/BaseMemoryLib.h":

> GUID *
> EFIAPI
> CopyGuid (
>   OUT GUID       *DestinationGuid,
>   IN CONST GUID  *SourceGuid
>   );

Here "NewGuid" is the GUID looked up by GetGuidFromStringName(), and
"Guid" is where EfiShellGetGuidFromName() has to propagate that result to.

Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Tim Lewis <tim.lewis@insyde.com>
Reported-by: Tim Lewis <tim.lewis@insyde.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Tim Lewis <tim.lewis@insyde.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

ShellPkg/Application/Shell/ShellProtocol.c

diff --git a/ShellPkg/Application/Shell/ShellProtocol.c b/ShellPkg/Application/Shell/ShellProtocol.c
index 2bc0646..04b66c5 100644
--- a/ShellPkg/Application/Shell/ShellProtocol.c
+++ b/ShellPkg/Application/Shell/ShellProtocol.c
@@ -2207,7 +2207,7 @@
   Status = GetGuidFromStringName(GuidName, NULL, &NewGuid);

 

   if (!EFI_ERROR(Status)) {

-    CopyGuid(NewGuid, Guid);

+    CopyGuid(Guid, NewGuid);

   }

 

   return (Status);