commit 00650c531a90f29d75dadfc22656554cbea4bb72
author Laszlo Ersek <lersek@redhat.com> Wed Nov 16 22:52:06 2016 +0100
committer Laszlo Ersek <lersek@redhat.com> Thu Nov 17 10:58:07 2016 +0100
tree 28696f86892433637a9f5da29f86e6b9b3d99f1e
parent 5797f61c55867db25c6a6ed03ac27b946990509b

UefiCpuPkg/MpInitLib/X64/MpFuncs.nasm: fix fatal typo

The recent patch "UefiCpuPkg/MpInitLib: Program AP stack in fixed address"
inadvertently broke the first startup of APs during X64 PEI, because in
the TestLock section of the code, it replaced the access to the
NumApsExecuting counter with an access to the unrelated InitFlag field.

Cc: Jeff Fan <jeff.fan@intel.com>
Fixes: 845c5be1fd9bf7edfac4a103dfab70829686978f
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jeff Fan <jeff.fan@intel.com>

UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm

diff --git a/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm b/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm
index 6a8794d..138b973 100644
--- a/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm
+++ b/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm
@@ -134,7 +134,7 @@
     cmp        rax, NotVacantFlag

     jz         TestLock

 

-    lea        ecx, [esi + InitFlagLocation]

+    lea        ecx, [esi + NumApsExecutingLocation]

     inc        dword [ecx]

     mov        ebx, [ecx]