commit d20e247caf801ae6418e4226a19dd98719a7af75
author Pete Chou <petechou@gmail.com> Mon Dec 29 21:05:19 2014 +0800
committer Lai Wei-Chih <Robert.Lai@mediatek.com> Tue Dec 30 13:09:15 2014 +0800
tree 64ce1ec1fe89a1975a9f0fa3d11805c138ba8a2e
parent 7698f2063247a98662c51d1714a5571f55d4c746

Fix comparison between signed and unsigned integer expressions [-Werror=sign-compare].

Change-Id: Icfd4133b73c62d1ac7c9b076e5c3959219bb0671

unittests/ELFReaderTest.cpp

diff --git a/unittests/ELFReaderTest.cpp b/unittests/ELFReaderTest.cpp
index b431be8..f6745d3 100644
--- a/unittests/ELFReaderTest.cpp
+++ b/unittests/ELFReaderTest.cpp
@@ -80,17 +80,17 @@
 // Testcases
 //===----------------------------------------------------------------------===//
 TEST_F(ELFReaderTest, read_section_headers) {
-  ASSERT_EQ(m_pInput->context()->numOfSections(), 13);
+  ASSERT_EQ(m_pInput->context()->numOfSections(), 13u);
   LDContext::const_sect_iterator iter = m_pInput->context()->sectBegin();
   ++iter;  /// test section[1]
   ASSERT_EQ(".text", (*iter)->name());
   ASSERT_EQ(llvm::ELF::SHT_PROGBITS, (*iter)->type());
-  ASSERT_EQ(0x40, (*iter)->offset());
-  ASSERT_EQ(0x15, (*iter)->size());
+  ASSERT_EQ(0x40u, (*iter)->offset());
+  ASSERT_EQ(0x15u, (*iter)->size());
   ASSERT_TRUE(llvm::ELF::SHF_ALLOC & (*iter)->flag());  // AX
-  ASSERT_EQ(0x4, (*iter)->align());
+  ASSERT_EQ(0x4u, (*iter)->align());
   ASSERT_EQ(NULL, (*iter)->getLink());
-  ASSERT_EQ(0, (*iter)->getInfo());
+  ASSERT_EQ(0u, (*iter)->getInfo());
 }
 
 TEST_F(ELFReaderTest, read_symbol_and_rela) {
@@ -135,13 +135,13 @@
   const RelocData::RelocationListType& rRelocs =
       (*rs)->getRelocData()->getRelocationList();
   RelocData::const_iterator rReloc = rRelocs.begin();
-  ASSERT_EQ(2, rRelocs.size());
+  ASSERT_EQ(2u, rRelocs.size());
   ASSERT_TRUE(rRelocs.end() != rReloc);
   ++rReloc;  /// test rRelocs[1]
   ASSERT_EQ("puts", std::string(rReloc->symInfo()->name()));
   ASSERT_EQ(llvm::ELF::R_X86_64_PC32, rReloc->type());
-  ASSERT_EQ(0x0, rReloc->symValue());
-  ASSERT_EQ(-0x4, rReloc->addend());
+  ASSERT_EQ(0x0u, rReloc->symValue());
+  ASSERT_EQ(static_cast<mcld::Relocation::Address>(-0x4), rReloc->addend());
 }
 
 TEST_F(ELFReaderTest, read_regular_sections) {