Increase severity of shader link error if it compiled during trace.
This is just additional sanity check.
Change-Id: If9c878fd481bb3bcc410fb0ad25b5b9fbd59d6ee
diff --git a/gapid/gfxapi/gles/find_issues.go b/gapid/gfxapi/gles/find_issues.go
index fce1353..277af5a 100644
--- a/gapid/gfxapi/gles/find_issues.go
+++ b/gapid/gfxapi/gles/find_issues.go
@@ -211,7 +211,12 @@
fss = shader.Source
}
}
- t.onIssue(i, log.ErrorLevel, fmt.Errorf("Program %d failed to link. Error:\n%v\n"+
+ logLevel := log.ErrorLevel
+ if pi := FindProgramInfo(a.Extras()); pi != nil && pi.LinkStatus == GLboolean_GL_TRUE {
+ // Increase severity if the program linked successfully during trace.
+ logLevel = log.CriticalLevel
+ }
+ t.onIssue(i, logLevel, fmt.Errorf("Program %d failed to link. Error:\n%v\n"+
"Vertex shader source:\n%sFragment shader source:\n%s", a.Program, ntbs(msg), vss, fss))
}
return r.Error()
