Disable orientation locking support in WebView.
The orientation lock code was accidentally inherited from Chrome and
doesn't actually work in WebView. Make it actually fail when JS calls
it, instead of claiming to work but doing nothing, by disabling the
screen orientation provider. This puts WebView in the same state as
desktop chrome which also doesn't set the provider. Tested that this
results in correctly reported errors when JS tries to use the API.
Bug: 19672531
Change-Id: I66a142fc50fa12db418b9465c6f29914633bd9b2
diff --git a/content/browser/browser_main_loop.cc b/content/browser/browser_main_loop.cc
index c7dd81b..4b8fa20 100644
--- a/content/browser/browser_main_loop.cc
+++ b/content/browser/browser_main_loop.cc
@@ -541,6 +541,9 @@
SurfaceTextureManager::InitInstance(new BrowserSurfaceTextureManager);
}
+#if 0
+ // Screen orientation lock doesn't work on WebView yet. Skip setting the
+ // delegate to force all lock attempts to report failure to calling JS code.
{
TRACE_EVENT0("startup",
"BrowserMainLoop::Subsystem:ScreenOrientationProvider");
@@ -549,6 +552,7 @@
ScreenOrientationProvider::SetDelegate(screen_orientation_delegate_.get());
}
#endif
+#endif
if (parsed_command_line_.HasSwitch(switches::kMemoryMetrics)) {
TRACE_EVENT0("startup", "BrowserMainLoop::Subsystem:MemoryObserver");
