repo v2.14.4
git_config: hoist Windows ssh check earlier

The ssh master logic has never worked under Windows which is why this
code always returned False when running there (including cygwin).  But
the OS check was still done while holding the threading lock.  While
it might be a little slower than necessary, it still worked.

The switch from the threading module to the multiprocessing module
changed global behavior subtly under Windows and broke things: the
globals previously would stay valid, but now they get cleared.  So
the lock is reset to None in children workers.

We could tweak the logic to pass the lock through, but there isn't
much point when the rest of the code is still disabled in Windows.
So perform the platform check before we grab the lock.  This fixes
the crash, and probably speeds things up a few nanoseconds.

This shouldn't be a problem on Linux systems as the platform fork
will duplicate the existing process memory (including globals).

Bug: https://crbug.com/gerrit/14480
Change-Id: I1d1da82c6d7bd6b8cdc1f03f640a520ecd047063
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/305149
Reviewed-by: Raman Tenneti <rtenneti@google.com>
Tested-by: Mike Frysinger <vapier@google.com>
1 file changed
tree: 8187e3bba357e8c17a3041ccb842e4433fb7a13e
  1. .flake8
  2. .gitattributes
  3. .github/
  4. .gitignore
  5. .mailmap
  6. .project
  7. .pydevproject
  8. LICENSE
  9. MANIFEST.in
  10. README.md
  11. SUBMITTING_PATCHES.md
  12. color.py
  13. command.py
  14. completion.bash
  15. docs/
  16. editor.py
  17. error.py
  18. event_log.py
  19. git_command.py
  20. git_config.py
  21. git_refs.py
  22. git_ssh
  23. git_superproject.py
  24. git_trace2_event_log.py
  25. gitc_utils.py
  26. hooks.py
  27. hooks/
  28. main.py
  29. manifest_xml.py
  30. pager.py
  31. platform_utils.py
  32. platform_utils_win32.py
  33. progress.py
  34. project.py
  35. release/
  36. repo
  37. repo_trace.py
  38. requirements.json
  39. run_tests
  40. setup.py
  41. subcmds/
  42. tests/
  43. tox.ini
  44. wrapper.py
README.md

repo

Repo is a tool built on top of Git. Repo helps manage many Git repositories, does the uploads to revision control systems, and automates parts of the development workflow. Repo is not meant to replace Git, only to make it easier to work with Git. The repo command is an executable Python script that you can put anywhere in your path.

Contact

Please use the repo-discuss mailing list or issue tracker for questions.

You can file a new bug report under the “repo” component.

Please do not e-mail individual developers for support. They do not have the bandwidth for it, and often times questions have already been asked on repo-discuss or bugs posted to the issue tracker. So please search those sites first.

Install

Many distros include repo, so you might be able to install from there.

# Debian/Ubuntu.
$ sudo apt-get install repo

# Gentoo.
$ sudo emerge dev-vcs/repo

You can install it manually as well as it's a single script.

$ mkdir -p ~/.bin
$ PATH="${HOME}/.bin:${PATH}"
$ curl https://storage.googleapis.com/git-repo-downloads/repo > ~/.bin/repo
$ chmod a+rx ~/.bin/repo