cmd/compile: use inline tree index to identify call stack When building the name for closures, in order to make sure each closure has a unique name, we attach a hash of the inline call stack. We currently use a combination of function name, line number, and column number at each level to construct the hash. In some situations, this may not be able to uniquely identify the call stack: there could be multiple inline call sites at the same line of different files (we currently don't include the file name), and XPos.ColumnNumber can saturate. This could lead to duplicate symbol definitions. Instead of using name + line number + column number, switch to use the global inline tree index, which should uniquely identify the call site at each level. Fixes #79274. Change-Id: I69110a212d6b856283aae4c999258ae585be5977 Reviewed-on: https://go-review.googlesource.com/c/go/+/775624 Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com> Reviewed-by: David Chase <drchase@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 4.0 Attribution license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.