)]}' { "commit": "91fd14b82493e592730a3e459ef6610195b854c2", "tree": "2b77c9ed12b67fb250de7718f358a6ff2663adb0", "parents": [ "162b3610e62f2e55e4048f2f72273a58e152236e" ], "author": { "name": "Cherry Zhang", "email": "cherryyz@google.com", "time": "Wed Feb 27 12:34:20 2019 -0500" }, "committer": { "name": "Ian Lance Taylor", "email": "iant@golang.org", "time": "Fri Mar 01 18:39:38 2019 +0000" }, "message": "[release-branch.go1.12] runtime: scan defer closure in stack scan\n\nWith stack objects, when we scan the stack, it scans defers with\ntracebackdefers, but it seems to me that tracebackdefers doesn\u0027t\ninclude the func value itself, which could be a stack allocated\nclosure. Scan it explicitly.\n\nAlternatively, we can change tracebackdefers to include the func\nvalue, which in turn needs to change the type of stkframe.\n\nUpdates #30453.\nFixes #30470.\n\nChange-Id: I55a6e43264d6952ab2fa5c638bebb89fdc410e2b\nReviewed-on: https://go-review.googlesource.com/c/164118\nReviewed-by: Keith Randall \u003ckhr@golang.org\u003e\n(cherry picked from commit 4f4c2a79d4f952b96d58aec2926b4c894245071b)\nReviewed-on: https://go-review.googlesource.com/c/164629\nRun-TryBot: Cherry Zhang \u003ccherryyz@google.com\u003e\nTryBot-Result: Gobot Gobot \u003cgobot@golang.org\u003e\nReviewed-by: Ian Lance Taylor \u003ciant@golang.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "022cc8d7d76754ee0d0d64160826b87aa85e12a5", "old_mode": 33188, "old_path": "src/runtime/mgcmark.go", "new_id": "cc4e7d06d30e7ecc36af1a8dd61784fd0c30d2b2", "new_mode": 33188, "new_path": "src/runtime/mgcmark.go" }, { "type": "modify", "old_id": "f52381710dff622f89cddefbb65ca80ba9bc027a", "old_mode": 33188, "old_path": "src/runtime/stack_test.go", "new_id": "7bc63967bba074a7fdef175e7c64a07d86073e8e", "new_mode": 33188, "new_path": "src/runtime/stack_test.go" }, { "type": "modify", "old_id": "fdf08be7e91714c9bf3e858aa82ee091cd8e34f9", "old_mode": 33188, "old_path": "src/runtime/testdata/testprog/gc.go", "new_id": "ea6604f13214a79c0deb6afbadeaf0ab60dabe9a", "new_mode": 33188, "new_path": "src/runtime/testdata/testprog/gc.go" } ] }