blob: 6c916b7e2a78f0496b3a6e1d159a1b7a014a6d7a [file] [log] [blame]
/*
* Copyright 2003-2012 Dave Griffith, Bas Leijdekkers
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.siyeh.ig.threading;
import com.intellij.codeInspection.ProblemDescriptor;
import com.intellij.codeInspection.ui.MultipleCheckboxOptionsPanel;
import com.intellij.openapi.project.Project;
import com.intellij.psi.*;
import com.intellij.psi.codeStyle.CodeStyleManager;
import com.intellij.util.IncorrectOperationException;
import com.siyeh.InspectionGadgetsBundle;
import com.siyeh.ig.BaseInspection;
import com.siyeh.ig.BaseInspectionVisitor;
import com.siyeh.ig.InspectionGadgetsFix;
import org.jetbrains.annotations.NonNls;
import org.jetbrains.annotations.NotNull;
import javax.swing.*;
public class SynchronizedMethodInspection extends BaseInspection {
/**
* @noinspection PublicField
*/
public boolean m_includeNativeMethods = true;
@SuppressWarnings("PublicField")
public boolean ignoreSynchronizedSuperMethods = true;
@Override
@NotNull
public String getDisplayName() {
return InspectionGadgetsBundle.message(
"synchronized.method.display.name");
}
@Override
@NotNull
public String buildErrorString(Object... infos) {
final PsiMethod method = (PsiMethod)infos[0];
return InspectionGadgetsBundle.message(
"synchronized.method.problem.descriptor", method.getName());
}
@Override
protected InspectionGadgetsFix buildFix(Object... infos) {
final PsiMethod method = (PsiMethod)infos[0];
if (method.getBody() == null) {
return null;
}
return new SynchronizedMethodFix();
}
@Override
public BaseInspectionVisitor buildVisitor() {
return new SynchronizedMethodVisitor();
}
@Override
public JComponent createOptionsPanel() {
final MultipleCheckboxOptionsPanel panel = new MultipleCheckboxOptionsPanel(this);
panel.addCheckbox(InspectionGadgetsBundle.message("synchronized.method.include.option"), "m_includeNativeMethods");
panel.addCheckbox(InspectionGadgetsBundle.message("synchronized.method.ignore.synchronized.super.option"),
"ignoreSynchronizedSuperMethods");
return panel;
}
private static class SynchronizedMethodFix extends InspectionGadgetsFix {
@Override
@NotNull
public String getName() {
return InspectionGadgetsBundle.message(
"synchronized.method.move.quickfix");
}
@Override
@NotNull
public String getFamilyName() {
return getName();
}
@Override
public void doFix(Project project, ProblemDescriptor descriptor)
throws IncorrectOperationException {
final PsiElement nameElement = descriptor.getPsiElement();
final PsiModifierList modifierList = (PsiModifierList)nameElement.getParent();
assert modifierList != null;
final PsiMethod method = (PsiMethod)modifierList.getParent();
modifierList.setModifierProperty(PsiModifier.SYNCHRONIZED, false);
assert method != null;
final PsiCodeBlock body = method.getBody();
if (body == null) {
return;
}
final String text = body.getText();
@NonNls final String replacementText;
if (method.hasModifierProperty(PsiModifier.STATIC)) {
final PsiClass containingClass = method.getContainingClass();
assert containingClass != null;
final String className = containingClass.getName();
replacementText = "{ synchronized(" + className + ".class){" + text.substring(1) + '}';
}
else {
replacementText = "{ synchronized(this){" + text.substring(1) + '}';
}
final PsiElementFactory elementFactory = JavaPsiFacade.getElementFactory(project);
final PsiCodeBlock block = elementFactory.createCodeBlockFromText(replacementText, null);
body.replace(block);
final CodeStyleManager codeStyleManager = CodeStyleManager.getInstance(project);
codeStyleManager.reformat(method);
}
}
private class SynchronizedMethodVisitor extends BaseInspectionVisitor {
@Override
public void visitMethod(@NotNull PsiMethod method) {
if (!method.hasModifierProperty(PsiModifier.SYNCHRONIZED)) {
return;
}
if (!m_includeNativeMethods && method.hasModifierProperty(PsiModifier.NATIVE)) {
return;
}
if (ignoreSynchronizedSuperMethods) {
final PsiMethod[] superMethods = method.findSuperMethods();
for (final PsiMethod superMethod : superMethods) {
if (superMethod.hasModifierProperty(PsiModifier.SYNCHRONIZED)) {
return;
}
}
}
registerModifierError(PsiModifier.SYNCHRONIZED, method, method);
}
}
}