blob: 65a352df62e102c15f69a0d07f919c49bf3853c4 [file] [log] [blame]
/*
* Copyright 2003-2008 Dave Griffith, Bas Leijdekkers
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.siyeh.ig.performance;
import com.intellij.psi.*;
import com.intellij.psi.util.PsiUtil;
import com.siyeh.InspectionGadgetsBundle;
import com.siyeh.ig.BaseInspection;
import com.siyeh.ig.BaseInspectionVisitor;
import com.siyeh.ig.InspectionGadgetsFix;
import com.siyeh.ig.fixes.ChangeModifierFix;
import com.siyeh.ig.psiutils.ClassUtils;
import com.siyeh.ig.psiutils.SideEffectChecker;
import org.jetbrains.annotations.NotNull;
public class FieldMayBeStaticInspection extends BaseInspection {
@Override
@NotNull
public String getDisplayName() {
return InspectionGadgetsBundle.message(
"field.may.be.static.display.name");
}
@Override
public BaseInspectionVisitor buildVisitor() {
return new FieldMayBeStaticVisitor();
}
@Override
@NotNull
protected String buildErrorString(Object... infos) {
return InspectionGadgetsBundle.message(
"field.may.be.static.problem.descriptor");
}
@Override
public InspectionGadgetsFix buildFix(Object... infos) {
return new ChangeModifierFix(PsiModifier.STATIC);
}
private static class FieldMayBeStaticVisitor extends BaseInspectionVisitor {
@Override
public void visitField(@NotNull PsiField field) {
if (field.hasModifierProperty(PsiModifier.STATIC)) {
return;
}
if (!field.hasModifierProperty(PsiModifier.FINAL)) {
return;
}
final PsiExpression initializer = field.getInitializer();
if (initializer == null) {
return;
}
if (SideEffectChecker.mayHaveSideEffects(initializer)) {
return;
}
if (!canBeStatic(initializer)) {
return;
}
final PsiType type = field.getType();
if (!ClassUtils.isImmutable(type)) {
return;
}
final PsiClass containingClass = field.getContainingClass();
if (containingClass != null
&& !containingClass.hasModifierProperty(PsiModifier.STATIC)
&& containingClass.getContainingClass() != null
&& !PsiUtil.isCompileTimeConstant(field)) {
// inner class cannot have static declarations
return;
}
registerFieldError(field);
}
private static boolean canBeStatic(PsiExpression initializer) {
final CanBeStaticVisitor canBeStaticVisitor =
new CanBeStaticVisitor();
initializer.accept(canBeStaticVisitor);
return canBeStaticVisitor.canBeStatic();
}
}
}