Google Git
Sign in
android / platform / system / tools / aidl / 981fc59d
commit981fc59d7836c7e8e4530beef5ab360ac86a4daf[log] [tgz]
authorJooyung Han <jooyung@google.com>Sat Nov 06 20:24:45 2021 +0900
committerJooyung Han <jooyung@google.com>Mon Nov 08 13:53:27 2021 +0900
treeda37453ad987a399847d2d163fd68e50d57b3013
parentfa41b533a960a409f8c20d82b4a0fbcac94bbaf3 [diff]
fix `byte[]` with negative values (C++/NDK)

In C++/NDK backends, byte[] is mapped to vector<uint8_t> while byte
alone is mapped to int8_t. When byte[]'s default value has negative
elements, resulting code won't compile without extra casting.

For example, while `byte[] a = {-1}` is perfectly valid, the C++ output
was `vector<uint8_t> a = {-1}`, which is an error.

Now, those negative values are casted to uint8_t when necessary. This is
fine because of how C++ casting(static_cast) works.

As a side-effect of this fix, C++ backend now doesn't emit extra value
casting (e.g. previously, `int32_t n = int32_t(1);`, but now it's just
`int32_t n = 1;`).

Bug: 204116012
Test: m (no regression)
Test: aidl_unittests
Merged-In: I9bbe9b4e6109502f182fc40bf1dc721ea9738971
Change-Id: I9bbe9b4e6109502f182fc40bf1dc721ea9738971
(cherry picked from commit a96a1090478a3fec8f4db9a2b423c514b4a40b3c)
21 files changed
tree: da37453ad987a399847d2d163fd68e50d57b3013
  1. aidl_api/
  2. build/
  3. metadata/
  4. permission/
  5. tests/
  6. trace/
  7. .clang-format ⇨ ../../../build/soong/scripts/system-clang-format-2
  8. rustfmt.toml ⇨ ../../../build/soong/scripts/rustfmt.toml
  9. aidl-format.sh
  10. aidl.cpp
  11. aidl.h
  12. aidl_checkapi.cpp
  13. aidl_checkapi.h
  14. aidl_const_expressions.cpp
  15. aidl_dumpapi.cpp
  16. aidl_dumpapi.h
  17. aidl_language.cpp
  18. aidl_language.h
  19. aidl_language_l.ll
  20. aidl_language_y.yy
  21. aidl_to_cpp.cpp
  22. aidl_to_cpp.h
  23. aidl_to_cpp_common.cpp
  24. aidl_to_cpp_common.h
  25. aidl_to_java.cpp
  26. aidl_to_java.h
  27. aidl_to_ndk.cpp
  28. aidl_to_ndk.h
  29. aidl_to_rust.cpp
  30. aidl_to_rust.h
  31. aidl_typenames.cpp
  32. aidl_typenames.h
  33. aidl_unittest.cpp
  34. Android.bp
  35. ast_java.cpp
  36. ast_java.h
  37. ast_java_unittest.cpp
  38. code_writer.cpp
  39. code_writer.h
  40. code_writer_unittest.cpp
  41. comments.cpp
  42. comments.h
  43. diagnostics.cpp
  44. diagnostics.h
  45. diagnostics.inc
  46. diagnostics_unittest.cpp
  47. generate_aidl_mappings.cpp
  48. generate_aidl_mappings.h
  49. generate_cpp.cpp
  50. generate_cpp.h
  51. generate_cpp_unittest.cpp
  52. generate_java.cpp
  53. generate_java.h
  54. generate_java_binder.cpp
  55. generate_ndk.cpp
  56. generate_ndk.h
  57. generate_rust.cpp
  58. generate_rust.h
  59. hiddenapi-greylist
  60. import_resolver.cpp
  61. import_resolver.h
  62. io_delegate.cpp
  63. io_delegate.h
  64. io_delegate_unittest.cpp
  65. location.cpp
  66. location.h
  67. logging.cpp
  68. logging.h
  69. main.cpp
  70. NOTICE
  71. options.cpp
  72. options.h
  73. options_unittest.cpp
  74. os.h
  75. OWNERS
  76. parser.cpp
  77. parser.h
  78. preprocess.cpp
  79. preprocess.h
  80. PREUPLOAD.cfg
  81. README.md
  82. run_integration_tests.sh
  83. TEST_MAPPING
README.md

Documentation for this project is currently maintained here:

https://source.android.com/devices/architecture/aidl/overview