Google Git
Sign in
android / platform / system / tools / aidl / 5679952c38925a54b75b087068887002e57f3174
commit5679952c38925a54b75b087068887002e57f3174[log] [tgz]
authorChristopher Wiley <wiley@google.com>Sat Oct 31 10:17:04 2015 -0700
committerChristopher Wiley <wiley@google.com>Sat Oct 31 10:19:44 2015 -0700
tree847008321055509d2af9f30f0af7080ae5361eda
parent09af469476ea6d187b52f22113d3b168a887100c [diff]
Don't call virtual methods in TypeNamespace constructors

While probably safe in this particular context because of this specific
class structure, it is bad practice to call virtual methods in constructors.

Bug: None
Test: unittests continue to pass

Change-Id: I3c9a435efd89a2c2bd7ce576aed585b8ab766bda
11 files changed
tree: 847008321055509d2af9f30f0af7080ae5361eda
  1. tests/
  2. aidl.cpp
  3. aidl.h
  4. aidl_language.cpp
  5. aidl_language.h
  6. aidl_language_l.l
  7. aidl_language_y.y
  8. aidl_unittest.cpp
  9. Android.mk
  10. ast_cpp.cpp
  11. ast_cpp.h
  12. ast_cpp_unittest.cpp
  13. ast_java.cpp
  14. ast_java.h
  15. ast_java_unittest.cpp
  16. code_writer.cpp
  17. code_writer.h
  18. generate_cpp.cpp
  19. generate_cpp.h
  20. generate_cpp_unittest.cpp
  21. generate_java.cpp
  22. generate_java.h
  23. generate_java_binder.cpp
  24. import_resolver.cpp
  25. import_resolver.h
  26. io_delegate.cpp
  27. io_delegate.h
  28. logging.h
  29. main_cpp.cpp
  30. main_java.cpp
  31. MODULE_LICENSE_APACHE2
  32. NOTICE
  33. options.cpp
  34. options.h
  35. options_unittest.cpp
  36. os.h
  37. type_cpp.cpp
  38. type_cpp.h
  39. type_cpp_unittest.cpp
  40. type_java.cpp
  41. type_java.h
  42. type_java_unittest.cpp
  43. type_namespace.cpp
  44. type_namespace.h