Google Git
Sign in
android / platform / system / tools / aidl / 2834f00b94082497dadde73ac37dd531455dc636
commit2834f00b94082497dadde73ac37dd531455dc636[log] [tgz]
authorJooyung Han <jooyung@google.com>Mon Sep 27 11:48:15 2021 +0900
committerTreehugger Robot <treehugger-gerrit@google.com>Mon Sep 27 04:31:13 2021 +0000
tree241154dfea3d6d5392782097d1c4ed9c499e15e1
parent223274e37f27d541858a9b72235e6e5f7e62e1da [diff]
Fix use-after-free on annotation parse error

There's a mistake in 442cacfc96f69adce7b55bd28cf07a75fbcb4b65 and
55db811ed457f4e5df791a0c9e3ea545b81b687f.
It missed to set $$ when AidlAnnotation::Parse fails. When $$ is not
set, it points to the first component of the rule ($1) which is deleted.

Bug: 201125993, 201125843
Test: aidl_unittests
Change-Id: Ib5e78b3fcfb4972d31c05065ef5c946a24a8e77c
2 files changed
tree: 241154dfea3d6d5392782097d1c4ed9c499e15e1
  1. aidl_api/
  2. build/
  3. metadata/
  4. permission/
  5. tests/
  6. trace/
  7. .clang-format ⇨ ../../../build/soong/scripts/system-clang-format-2
  8. aidl-format.sh
  9. aidl.cpp
  10. aidl.h
  11. aidl_checkapi.cpp
  12. aidl_checkapi.h
  13. aidl_const_expressions.cpp
  14. aidl_dumpapi.cpp
  15. aidl_dumpapi.h
  16. aidl_language.cpp
  17. aidl_language.h
  18. aidl_language_l.ll
  19. aidl_language_y.yy
  20. aidl_to_cpp.cpp
  21. aidl_to_cpp.h
  22. aidl_to_cpp_common.cpp
  23. aidl_to_cpp_common.h
  24. aidl_to_java.cpp
  25. aidl_to_java.h
  26. aidl_to_ndk.cpp
  27. aidl_to_ndk.h
  28. aidl_to_rust.cpp
  29. aidl_to_rust.h
  30. aidl_typenames.cpp
  31. aidl_typenames.h
  32. aidl_unittest.cpp
  33. Android.bp
  34. ast_cpp.cpp
  35. ast_cpp.h
  36. ast_cpp_unittest.cpp
  37. ast_java.cpp
  38. ast_java.h
  39. ast_java_unittest.cpp
  40. code_writer.cpp
  41. code_writer.h
  42. code_writer_unittest.cpp
  43. comments.cpp
  44. comments.h
  45. diagnostics.cpp
  46. diagnostics.h
  47. diagnostics.inc
  48. diagnostics_unittest.cpp
  49. generate_aidl_mappings.cpp
  50. generate_aidl_mappings.h
  51. generate_cpp.cpp
  52. generate_cpp.h
  53. generate_cpp_unittest.cpp
  54. generate_java.cpp
  55. generate_java.h
  56. generate_java_binder.cpp
  57. generate_ndk.cpp
  58. generate_ndk.h
  59. generate_rust.cpp
  60. generate_rust.h
  61. hiddenapi-greylist
  62. import_resolver.cpp
  63. import_resolver.h
  64. io_delegate.cpp
  65. io_delegate.h
  66. io_delegate_unittest.cpp
  67. location.cpp
  68. location.h
  69. logging.cpp
  70. logging.h
  71. main.cpp
  72. NOTICE
  73. options.cpp
  74. options.h
  75. options_unittest.cpp
  76. os.h
  77. OWNERS
  78. parser.cpp
  79. parser.h
  80. preprocess.cpp
  81. preprocess.h
  82. PREUPLOAD.cfg
  83. README.md
  84. run_integration_tests.sh
  85. TEST_MAPPING
README.md

Documentation for this project is currently maintained here:

https://source.android.com/devices/architecture/aidl/overview