commit 2b45e03f1314b687d767926dca8c6ec91ac36349
author dongziqi1 <dongziqi1@xiaomi.com> Thu Sep 21 09:54:56 2023 +0800
committer ZiQi Dong <dongziqi1@xiaomi.corp-partner.google.com> Mon Sep 25 06:43:39 2023 +0000
tree 61f9a4e95759224813610bb6fd649b9992badb85
parent 2ef5f2dee6dc4499aa3a7441767e63e2762d835d

Fix netd fd leak when netlink sock connect fail

Bug: 301335710

When the netlink sock connection fails, an error message
is returned and the open sock needs to be closed

Change-Id: Ie56243320f664e326b9965eca227c7bb4a6a41b3
Signed-off-by: dongziqi <dongziqi1@xiaomi.corp-partner.google.com>

server/NetlinkCommands.cpp

diff --git a/server/NetlinkCommands.cpp b/server/NetlinkCommands.cpp
index 7cb08d8..49f54f5 100644
--- a/server/NetlinkCommands.cpp
+++ b/server/NetlinkCommands.cpp
@@ -38,6 +38,7 @@
     }
     if (connect(sock, reinterpret_cast<const sockaddr*>(&KERNEL_NLADDR),
                 sizeof(KERNEL_NLADDR)) == -1) {
+        close(sock);
         return -errno;
     }
     return sock;