Snap for 7269201 from e68bfe9a73fad724445c65c289027821f982f9a2 to rvc-qpr3-release
Change-Id: I4121184ff7bb28e9ee2d7e029d6d875833c46504
diff --git a/lmkd.cpp b/lmkd.cpp
index b065bbf..c646479 100644
--- a/lmkd.cpp
+++ b/lmkd.cpp
@@ -203,6 +203,7 @@
static int psi_complete_stall_ms;
static int thrashing_limit_pct;
static int thrashing_limit_decay_pct;
+static int thrashing_critical_pct;
static bool use_psi_monitors = false;
static int kpoll_fd;
static struct psi_threshold psi_thresholds[VMPRESS_LEVEL_COUNT] = {
@@ -2153,12 +2154,21 @@
int i;
int killed_size = 0;
bool lmk_state_change_start = false;
+ bool choose_heaviest_task = kill_heaviest_task;
for (i = OOM_SCORE_ADJ_MAX; i >= min_score_adj; i--) {
struct proc *procp;
+ if (!choose_heaviest_task && i <= PERCEPTIBLE_APP_ADJ) {
+ /*
+ * If we have to choose a perceptible process, choose the heaviest one to
+ * hopefully minimize the number of victims.
+ */
+ choose_heaviest_task = true;
+ }
+
while (true) {
- procp = kill_heaviest_task ?
+ procp = choose_heaviest_task ?
proc_get_heaviest(i) : proc_adj_lru(i);
if (!procp)
@@ -2479,8 +2489,8 @@
snprintf(kill_desc, sizeof(kill_desc), "device is low on swap (%" PRId64
"kB < %" PRId64 "kB) and thrashing (%" PRId64 "%%)",
mi.field.free_swap * page_k, swap_low_threshold * page_k, thrashing);
- /* Do not kill perceptible apps unless below min watermark */
- if (wmark > WMARK_MIN) {
+ /* Do not kill perceptible apps unless below min watermark or heavily thrashing */
+ if (wmark > WMARK_MIN && thrashing < thrashing_critical_pct) {
min_score_adj = PERCEPTIBLE_APP_ADJ + 1;
}
} else if (swap_is_low && wmark < WMARK_HIGH) {
@@ -2489,8 +2499,8 @@
snprintf(kill_desc, sizeof(kill_desc), "%s watermark is breached and swap is low (%"
PRId64 "kB < %" PRId64 "kB)", wmark > WMARK_LOW ? "min" : "low",
mi.field.free_swap * page_k, swap_low_threshold * page_k);
- /* Do not kill perceptible apps unless below min watermark */
- if (wmark > WMARK_MIN) {
+ /* Do not kill perceptible apps unless below min watermark or heavily thrashing */
+ if (wmark > WMARK_MIN && thrashing < thrashing_critical_pct) {
min_score_adj = PERCEPTIBLE_APP_ADJ + 1;
}
} else if (wmark < WMARK_HIGH && thrashing > thrashing_limit) {
@@ -2499,16 +2509,20 @@
snprintf(kill_desc, sizeof(kill_desc), "%s watermark is breached and thrashing (%"
PRId64 "%%)", wmark > WMARK_LOW ? "min" : "low", thrashing);
cut_thrashing_limit = true;
- /* Do not kill perceptible apps because of thrashing */
- min_score_adj = PERCEPTIBLE_APP_ADJ + 1;
+ /* Do not kill perceptible apps unless thrashing at critical levels */
+ if (thrashing < thrashing_critical_pct) {
+ min_score_adj = PERCEPTIBLE_APP_ADJ + 1;
+ }
} else if (reclaim == DIRECT_RECLAIM && thrashing > thrashing_limit) {
/* Page cache is thrashing while in direct reclaim (mostly happens on lowram devices) */
kill_reason = DIRECT_RECL_AND_THRASHING;
snprintf(kill_desc, sizeof(kill_desc), "device is in direct reclaim and thrashing (%"
PRId64 "%%)", thrashing);
cut_thrashing_limit = true;
- /* Do not kill perceptible apps because of thrashing */
- min_score_adj = PERCEPTIBLE_APP_ADJ + 1;
+ /* Do not kill perceptible apps unless thrashing at critical levels */
+ if (thrashing < thrashing_critical_pct) {
+ min_score_adj = PERCEPTIBLE_APP_ADJ + 1;
+ }
}
/* Kill a process if necessary */
@@ -3306,6 +3320,8 @@
low_ram_device ? DEF_THRASHING_LOWRAM : DEF_THRASHING));
thrashing_limit_decay_pct = clamp(0, 100, property_get_int32("ro.lmk.thrashing_limit_decay",
low_ram_device ? DEF_THRASHING_DECAY_LOWRAM : DEF_THRASHING_DECAY));
+ thrashing_critical_pct = max(0, property_get_int32("ro.lmk.thrashing_limit_critical",
+ thrashing_limit_pct * 2));
}
int main(int argc, char **argv) {
