Google Git
Sign in
android / platform / system / libvintf / 12e23c23ab0db7141b7e42c185fc599720398e51
commit12e23c23ab0db7141b7e42c185fc599720398e51[log] [tgz]
authorYifan Hong <elsk@google.com>Mon Nov 05 14:53:30 2018 -0800
committerYifan Hong <elsk@google.com>Wed Nov 07 13:03:22 2018 -0800
treeab0f95f9966040cc88a90d3dbda09f4e76c68605
parent856b7bd42c5dc8922d79a64af432ecc929bd740c [diff]
VintfObject::checkCompatibility loads XMLs from the device correctly.

Previously:
- When getFrameworkCompatibilityMatrix() is called, the Target FCM version
is always loaded from the device, but not from the update package.
This can potentially break a vendor-only OTA that updates the Target FCM
version, because the FCM from device isn't loaded with the correct Target FCM
version.

In this CL, I refactored checkCompatibility logic so that the
VintfObjectAfterUpdate object applies the updated VINTF metadata as an
overlay on top of the original VintfObject.

Test: vintf_object_test
Test: manual OTA
Bug: 118635062
Change-Id: Ib04ba09d4a07c8e5d1e4ac64194e956b37e1f76f
5 files changed
tree: ab0f95f9966040cc88a90d3dbda09f4e76c68605
  1. analyze_matrix/
  2. include/
  3. include-test/
  4. test/
  5. .clang-format
  6. Android.bp
  7. Android.mk
  8. assemble_vintf_main.cpp
  9. AssembleVintf.cpp
  10. check_vintf.cpp
  11. CompatibilityMatrix.cpp
  12. FileSystem.cpp
  13. HalInterface.cpp
  14. HalManifest.cpp
  15. KernelConfigParser.cpp
  16. KernelConfigTypedValue.cpp
  17. main.cpp
  18. ManifestHal.cpp
  19. ManifestInstance.cpp
  20. MatrixHal.cpp
  21. MatrixInstance.cpp
  22. MatrixKernel.cpp
  23. MODULE_LICENSE_APACHE2
  24. NOTICE
  25. OWNERS
  26. parse_string.cpp
  27. parse_xml.cpp
  28. PREUPLOAD.cfg
  29. PropertyFetcher.cpp
  30. Regex.cpp
  31. RuntimeInfo-host.cpp
  32. RuntimeInfo-target.cpp
  33. RuntimeInfo.cpp
  34. SystemSdk.cpp
  35. TransportArch.cpp
  36. utils.h
  37. VintfObject.cpp
  38. VintfObjectAfterUpdate.h
  39. VintfObjectRecovery.cpp
  40. XmlFile.cpp