Google Git
Sign in
android / platform / system / libvintf / 5a51ea59ce6e039808388d278c04760c5f053999 / . / test / LibVintfTest.cpp
blob: b129d8032d311987327504a325e3f3fffb33b6ff [file] [log] [blame]
/*
* Copyright (C) 2017 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#define LOG_TAG "LibVintfTest"
#include <algorithm>
#include <functional>
#include <vintf/CompatibilityMatrix.h>
#include <vintf/KernelConfigParser.h>
#include <vintf/VintfObject.h>
#include <vintf/parse_string.h>
#include <vintf/parse_xml.h>
#include <android-base/logging.h>
#include <android-base/parseint.h>
#include <android-base/strings.h>
#include <gtest/gtest.h>
namespace android {
namespace vintf {
extern XmlConverter<Version>& gVersionConverter;
extern XmlConverter<ManifestHal>& gManifestHalConverter;
extern XmlConverter<MatrixHal>& gMatrixHalConverter;
extern XmlConverter<KernelConfigTypedValue>& gKernelConfigTypedValueConverter;
extern XmlConverter<KernelInfo>& gKernelInfoConverter;
extern XmlConverter<HalManifest>& gHalManifestConverter;
extern XmlConverter<CompatibilityMatrix>& gCompatibilityMatrixConverter;
static bool In(const std::string& sub, const std::string& str) {
return str.find(sub) != std::string::npos;
}
#define EXPECT_IN(sub, str) EXPECT_TRUE(In((sub), (str))) << (str);
#ifndef LIBVINTF_TARGET
#define EXPECT_CONTAINS(str, sub) EXPECT_IN(sub, str);
#endif
struct LibVintfTest : public ::testing::Test {
public:
virtual void SetUp() override {
}
virtual void TearDown() override {
}
bool add(CompatibilityMatrix &cm, MatrixHal &&hal) {
return cm.add(std::move(hal));
}
bool add(CompatibilityMatrix &cm, MatrixKernel &&kernel) {
std::string error;
bool success = cm.addKernel(std::move(kernel), &error);
EXPECT_EQ(success, error == "") << "success: " << success << ", error: " << error;
return success;
}
bool add(HalManifest &vm, ManifestHal &&hal) {
return vm.add(std::move(hal));
}
void addXmlFile(CompatibilityMatrix& cm, std::string name, VersionRange range) {
MatrixXmlFile f;
f.mName = name;
f.mVersionRange = range;
f.mFormat = XmlSchemaFormat::DTD;
f.mOptional = true;
cm.addXmlFile(std::move(f));
}
void set(CompatibilityMatrix &cm, Sepolicy &&sepolicy) {
cm.framework.mSepolicy = sepolicy;
}
void set(CompatibilityMatrix &cm, SchemaType type) {
cm.mType = type;
}
void set(CompatibilityMatrix &cm, VndkVersionRange &&range, std::set<std::string> &&libs) {
cm.device.mVndk.mVersionRange = range;
cm.device.mVndk.mLibraries = libs;
}
void setAvb(RuntimeInfo &ki, Version vbmeta, Version boot) {
ki.mBootVbmetaAvbVersion = vbmeta;
ki.mBootAvbVersion = boot;
}
void setAvb(CompatibilityMatrix &cm, Version &&avbVersion) {
cm.framework.mAvbMetaVersion = avbVersion;
}
Version getAvb(CompatibilityMatrix &cm) {
return cm.framework.mAvbMetaVersion;
}
const ManifestHal *getAnyHal(HalManifest &vm, const std::string &name) {
return vm.getAnyHal(name);
}
MatrixHal *getAnyHal(CompatibilityMatrix &cm, const std::string &name) {
return cm.getAnyHal(name);
}
ConstMultiMapValueIterable<std::string, ManifestHal> getHals(const HalManifest& vm) {
return vm.getHals();
}
std::vector<const ManifestHal*> getHals(const HalManifest& vm, const std::string& name) {
return vm.getHals(name);
}
std::vector<const MatrixHal*> getHals(const CompatibilityMatrix& cm, const std::string& name) {
return cm.getHals(name);
}
bool isValid(const ManifestHal &mh) {
return mh.isValid();
}
std::vector<MatrixKernel>& getKernels(CompatibilityMatrix& cm) { return cm.framework.mKernels; }
bool addAllHalsAsOptional(CompatibilityMatrix* cm1, CompatibilityMatrix* cm2, std::string* e) {
return cm1->addAllHalsAsOptional(cm2, e);
}
bool addAllXmlFilesAsOptional(CompatibilityMatrix* cm1, CompatibilityMatrix* cm2,
std::string* e) {
return cm1->addAllXmlFilesAsOptional(cm2, e);
}
std::set<std::string> checkUnusedHals(const HalManifest& m, const CompatibilityMatrix& cm) {
return m.checkUnusedHals(cm);
}
std::map<std::string, HalInterface> testHalInterfaces() {
HalInterface intf("IFoo", {"default"});
std::map<std::string, HalInterface> map;
map[intf.name()] = intf;
return map;
}
HalManifest testDeviceManifest() {
HalManifest vm;
vm.mType = SchemaType::DEVICE;
vm.device.mSepolicyVersion = {25, 0};
vm.add(ManifestHal{HalFormat::HIDL,
"android.hardware.camera",
{Version(2, 0)},
{Transport::HWBINDER, Arch::ARCH_EMPTY},
{{"ICamera", {"ICamera", {"legacy/0", "default"}}},
{"IBetterCamera", {"IBetterCamera", {"camera"}}}}});
vm.add(ManifestHal{HalFormat::HIDL,
"android.hardware.nfc",
{Version(1, 0)},
{Transport::PASSTHROUGH, Arch::ARCH_32_64},
{{"INfc", {"INfc", {"default"}}}}});
return vm;
}
HalManifest testDeviceManifestWithXmlFile() {
HalManifest vm = testDeviceManifest();
ManifestXmlFile xmlFile;
xmlFile.mName = "media_profile";
xmlFile.mVersion = {1, 0};
vm.addXmlFile(std::move(xmlFile));
return vm;
}
HalManifest testFrameworkManfiest() {
HalManifest vm;
vm.mType = SchemaType::FRAMEWORK;
vm.add(ManifestHal{HalFormat::HIDL,
"android.hidl.manager",
{Version(1, 0)},
{Transport::HWBINDER, Arch::ARCH_EMPTY},
{
{"IServiceManager", {"IServiceManager", {"default"}}},
}});
Vndk vndk2505;
vndk2505.mVersionRange = {25, 0, 5};
vndk2505.mLibraries = { "libjpeg.so", "libbase.so" };
Vndk vndk2513;
vndk2513.mVersionRange = {25, 1, 3};
vndk2513.mLibraries = { "libjpeg.so", "libbase.so", "libtinyxml2.so" };
vm.framework.mVndks = { std::move(vndk2505), std::move(vndk2513) };
return vm;
}
RuntimeInfo testRuntimeInfo() {
RuntimeInfo info;
info.mOsName = "Linux";
info.mNodeName = "localhost";
info.mOsRelease = "3.18.31-g936f9a479d0f";
info.mOsVersion = "#4 SMP PREEMPT Wed Feb 1 18:10:52 PST 2017";
info.mHardwareId = "aarch64";
info.mKernelSepolicyVersion = 30;
info.mKernel = testKernelInfo();
setAvb(info, {2, 1}, {2, 1});
return info;
}
KernelInfo testKernelInfo() {
KernelInfo info;
info.mVersion = {3, 18, 31};
info.mConfigs = {{"CONFIG_64BIT", "y"},
{"CONFIG_ANDROID_BINDER_DEVICES", "\"binder,hwbinder\""},
{"CONFIG_ARCH_MMAP_RND_BITS", "24"},
{"CONFIG_BUILD_ARM64_APPENDED_DTB_IMAGE_NAMES", "\"\""},
{"CONFIG_ILLEGAL_POINTER_VALUE", "0xdead000000000000"}};
return info;
}
};
TEST_F(LibVintfTest, ArchOperatorOr) {
Arch a = Arch::ARCH_EMPTY;
a |= Arch::ARCH_32;
EXPECT_EQ(Arch::ARCH_32, a);
a |= Arch::ARCH_64;
EXPECT_EQ(Arch::ARCH_32_64, a);
a = Arch::ARCH_EMPTY;
a |= Arch::ARCH_64;
EXPECT_EQ(Arch::ARCH_64, a);
}
TEST_F(LibVintfTest, Stringify) {
HalManifest vm = testDeviceManifest();
EXPECT_EQ(dump(vm), "hidl/android.hardware.camera/hwbinder/2.0:"
"hidl/android.hardware.nfc/passthrough32+64/1.0");
EXPECT_EQ(to_string(HalFormat::HIDL), "hidl");
EXPECT_EQ(to_string(HalFormat::NATIVE), "native");
VersionRange v(1, 2, 3);
EXPECT_EQ(to_string(v), "1.2-3");
VersionRange v2;
EXPECT_TRUE(parse("1.2-3", &v2));
EXPECT_EQ(v, v2);
}
TEST_F(LibVintfTest, GetTransport) {
HalManifest vm = testDeviceManifest();
EXPECT_EQ(Transport::HWBINDER, vm.getTransport("android.hardware.camera",
{2, 0}, "ICamera", "default"));
}
TEST_F(LibVintfTest, FutureManifestCompatible) {
HalManifest expectedManifest;
expectedManifest.add(ManifestHal{HalFormat::HIDL,
"android.hardware.foo",
{Version(1, 0)},
{Transport::HWBINDER, Arch::ARCH_EMPTY},
{
{"IFoo", {"IFoo", {"default"}}},
}});
std::string manifestXml =
"<manifest version=\"1.0\" type=\"device\" might_add=\"true\">\n"
" <hal format=\"hidl\" attribuet_might_be_added=\"value\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <version>1.0</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
" <tag_might_be_added/>\n"
"</manifest>\n";
HalManifest manifest;
EXPECT_TRUE(gHalManifestConverter(&manifest, manifestXml));
EXPECT_EQ(expectedManifest, manifest);
}
TEST_F(LibVintfTest, HalManifestConverter) {
HalManifest vm = testDeviceManifest();
std::string xml =
gHalManifestConverter(vm, SerializeFlags::NO_TAGS.enableHals().enableSepolicy());
EXPECT_EQ(xml,
"<manifest version=\"1.0\" type=\"device\">\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.camera</name>\n"
" <transport>hwbinder</transport>\n"
" <version>2.0</version>\n"
" <interface>\n"
" <name>IBetterCamera</name>\n"
" <instance>camera</instance>\n"
" </interface>\n"
" <interface>\n"
" <name>ICamera</name>\n"
" <instance>default</instance>\n"
" <instance>legacy/0</instance>\n"
" </interface>\n"
" </hal>\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.nfc</name>\n"
" <transport arch=\"32+64\">passthrough</transport>\n"
" <version>1.0</version>\n"
" <interface>\n"
" <name>INfc</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
" <sepolicy>\n"
" <version>25.0</version>\n"
" </sepolicy>\n"
"</manifest>\n");
HalManifest vm2;
EXPECT_TRUE(gHalManifestConverter(&vm2, xml));
EXPECT_EQ(vm, vm2);
}
TEST_F(LibVintfTest, HalManifestConverterFramework) {
HalManifest vm = testFrameworkManfiest();
std::string xml = gHalManifestConverter(vm, SerializeFlags::NO_TAGS.enableHals().enableVndk());
EXPECT_EQ(xml,
"<manifest version=\"1.0\" type=\"framework\">\n"
" <hal format=\"hidl\">\n"
" <name>android.hidl.manager</name>\n"
" <transport>hwbinder</transport>\n"
" <version>1.0</version>\n"
" <interface>\n"
" <name>IServiceManager</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
" <vndk>\n"
" <version>25.0.5</version>\n"
" <library>libbase.so</library>\n"
" <library>libjpeg.so</library>\n"
" </vndk>\n"
" <vndk>\n"
" <version>25.1.3</version>\n"
" <library>libbase.so</library>\n"
" <library>libjpeg.so</library>\n"
" <library>libtinyxml2.so</library>\n"
" </vndk>\n"
"</manifest>\n");
HalManifest vm2;
EXPECT_TRUE(gHalManifestConverter(&vm2, xml));
EXPECT_EQ(vm, vm2);
}
TEST_F(LibVintfTest, HalManifestOptional) {
HalManifest vm;
EXPECT_TRUE(gHalManifestConverter(&vm,
"<manifest version=\"1.0\" type=\"device\"></manifest>"));
EXPECT_TRUE(gHalManifestConverter(&vm,
"<manifest version=\"1.0\" type=\"device\">"
" <hal>"
" <name>android.hidl.manager</name>"
" <transport>hwbinder</transport>"
" <version>1.0</version>"
" </hal>"
"</manifest>"));
EXPECT_FALSE(gHalManifestConverter(&vm,
"<manifest version=\"1.0\" type=\"device\">"
" <hal>"
" <name>android.hidl.manager</name>"
" <version>1.0</version>"
" </hal>"
"</manifest>"));
}
TEST_F(LibVintfTest, HalManifestNative) {
HalManifest vm;
EXPECT_TRUE(gHalManifestConverter(&vm,
"<manifest version=\"1.0\" type=\"device\">"
" <hal format=\"native\">"
" <name>foo</name>"
" <version>1.0</version>"
" </hal>"
"</manifest>"))
<< gHalManifestConverter.lastError();
EXPECT_FALSE(gHalManifestConverter(&vm,
"<manifest version=\"1.0\" type=\"device\">"
" <hal format=\"native\">"
" <name>foo</name>"
" <version>1.0</version>"
" <transport>hwbinder</transport>"
" </hal>"
"</manifest>"));
EXPECT_TRUE(gHalManifestConverter.lastError().find(
"Native HAL 'foo' should not have <transport> defined") != std::string::npos);
}
TEST_F(LibVintfTest, HalManifestDuplicate) {
HalManifest vm;
EXPECT_FALSE(gHalManifestConverter(&vm,
"<manifest version=\"1.0\" type=\"device\">"
" <hal>"
" <name>android.hidl.manager</name>"
" <transport>hwbinder</transport>"
" <version>1.0</version>"
" <version>1.1</version>"
" </hal>"
"</manifest>"))
<< "Should not allow duplicated major version in <hal>";
EXPECT_FALSE(gHalManifestConverter(&vm,
"<manifest version=\"1.0\" type=\"device\">"
" <hal>"
" <name>android.hidl.manager</name>"
" <transport>hwbinder</transport>"
" <version>1.0</version>"
" </hal>"
" <hal>"
" <name>android.hidl.manager</name>"
" <transport arch=\"32+64\">passthrough</transport>"
" <version>1.1</version>"
" </hal>"
"</manifest>"))
<< "Should not allow duplicated major version across <hal>";
}
TEST_F(LibVintfTest, HalManifestGetTransport) {
HalManifest vm;
EXPECT_TRUE(gHalManifestConverter(&vm,
"<manifest version=\"1.0\" type=\"device\">"
" <hal>"
" <name>android.hidl.manager</name>"
" <transport>hwbinder</transport>"
" <version>1.0</version>"
" <interface>"
" <name>IServiceManager</name>"
" <instance>default</instance>"
" </interface>"
" </hal>"
" <hal>"
" <name>android.hidl.manager</name>"
" <transport arch=\"32+64\">passthrough</transport>"
" <version>2.1</version>"
" <interface>"
" <name>IServiceManager</name>"
" <instance>default</instance>"
" </interface>"
" </hal>"
"</manifest>"));
EXPECT_EQ(Transport::PASSTHROUGH,
vm.getTransport("android.hidl.manager", {2, 1}, "IServiceManager", "default"));
EXPECT_EQ(Transport::PASSTHROUGH,
vm.getTransport("android.hidl.manager", {2, 0}, "IServiceManager", "default"));
EXPECT_EQ(Transport::EMPTY,
vm.getTransport("android.hidl.manager", {2, 2}, "IServiceManager", "default"));
EXPECT_EQ(Transport::HWBINDER,
vm.getTransport("android.hidl.manager", {1, 0}, "IServiceManager", "default"));
}
TEST_F(LibVintfTest, HalManifestInstances) {
HalManifest vm = testDeviceManifest();
EXPECT_EQ(vm.getInstances("android.hardware.camera", {2, 0}, "ICamera"),
std::set<std::string>({"default", "legacy/0"}));
EXPECT_EQ(vm.getInstances("android.hardware.camera", {2, 0}, "IBetterCamera"),
std::set<std::string>({"camera"}));
EXPECT_EQ(vm.getInstances("android.hardware.camera", {2, 0}, "INotExist"),
std::set<std::string>({}));
EXPECT_EQ(vm.getInstances("android.hardware.nfc", {1, 0}, "INfc"),
std::set<std::string>({"default"}));
EXPECT_TRUE(vm.hasInstance("android.hardware.camera", {2, 0}, "ICamera", "default"));
EXPECT_TRUE(vm.hasInstance("android.hardware.camera", {2, 0}, "ICamera", "legacy/0"));
EXPECT_TRUE(vm.hasInstance("android.hardware.camera", {2, 0}, "IBetterCamera", "camera"));
EXPECT_TRUE(vm.hasInstance("android.hardware.nfc", {1, 0}, "INfc", "default"));
EXPECT_FALSE(vm.hasInstance("android.hardware.camera", {2, 0}, "INotExist", "default"));
EXPECT_FALSE(vm.hasInstance("android.hardware.camera", {2, 0}, "ICamera", "notexist"));
EXPECT_FALSE(vm.hasInstance("android.hardware.camera", {2, 0}, "IBetterCamera", "default"));
EXPECT_FALSE(vm.hasInstance("android.hardware.camera", {2, 0}, "INotExist", "notexist"));
EXPECT_FALSE(vm.hasInstance("android.hardware.nfc", {1, 0}, "INfc", "notexist"));
}
TEST_F(LibVintfTest, VersionConverter) {
Version v(3, 6);
std::string xml = gVersionConverter(v);
EXPECT_EQ(xml, "<version>3.6</version>\n");
Version v2;
EXPECT_TRUE(gVersionConverter(&v2, xml));
EXPECT_EQ(v, v2);
}
static bool insert(std::map<std::string, HalInterface>* map, HalInterface&& intf) {
std::string name{intf.name()};
return map->emplace(std::move(name), std::move(intf)).second;
}
TEST_F(LibVintfTest, MatrixHalConverter) {
MatrixHal mh{HalFormat::NATIVE, "android.hardware.camera",
{{VersionRange(1,2,3), VersionRange(4,5,6)}},
false /* optional */, {}};
EXPECT_TRUE(insert(&mh.interfaces, {"IBetterCamera", {"default", "great"}}));
EXPECT_TRUE(insert(&mh.interfaces, {"ICamera", {"default"}}));
std::string xml = gMatrixHalConverter(mh);
EXPECT_EQ(xml,
"<hal format=\"native\" optional=\"false\">\n"
" <name>android.hardware.camera</name>\n"
" <version>1.2-3</version>\n"
" <version>4.5-6</version>\n"
" <interface>\n"
" <name>IBetterCamera</name>\n"
" <instance>default</instance>\n"
" <instance>great</instance>\n"
" </interface>\n"
" <interface>\n"
" <name>ICamera</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
"</hal>\n");
MatrixHal mh2;
EXPECT_TRUE(gMatrixHalConverter(&mh2, xml));
EXPECT_EQ(mh, mh2);
}
TEST_F(LibVintfTest, KernelConfigTypedValueConverter) {
KernelConfigTypedValue converted;
auto testOne = [] (const KernelConfigTypedValue &original,
const std::string &expectXml) {
std::string xml;
KernelConfigTypedValue converted;
xml = gKernelConfigTypedValueConverter(original);
EXPECT_EQ(xml, expectXml);
EXPECT_TRUE(gKernelConfigTypedValueConverter(&converted, xml));
EXPECT_EQ(original, converted);
};
auto testParse = [] (const KernelConfigTypedValue &original,
const std::string &xml) {
KernelConfigTypedValue converted;
EXPECT_TRUE(gKernelConfigTypedValueConverter(&converted, xml));
EXPECT_EQ(original, converted);
};
testOne(KernelConfigTypedValue("stringvalue"),
"<value type=\"string\">stringvalue</value>\n");
testOne(KernelConfigTypedValue(""),
"<value type=\"string\"></value>\n");
testOne(KernelConfigTypedValue(Tristate::YES),
"<value type=\"tristate\">y</value>\n");
testOne(KernelConfigTypedValue(Tristate::NO),
"<value type=\"tristate\">n</value>\n");
testOne(KernelConfigTypedValue(Tristate::MODULE),
"<value type=\"tristate\">m</value>\n");
EXPECT_FALSE(gKernelConfigTypedValueConverter(&converted,
"<value type=\"tristate\">q</value>\n"));
testOne(KernelConfigTypedValue(KernelConfigRangeValue{4, 20}),
"<value type=\"range\">4-20</value>\n");
testOne(KernelConfigTypedValue(KernelConfigRangeValue{0, UINT64_MAX}),
"<value type=\"range\">0-18446744073709551615</value>\n");
testParse(KernelConfigTypedValue(KernelConfigRangeValue{0, UINT64_MAX}),
"<value type=\"range\">0x0-0xffffffffffffffff</value>\n");
EXPECT_FALSE(gKernelConfigTypedValueConverter(&converted,
"<value type=\"int\">-18446744073709551616</value>\n"));
testOne(KernelConfigTypedValue(INT64_MIN),
"<value type=\"int\">-9223372036854775808</value>\n");
testParse(KernelConfigTypedValue(INT64_MIN),
"<value type=\"int\">0x8000000000000000</value>\n");
testParse(KernelConfigTypedValue(INT64_MIN),
"<value type=\"int\">-0X8000000000000000</value>\n");
testParse(KernelConfigTypedValue(INT64_MIN + 1),
"<value type=\"int\">-0X7FFFFFFFFFFFFFFF</value>\n");
testParse(KernelConfigTypedValue(-0x50),
"<value type=\"int\">-0x50</value>\n");
testOne(KernelConfigTypedValue(0),
"<value type=\"int\">0</value>\n");
// Truncation for underflow.
testParse(KernelConfigTypedValue(1),
"<value type=\"int\">-0xffffffffffffffff</value>\n");
testParse(KernelConfigTypedValue(1),
"<value type=\"int\">-18446744073709551615</value>\n");
testOne(KernelConfigTypedValue(INT64_MAX),
"<value type=\"int\">9223372036854775807</value>\n");
testParse(KernelConfigTypedValue(INT64_MAX),
"<value type=\"int\">0x7FFFFFFFFFFFFFFF</value>\n");
// Truncation for underflow.
testParse(KernelConfigTypedValue(INT64_MAX),
"<value type=\"int\">-9223372036854775809</value>\n");
testParse(KernelConfigTypedValue(-1),
"<value type=\"int\">18446744073709551615</value>\n");
testParse(KernelConfigTypedValue(-1),
"<value type=\"int\">0xffffffffffffffff</value>\n");
EXPECT_FALSE(gKernelConfigTypedValueConverter(&converted,
"<value type=\"int\">18446744073709551616</value>\n"));
}
TEST_F(LibVintfTest, CompatibilityMatrixConverter) {
CompatibilityMatrix cm;
EXPECT_TRUE(add(cm, MatrixHal{HalFormat::NATIVE, "android.hardware.camera",
{{VersionRange(1,2,3), VersionRange(4,5,6)}},
false /* optional */, testHalInterfaces()}));
EXPECT_TRUE(add(cm, MatrixHal{HalFormat::NATIVE, "android.hardware.nfc",
{{VersionRange(4,5,6), VersionRange(10,11,12)}},
true /* optional */, testHalInterfaces()}));
EXPECT_TRUE(add(cm, MatrixKernel{KernelVersion(3, 18, 22),
{KernelConfig{"CONFIG_FOO", Tristate::YES}, KernelConfig{"CONFIG_BAR", "stringvalue"}}}));
EXPECT_TRUE(add(cm, MatrixKernel{KernelVersion(4, 4, 1),
{KernelConfig{"CONFIG_BAZ", 20}, KernelConfig{"CONFIG_BAR", KernelConfigRangeValue{3, 5} }}}));
set(cm, Sepolicy(30, {{25, 0}, {26, 0, 3}}));
setAvb(cm, Version{2, 1});
std::string xml = gCompatibilityMatrixConverter(cm);
EXPECT_EQ(xml,
"<compatibility-matrix version=\"1.0\" type=\"framework\">\n"
" <hal format=\"native\" optional=\"false\">\n"
" <name>android.hardware.camera</name>\n"
" <version>1.2-3</version>\n"
" <version>4.5-6</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
" <hal format=\"native\" optional=\"true\">\n"
" <name>android.hardware.nfc</name>\n"
" <version>4.5-6</version>\n"
" <version>10.11-12</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
" <kernel version=\"3.18.22\">\n"
" <config>\n"
" <key>CONFIG_FOO</key>\n"
" <value type=\"tristate\">y</value>\n"
" </config>\n"
" <config>\n"
" <key>CONFIG_BAR</key>\n"
" <value type=\"string\">stringvalue</value>\n"
" </config>\n"
" </kernel>\n"
" <kernel version=\"4.4.1\">\n"
" <config>\n"
" <key>CONFIG_BAZ</key>\n"
" <value type=\"int\">20</value>\n"
" </config>\n"
" <config>\n"
" <key>CONFIG_BAR</key>\n"
" <value type=\"range\">3-5</value>\n"
" </config>\n"
" </kernel>\n"
" <sepolicy>\n"
" <kernel-sepolicy-version>30</kernel-sepolicy-version>\n"
" <sepolicy-version>25.0</sepolicy-version>\n"
" <sepolicy-version>26.0-3</sepolicy-version>\n"
" </sepolicy>\n"
" <avb>\n"
" <vbmeta-version>2.1</vbmeta-version>\n"
" </avb>\n"
"</compatibility-matrix>\n");
CompatibilityMatrix cm2;
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm2, xml));
EXPECT_EQ(cm, cm2);
}
TEST_F(LibVintfTest, DeviceCompatibilityMatrixCoverter) {
CompatibilityMatrix cm;
EXPECT_TRUE(add(cm, MatrixHal{HalFormat::NATIVE, "android.hidl.manager",
{{VersionRange(1,0)}},
false /* optional */, testHalInterfaces()}));
set(cm, SchemaType::DEVICE);
set(cm, VndkVersionRange{25,0,1,5}, {"libjpeg.so", "libbase.so"});
std::string xml = gCompatibilityMatrixConverter(cm);
EXPECT_EQ(xml,
"<compatibility-matrix version=\"1.0\" type=\"device\">\n"
" <hal format=\"native\" optional=\"false\">\n"
" <name>android.hidl.manager</name>\n"
" <version>1.0</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
" <vndk>\n"
" <version>25.0.1-5</version>\n"
" <library>libbase.so</library>\n"
" <library>libjpeg.so</library>\n"
" </vndk>\n"
"</compatibility-matrix>\n");
CompatibilityMatrix cm2;
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm2, xml));
EXPECT_EQ(cm, cm2);
}
TEST_F(LibVintfTest, IsValid) {
EXPECT_TRUE(isValid(ManifestHal()));
ManifestHal invalidHal{HalFormat::HIDL,
"android.hardware.camera",
{{Version(2, 0), Version(2, 1)}},
{Transport::PASSTHROUGH, Arch::ARCH_32_64},
{}};
EXPECT_FALSE(isValid(invalidHal));
HalManifest vm2;
EXPECT_FALSE(add(vm2, std::move(invalidHal)));
}
TEST_F(LibVintfTest, HalManifestGetHalNames) {
HalManifest vm = testDeviceManifest();
EXPECT_EQ(vm.getHalNames(), std::set<std::string>(
{"android.hardware.camera", "android.hardware.nfc"}));
}
TEST_F(LibVintfTest, HalManifestGetAllHals) {
HalManifest vm = testDeviceManifest();
EXPECT_NE(getAnyHal(vm, "android.hardware.camera"), nullptr);
EXPECT_EQ(getAnyHal(vm, "non-existent"), nullptr);
std::vector<std::string> arr{"android.hardware.camera", "android.hardware.nfc"};
size_t i = 0;
for (const auto &hal : getHals(vm)) {
EXPECT_EQ(hal.name, arr[i++]);
}
}
TEST_F(LibVintfTest, HalManifestGetHals) {
HalManifest vm;
EXPECT_TRUE(add(vm, ManifestHal{HalFormat::HIDL,
"android.hardware.camera",
{Version(1, 2)},
{Transport::HWBINDER, Arch::ARCH_EMPTY},
{{"ICamera", {"ICamera", {"legacy/0", "default"}}},
{"IBetterCamera", {"IBetterCamera", {"camera"}}}}}));
EXPECT_TRUE(add(vm, ManifestHal{HalFormat::HIDL,
"android.hardware.camera",
{Version(2, 0)},
{Transport::HWBINDER, Arch::ARCH_EMPTY},
{{"ICamera", {"ICamera", {"legacy/0", "default"}}},
{"IBetterCamera", {"IBetterCamera", {"camera"}}}}}));
EXPECT_TRUE(add(vm, ManifestHal{HalFormat::HIDL,
"android.hardware.nfc",
{Version(1, 0), Version(2, 1)},
{Transport::PASSTHROUGH, Arch::ARCH_32_64},
{{"INfc", {"INfc", {"default"}}}}}));
ManifestHal expectedCameraHalV1_2 =
ManifestHal{HalFormat::HIDL,
"android.hardware.camera",
{Version(1, 2)},
{Transport::HWBINDER, Arch::ARCH_EMPTY},
{{"ICamera", {"ICamera", {"legacy/0", "default"}}},
{"IBetterCamera", {"IBetterCamera", {"camera"}}}}};
ManifestHal expectedCameraHalV2_0 =
ManifestHal{HalFormat::HIDL,
"android.hardware.camera",
{Version(2, 0)},
{Transport::HWBINDER, Arch::ARCH_EMPTY},
{{"ICamera", {"ICamera", {"legacy/0", "default"}}},
{"IBetterCamera", {"IBetterCamera", {"camera"}}}}};
ManifestHal expectedNfcHal = ManifestHal{HalFormat::HIDL,
"android.hardware.nfc",
{Version(1, 0), Version(2, 1)},
{Transport::PASSTHROUGH, Arch::ARCH_32_64},
{{"INfc", {"INfc", {"default"}}}}};
auto cameraHals = getHals(vm, "android.hardware.camera");
EXPECT_EQ((int)cameraHals.size(), 2);
EXPECT_EQ(*cameraHals[0], expectedCameraHalV1_2);
EXPECT_EQ(*cameraHals[1], expectedCameraHalV2_0);
auto nfcHals = getHals(vm, "android.hardware.nfc");
EXPECT_EQ((int)nfcHals.size(), 1);
EXPECT_EQ(*nfcHals[0], expectedNfcHal);
}
TEST_F(LibVintfTest, CompatibilityMatrixGetHals) {
CompatibilityMatrix cm;
EXPECT_TRUE(add(cm, MatrixHal{HalFormat::NATIVE,
"android.hardware.camera",
{{VersionRange(1, 2, 3), VersionRange(4, 5, 6)}},
false /* optional */,
testHalInterfaces()}));
EXPECT_TRUE(add(cm, MatrixHal{HalFormat::NATIVE,
"android.hardware.nfc",
{{VersionRange(4, 5, 6), VersionRange(10, 11, 12)}},
true /* optional */,
testHalInterfaces()}));
MatrixHal expectedCameraHal = MatrixHal{
HalFormat::NATIVE,
"android.hardware.camera",
{{VersionRange(1, 2, 3), VersionRange(4, 5, 6)}},
false /* optional */,
testHalInterfaces(),
};
MatrixHal expectedNfcHal = MatrixHal{HalFormat::NATIVE,
"android.hardware.nfc",
{{VersionRange(4, 5, 6), VersionRange(10, 11, 12)}},
true /* optional */,
testHalInterfaces()};
auto cameraHals = getHals(cm, "android.hardware.camera");
EXPECT_EQ((int)cameraHals.size(), 1);
EXPECT_EQ(*cameraHals[0], expectedCameraHal);
auto nfcHals = getHals(cm, "android.hardware.nfc");
EXPECT_EQ((int)nfcHals.size(), 1);
EXPECT_EQ(*nfcHals[0], expectedNfcHal);
}
TEST_F(LibVintfTest, RuntimeInfo) {
RuntimeInfo ki = testRuntimeInfo();
using KernelConfigs = std::vector<KernelConfig>;
const KernelConfigs configs {
KernelConfig{"CONFIG_64BIT", Tristate::YES},
KernelConfig{"CONFIG_ANDROID_BINDER_DEVICES", "binder,hwbinder"},
KernelConfig{"CONFIG_ARCH_MMAP_RND_BITS", 24},
KernelConfig{"CONFIG_BUILD_ARM64_APPENDED_DTB_IMAGE_NAMES", ""},
KernelConfig{"CONFIG_ILLEGAL_POINTER_VALUE", 0xdead000000000000},
KernelConfig{"CONFIG_NOTEXIST", Tristate::NO},
};
auto testMatrix = [&] (MatrixKernel &&kernel) {
CompatibilityMatrix cm;
add(cm, std::move(kernel));
set(cm, {30, {{25, 0}}});
setAvb(cm, {2, 1});
return cm;
};
std::string error;
{
MatrixKernel kernel(KernelVersion{4, 4, 1}, KernelConfigs(configs));
CompatibilityMatrix cm = testMatrix(std::move(kernel));
EXPECT_FALSE(ki.checkCompatibility(cm)) << "Kernel version shouldn't match";
}
{
MatrixKernel kernel(KernelVersion{3, 18, 60}, KernelConfigs(configs));
CompatibilityMatrix cm = testMatrix(std::move(kernel));
EXPECT_FALSE(ki.checkCompatibility(cm)) << "Kernel version shouldn't match";
}
{
MatrixKernel kernel(KernelVersion{3, 18, 22}, KernelConfigs(configs));
CompatibilityMatrix cm = testMatrix(std::move(kernel));
EXPECT_TRUE(ki.checkCompatibility(cm, &error)) << error;
}
{
MatrixKernel kernel(KernelVersion{3, 18, 22}, KernelConfigs(configs));
CompatibilityMatrix cm = testMatrix(std::move(kernel));
set(cm, Sepolicy{22, {{25, 0}}});
EXPECT_TRUE(ki.checkCompatibility(cm, &error)) << error;
set(cm, Sepolicy{40, {{25, 0}}});
EXPECT_FALSE(ki.checkCompatibility(cm, &error))
<< "kernel-sepolicy-version shouldn't match";
EXPECT_IN("kernelSepolicyVersion = 30 but required >= 40", error);
}
{
KernelConfigs newConfigs(configs);
newConfigs[0] = KernelConfig{"CONFIG_64BIT", Tristate::NO};
MatrixKernel kernel(KernelVersion{3, 18, 22}, std::move(newConfigs));
CompatibilityMatrix cm = testMatrix(std::move(kernel));
EXPECT_FALSE(ki.checkCompatibility(cm)) << "Value shouldn't match for tristate";
}
{
KernelConfigs newConfigs(configs);
newConfigs[0] = KernelConfig{"CONFIG_64BIT", 20};
MatrixKernel kernel(KernelVersion{3, 18, 22}, std::move(newConfigs));
CompatibilityMatrix cm = testMatrix(std::move(kernel));
EXPECT_FALSE(ki.checkCompatibility(cm)) << "Type shouldn't match";
}
{
KernelConfigs newConfigs(configs);
newConfigs[1] = KernelConfig{"CONFIG_ANDROID_BINDER_DEVICES", "binder"};
MatrixKernel kernel(KernelVersion{3, 18, 22}, std::move(newConfigs));
CompatibilityMatrix cm = testMatrix(std::move(kernel));
EXPECT_FALSE(ki.checkCompatibility(cm)) << "Value shouldn't match for string";
}
{
KernelConfigs newConfigs(configs);
newConfigs[1] = KernelConfig{"CONFIG_ANDROID_BINDER_DEVICES", Tristate::YES};
MatrixKernel kernel(KernelVersion{3, 18, 22}, std::move(newConfigs));
CompatibilityMatrix cm = testMatrix(std::move(kernel));
EXPECT_FALSE(ki.checkCompatibility(cm)) << "Type shouldn't match";
}
{
KernelConfigs newConfigs(configs);
newConfigs[2] = KernelConfig{"CONFIG_ARCH_MMAP_RND_BITS", 30};
MatrixKernel kernel(KernelVersion{3, 18, 22}, std::move(newConfigs));
CompatibilityMatrix cm = testMatrix(std::move(kernel));
EXPECT_FALSE(ki.checkCompatibility(cm)) << "Value shouldn't match for integer";
}
RuntimeInfo badAvb = testRuntimeInfo();
CompatibilityMatrix cm = testMatrix(MatrixKernel(KernelVersion{3, 18, 31}, {}));
{
setAvb(badAvb, {1, 0}, {2, 1});
EXPECT_FALSE(badAvb.checkCompatibility(cm, &error, CheckFlags::ENABLE_ALL_CHECKS));
EXPECT_STREQ(error.c_str(), "Vbmeta version 1.0 does not match framework matrix 2.1");
}
{
setAvb(badAvb, {2, 1}, {3, 0});
EXPECT_FALSE(badAvb.checkCompatibility(cm, &error, CheckFlags::ENABLE_ALL_CHECKS));
}
{
setAvb(badAvb, {2, 1}, {2, 3});
EXPECT_TRUE(badAvb.checkCompatibility(cm, &error, CheckFlags::ENABLE_ALL_CHECKS));
}
{
setAvb(badAvb, {2, 3}, {2, 1});
EXPECT_TRUE(badAvb.checkCompatibility(cm, &error, CheckFlags::ENABLE_ALL_CHECKS));
}
}
TEST_F(LibVintfTest, MissingAvb) {
std::string xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\">\n"
" <kernel version=\"3.18.31\"></kernel>"
" <sepolicy>\n"
" <kernel-sepolicy-version>30</kernel-sepolicy-version>\n"
" <sepolicy-version>25.5</sepolicy-version>\n"
" </sepolicy>\n"
"</compatibility-matrix>\n";
CompatibilityMatrix cm;
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm, xml));
EXPECT_EQ(getAvb(cm), Version(0, 0));
}
TEST_F(LibVintfTest, DisableAvb) {
std::string xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\">\n"
" <kernel version=\"3.18.31\"></kernel>"
" <sepolicy>\n"
" <kernel-sepolicy-version>30</kernel-sepolicy-version>\n"
" <sepolicy-version>25.5</sepolicy-version>\n"
" </sepolicy>\n"
" <avb>\n"
" <vbmeta-version>1.0</vbmeta-version>\n"
" </avb>\n"
"</compatibility-matrix>\n";
CompatibilityMatrix cm;
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm, xml));
RuntimeInfo ki = testRuntimeInfo();
std::string error;
EXPECT_FALSE(ki.checkCompatibility(cm, &error, CheckFlags::ENABLE_ALL_CHECKS));
EXPECT_STREQ(error.c_str(), "AVB version 2.1 does not match framework matrix 1.0");
EXPECT_TRUE(ki.checkCompatibility(cm, &error, CheckFlags::DISABLE_AVB_CHECK)) << error;
}
// This is the test extracted from VINTF Object doc
TEST_F(LibVintfTest, HalCompat) {
CompatibilityMatrix matrix;
std::string error;
std::string matrixXml =
"<compatibility-matrix version=\"1.0\" type=\"framework\">\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>1.0</version>\n"
" <version>3.1-2</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" <instance>specific</instance>\n"
" </interface>\n"
" </hal>\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>2.0</version>\n"
" <interface>\n"
" <name>IBar</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
" <sepolicy>\n"
" <kernel-sepolicy-version>30</kernel-sepolicy-version>\n"
" <sepolicy-version>25.5</sepolicy-version>\n"
" </sepolicy>\n"
"</compatibility-matrix>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&matrix, matrixXml))
<< gCompatibilityMatrixConverter.lastError();
{
std::string manifestXml =
"<manifest version=\"1.0\" type=\"device\">\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <version>1.0</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" <instance>specific</instance>\n"
" </interface>\n"
" </hal>\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <version>2.0</version>\n"
" <interface>\n"
" <name>IBar</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
" <sepolicy>\n"
" <version>25.5</version>\n"
" </sepolicy>\n"
"</manifest>\n";
HalManifest manifest;
EXPECT_TRUE(gHalManifestConverter(&manifest, manifestXml));
EXPECT_TRUE(manifest.checkCompatibility(matrix, &error)) << error;
}
{
std::string manifestXml =
"<manifest version=\"1.0\" type=\"device\">\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <version>1.0</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" <instance>specific</instance>\n"
" </interface>\n"
" </hal>\n"
" <sepolicy>\n"
" <version>25.5</version>\n"
" </sepolicy>\n"
"</manifest>\n";
HalManifest manifest;
EXPECT_TRUE(gHalManifestConverter(&manifest, manifestXml));
EXPECT_FALSE(manifest.checkCompatibility(matrix, &error))
<< "should not be compatible because IBar is missing";
}
{
std::string manifestXml =
"<manifest version=\"1.0\" type=\"device\">\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <version>1.0</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <version>2.0</version>\n"
" <interface>\n"
" <name>IBar</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
" <sepolicy>\n"
" <version>25.5</version>\n"
" </sepolicy>\n"
"</manifest>\n";
HalManifest manifest;
EXPECT_TRUE(gHalManifestConverter(&manifest, manifestXml));
EXPECT_FALSE(manifest.checkCompatibility(matrix, &error))
<< "should not be compatible because IFoo/specific is missing";
}
{
std::string manifestXml =
"<manifest version=\"1.0\" type=\"device\">\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <version>3.3</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" <instance>specific</instance>\n"
" </interface>\n"
" </hal>\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <version>2.0</version>\n"
" <interface>\n"
" <name>IBar</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
" <sepolicy>\n"
" <version>25.5</version>\n"
" </sepolicy>\n"
"</manifest>\n";
HalManifest manifest;
EXPECT_TRUE(gHalManifestConverter(&manifest, manifestXml));
EXPECT_TRUE(manifest.checkCompatibility(matrix, &error)) << error;
}
{
std::string manifestXml =
"<manifest version=\"1.0\" type=\"device\">\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <version>1.0</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <version>3.2</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>specific</instance>\n"
" </interface>\n"
" </hal>\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <version>2.0</version>\n"
" <interface>\n"
" <name>IBar</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
" <sepolicy>\n"
" <version>25.5</version>\n"
" </sepolicy>\n"
"</manifest>\n";
HalManifest manifest;
EXPECT_TRUE(gHalManifestConverter(&manifest, manifestXml));
EXPECT_FALSE(manifest.checkCompatibility(matrix, &error))
<< "should not be compatible even though @1.0::IFoo/default "
<< "and @3.2::IFoo/specific present";
}
{
std::string manifestXml =
"<manifest version=\"1.0\" type=\"device\">\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <version>1.0</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" <instance>specific</instance>\n"
" </interface>\n"
" </hal>\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <version>2.0</version>\n"
" <interface>\n"
" <name>IBar</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
" <sepolicy>\n"
" <version>25.5</version>\n"
" </sepolicy>\n"
"</manifest>\n";
HalManifest manifest;
EXPECT_TRUE(gHalManifestConverter(&manifest, manifestXml))
<< gHalManifestConverter.lastError();
EXPECT_TRUE(manifest.checkCompatibility(matrix, &error)) << error;
}
}
TEST_F(LibVintfTest, Compat) {
std::string manifestXml =
"<manifest version=\"1.0\" type=\"device\">\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.camera</name>\n"
" <transport>hwbinder</transport>\n"
" <version>3.5</version>\n"
" <interface>\n"
" <name>IBetterCamera</name>\n"
" <instance>camera</instance>\n"
" </interface>\n"
" <interface>\n"
" <name>ICamera</name>\n"
" <instance>default</instance>\n"
" <instance>legacy/0</instance>\n"
" </interface>\n"
" </hal>\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.nfc</name>\n"
" <transport>hwbinder</transport>\n"
" <version>1.0</version>\n"
" <interface>\n"
" <name>INfc</name>\n"
" <instance>nfc_nci</instance>\n"
" </interface>\n"
" </hal>\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.nfc</name>\n"
" <transport>hwbinder</transport>\n"
" <version>2.0</version>\n"
" <interface>\n"
" <name>INfc</name>\n"
" <instance>default</instance>\n"
" <instance>nfc_nci</instance>\n"
" </interface>\n"
" </hal>\n"
" <sepolicy>\n"
" <version>25.5</version>\n"
" </sepolicy>\n"
"</manifest>\n";
std::string matrixXml =
"<compatibility-matrix version=\"1.0\" type=\"framework\">\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.camera</name>\n"
" <version>2.0-5</version>\n"
" <version>3.4-16</version>\n"
" <interface>\n"
" <name>IBetterCamera</name>\n"
" <instance>camera</instance>\n"
" </interface>\n"
" <interface>\n"
" <name>ICamera</name>\n"
" <instance>default</instance>\n"
" <instance>legacy/0</instance>\n"
" </interface>\n"
" </hal>\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.nfc</name>\n"
" <version>1.0</version>\n"
" <version>2.0</version>\n"
" <interface>\n"
" <name>INfc</name>\n"
" <instance>nfc_nci</instance>\n"
" </interface>\n"
" </hal>\n"
" <hal format=\"hidl\" optional=\"true\">\n"
" <name>android.hardware.foo</name>\n"
" <version>1.0</version>\n"
" </hal>\n"
" <sepolicy>\n"
" <kernel-sepolicy-version>30</kernel-sepolicy-version>\n"
" <sepolicy-version>25.5</sepolicy-version>\n"
" <sepolicy-version>26.0-3</sepolicy-version>\n"
" </sepolicy>\n"
" <avb>\n"
" <vbmeta-version>2.1</vbmeta-version>\n"
" </avb>\n"
"</compatibility-matrix>\n";
HalManifest manifest;
CompatibilityMatrix matrix;
std::string error;
EXPECT_TRUE(gHalManifestConverter(&manifest, manifestXml));
EXPECT_TRUE(gCompatibilityMatrixConverter(&matrix, matrixXml));
EXPECT_TRUE(manifest.checkCompatibility(matrix, &error)) << error;
// some smaller test cases
matrixXml =
"<compatibility-matrix version=\"1.0\" type=\"framework\">\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.camera</name>\n"
" <version>3.4</version>\n"
" </hal>\n"
" <sepolicy>\n"
" <kernel-sepolicy-version>30</kernel-sepolicy-version>\n"
" <sepolicy-version>25.5</sepolicy-version>\n"
" </sepolicy>\n"
" <avb><vbmeta-version>2.1</vbmeta-version></avb>\n"
"</compatibility-matrix>\n";
matrix = {};
EXPECT_TRUE(gCompatibilityMatrixConverter(&matrix, matrixXml));
EXPECT_TRUE(manifest.checkCompatibility(matrix, &error)) << error;
MatrixHal *camera = getAnyHal(matrix, "android.hardware.camera");
EXPECT_NE(camera, nullptr);
camera->versionRanges[0] = {3, 5};
EXPECT_TRUE(manifest.checkCompatibility(matrix, &error)) << error;
camera->versionRanges[0] = {3, 6};
EXPECT_FALSE(manifest.checkCompatibility(matrix));
// reset it
matrix = {};
EXPECT_TRUE(gCompatibilityMatrixConverter(&matrix, matrixXml));
set(matrix, Sepolicy{30, {{26, 0}}});
EXPECT_FALSE(manifest.checkCompatibility(matrix));
set(matrix, Sepolicy{30, {{25, 6}}});
EXPECT_FALSE(manifest.checkCompatibility(matrix));
set(matrix, Sepolicy{30, {{25, 4}}});
EXPECT_TRUE(manifest.checkCompatibility(matrix, &error)) << error;
}
/////////////////// xmlfile tests
TEST_F(LibVintfTest, HalManifestConverterXmlFile) {
HalManifest vm = testDeviceManifestWithXmlFile();
std::string xml = gHalManifestConverter(
vm, SerializeFlags::NO_TAGS.enableHals().enableSepolicy().enableXmlFiles());
EXPECT_EQ(xml,
"<manifest version=\"1.0\" type=\"device\">\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.camera</name>\n"
" <transport>hwbinder</transport>\n"
" <version>2.0</version>\n"
" <interface>\n"
" <name>IBetterCamera</name>\n"
" <instance>camera</instance>\n"
" </interface>\n"
" <interface>\n"
" <name>ICamera</name>\n"
" <instance>default</instance>\n"
" <instance>legacy/0</instance>\n"
" </interface>\n"
" </hal>\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.nfc</name>\n"
" <transport arch=\"32+64\">passthrough</transport>\n"
" <version>1.0</version>\n"
" <interface>\n"
" <name>INfc</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
" <sepolicy>\n"
" <version>25.0</version>\n"
" </sepolicy>\n"
" <xmlfile>\n"
" <name>media_profile</name>\n"
" <version>1.0</version>\n"
" </xmlfile>\n"
"</manifest>\n");
HalManifest vm2;
EXPECT_TRUE(gHalManifestConverter(&vm2, xml));
EXPECT_EQ(vm, vm2);
}
TEST_F(LibVintfTest, CompatibilityMatrixConverterXmlFile) {
CompatibilityMatrix cm;
addXmlFile(cm, "media_profile", {1, 0});
std::string xml = gCompatibilityMatrixConverter(cm, SerializeFlags::XMLFILES_ONLY);
EXPECT_EQ(xml,
"<compatibility-matrix version=\"1.0\" type=\"framework\">\n"
" <xmlfile format=\"dtd\" optional=\"true\">\n"
" <name>media_profile</name>\n"
" <version>1.0</version>\n"
" </xmlfile>\n"
"</compatibility-matrix>\n");
CompatibilityMatrix cm2;
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm2, xml));
EXPECT_EQ(cm, cm2);
}
TEST_F(LibVintfTest, CompatibilityMatrixConverterXmlFile2) {
std::string xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\">\n"
" <xmlfile format=\"dtd\" optional=\"false\">\n"
" <name>media_profile</name>\n"
" <version>1.0</version>\n"
" </xmlfile>\n"
"</compatibility-matrix>\n";
CompatibilityMatrix cm;
EXPECT_FALSE(gCompatibilityMatrixConverter(&cm, xml));
EXPECT_EQ(
"compatibility-matrix.xmlfile entry media_profile has to be optional for "
"compatibility matrix version 1.0",
gCompatibilityMatrixConverter.lastError());
}
TEST_F(LibVintfTest, ManifestXmlFilePathDevice) {
std::string manifestXml =
"<manifest version=\"1.0\" type=\"device\">"
" <xmlfile>"
" <name>media_profile</name>"
" <version>1.0</version>"
" </xmlfile>"
"</manifest>";
HalManifest manifest;
EXPECT_TRUE(gHalManifestConverter(&manifest, manifestXml));
EXPECT_EQ(manifest.getXmlFilePath("media_profile", {1, 0}),
"/vendor/etc/media_profile_V1_0.xml");
}
TEST_F(LibVintfTest, ManifestXmlFilePathFramework) {
std::string manifestXml =
"<manifest version=\"1.0\" type=\"framework\">"
" <xmlfile>"
" <name>media_profile</name>"
" <version>1.0</version>"
" </xmlfile>"
"</manifest>";
HalManifest manifest;
EXPECT_TRUE(gHalManifestConverter(&manifest, manifestXml));
EXPECT_EQ(manifest.getXmlFilePath("media_profile", {1, 0}),
"/system/etc/media_profile_V1_0.xml");
}
TEST_F(LibVintfTest, ManifestXmlFilePathOverride) {
std::string manifestXml =
"<manifest version=\"1.0\" type=\"device\">"
" <xmlfile>"
" <name>media_profile</name>"
" <version>1.0</version>"
" <path>/vendor/etc/foo.xml</path>"
" </xmlfile>"
"</manifest>";
HalManifest manifest;
EXPECT_TRUE(gHalManifestConverter(&manifest, manifestXml));
EXPECT_EQ(manifest.getXmlFilePath("media_profile", {1, 0}), "/vendor/etc/foo.xml");
}
TEST_F(LibVintfTest, ManifestXmlFilePathMissing) {
std::string manifestXml =
"<manifest version=\"1.0\" type=\"device\">"
" <xmlfile>"
" <name>media_profile</name>"
" <version>1.1</version>"
" </xmlfile>"
"</manifest>";
HalManifest manifest;
EXPECT_TRUE(gHalManifestConverter(&manifest, manifestXml));
EXPECT_EQ(manifest.getXmlFilePath("media_profile", {1, 0}), "");
}
TEST_F(LibVintfTest, MatrixXmlFilePathFramework) {
std::string matrixXml =
"<compatibility-matrix version=\"1.0\" type=\"framework\">"
" <xmlfile format=\"dtd\" optional=\"true\">"
" <name>media_profile</name>"
" <version>2.0-1</version>"
" </xmlfile>"
"</compatibility-matrix>";
CompatibilityMatrix matrix;
EXPECT_TRUE(gCompatibilityMatrixConverter(&matrix, matrixXml));
EXPECT_EQ(matrix.getXmlSchemaPath("media_profile", {2, 1}),
"/system/etc/media_profile_V2_1.dtd");
}
TEST_F(LibVintfTest, MatrixXmlFilePathDevice) {
std::string matrixXml =
"<compatibility-matrix version=\"1.0\" type=\"device\">"
" <xmlfile format=\"xsd\" optional=\"true\">"
" <name>media_profile</name>"
" <version>2.0-1</version>"
" </xmlfile>"
"</compatibility-matrix>";
CompatibilityMatrix matrix;
EXPECT_TRUE(gCompatibilityMatrixConverter(&matrix, matrixXml));
EXPECT_EQ(matrix.getXmlSchemaPath("media_profile", {2, 0}),
"/vendor/etc/media_profile_V2_1.xsd");
}
TEST_F(LibVintfTest, MatrixXmlFilePathOverride) {
std::string matrixXml =
"<compatibility-matrix version=\"1.0\" type=\"framework\">"
" <xmlfile format=\"xsd\" optional=\"true\">"
" <name>media_profile</name>"
" <version>2.0-1</version>"
" <path>/system/etc/foo.xsd</path>"
" </xmlfile>"
"</compatibility-matrix>";
CompatibilityMatrix matrix;
EXPECT_TRUE(gCompatibilityMatrixConverter(&matrix, matrixXml));
EXPECT_EQ(matrix.getXmlSchemaPath("media_profile", {2, 0}), "/system/etc/foo.xsd");
}
TEST_F(LibVintfTest, MatrixXmlFilePathMissing) {
std::string matrixXml =
"<compatibility-matrix version=\"1.0\" type=\"framework\">"
" <xmlfile format=\"dtd\" optional=\"true\">"
" <name>media_profile</name>"
" <version>2.1</version>"
" </xmlfile>"
"</compatibility-matrix>";
CompatibilityMatrix matrix;
EXPECT_TRUE(gCompatibilityMatrixConverter(&matrix, matrixXml));
EXPECT_EQ(matrix.getXmlSchemaPath("media_profile", {2, 0}), "");
}
std::pair<KernelConfigParser, status_t> processData(const std::string& data, bool processComments,
bool relaxedFormat = false) {
KernelConfigParser parser(processComments, relaxedFormat);
const char* p = data.c_str();
size_t n = 0;
size_t chunkSize;
status_t status = OK;
for (; n < data.size(); p += chunkSize, n += chunkSize) {
chunkSize = std::min<size_t>(5, data.size() - n);
if ((status = parser.process(p, chunkSize)) != OK) {
break;
}
}
return {std::move(parser), status};
}
TEST_F(LibVintfTest, KernelConfigParser) {
// usage in /proc/config.gz
const std::string data =
"# CONFIG_NOT_SET is not set\n"
"CONFIG_ONE=1\n"
"CONFIG_Y=y\n"
"CONFIG_STR=\"string\"\n";
auto pair = processData(data, false /* processComments */);
ASSERT_EQ(OK, pair.second) << pair.first.error();
const auto& configs = pair.first.configs();
EXPECT_EQ(configs.find("CONFIG_ONE")->second, "1");
EXPECT_EQ(configs.find("CONFIG_Y")->second, "y");
EXPECT_EQ(configs.find("CONFIG_STR")->second, "\"string\"");
EXPECT_EQ(configs.find("CONFIG_NOT_SET"), configs.end());
}
TEST_F(LibVintfTest, KernelConfigParser2) {
// usage in android-base.config
const std::string data =
"# CONFIG_NOT_SET is not set\n"
"CONFIG_ONE=1\n"
"CONFIG_Y=y\n"
"CONFIG_STR=string\n"
"# ignore_thiscomment\n"
"# CONFIG_NOT_SET2 is not set\n";
auto pair = processData(data, true /* processComments */);
ASSERT_EQ(OK, pair.second) << pair.first.error();
const auto& configs = pair.first.configs();
EXPECT_EQ(configs.find("CONFIG_ONE")->second, "1");
EXPECT_EQ(configs.find("CONFIG_Y")->second, "y");
EXPECT_EQ(configs.find("CONFIG_STR")->second, "string");
EXPECT_EQ(configs.find("CONFIG_NOT_SET")->second, "n");
EXPECT_EQ(configs.find("CONFIG_NOT_SET2")->second, "n");
}
TEST_F(LibVintfTest, KernelConfigParserSpace) {
// usage in android-base.config
const std::string data =
" # CONFIG_NOT_SET is not set \n"
" CONFIG_ONE=1 # 'tis a one!\n"
" CONFIG_TWO=2 #'tis a two! \n"
" CONFIG_THREE=3#'tis a three! \n"
" CONFIG_233=233#'tis a three! \n"
"#yey! random comments\n"
"CONFIG_Y=y \n"
" CONFIG_YES=y#YES! \n"
"CONFIG_STR=string\n"
"CONFIG_HELLO=hello world! #still works\n"
"CONFIG_WORLD=hello world! \n"
"CONFIG_GOOD = good morning! #comments here\n"
" CONFIG_MORNING = good morning! \n";
auto pair = processData(data, true /* processComments */, true /* relaxedFormat */);
ASSERT_EQ(OK, pair.second) << pair.first.error();
const auto& configs = pair.first.configs();
EXPECT_EQ(configs.find("CONFIG_ONE")->second, "1");
EXPECT_EQ(configs.find("CONFIG_TWO")->second, "2");
EXPECT_EQ(configs.find("CONFIG_THREE")->second, "3");
EXPECT_EQ(configs.find("CONFIG_Y")->second, "y");
EXPECT_EQ(configs.find("CONFIG_STR")->second, "string");
EXPECT_EQ(configs.find("CONFIG_HELLO")->second, "hello world!")
<< "Value should be \"hello world!\" without trailing spaces";
EXPECT_EQ(configs.find("CONFIG_WORLD")->second, "hello world!")
<< "Value should be \"hello world!\" without trailing spaces";
EXPECT_EQ(configs.find("CONFIG_GOOD")->second, "good morning!")
<< "Value should be \"good morning!\" without leading or trailing spaces";
EXPECT_EQ(configs.find("CONFIG_MORNING")->second, "good morning!")
<< "Value should be \"good morning!\" without leading or trailing spaces";
EXPECT_EQ(configs.find("CONFIG_NOT_SET")->second, "n");
}
TEST_F(LibVintfTest, NetutilsWrapperMatrix) {
std::string matrixXml;
CompatibilityMatrix matrix;
matrixXml =
"<compatibility-matrix version=\"1.0\" type=\"device\">"
" <hal format=\"native\" optional=\"false\">"
" <name>netutils-wrapper</name>"
" <version>1.0</version>"
" </hal>"
"</compatibility-matrix>";
EXPECT_TRUE(gCompatibilityMatrixConverter(&matrix, matrixXml))
<< gCompatibilityMatrixConverter.lastError();
// only host libvintf hardcodes netutils-wrapper version requirements
#ifndef LIBVINTF_TARGET
matrixXml =
"<compatibility-matrix version=\"1.0\" type=\"device\">"
" <hal format=\"native\" optional=\"false\">"
" <name>netutils-wrapper</name>"
" <version>1.0-1</version>"
" </hal>"
"</compatibility-matrix>";
EXPECT_FALSE(gCompatibilityMatrixConverter(&matrix, matrixXml));
EXPECT_CONTAINS(
gCompatibilityMatrixConverter.lastError(),
"netutils-wrapper HAL must specify exactly one version x.0, but a range is provided. "
"Perhaps you mean '1.0'?");
matrixXml =
"<compatibility-matrix version=\"1.0\" type=\"device\">"
" <hal format=\"native\" optional=\"false\">"
" <name>netutils-wrapper</name>"
" <version>1.1</version>"
" </hal>"
"</compatibility-matrix>";
EXPECT_FALSE(gCompatibilityMatrixConverter(&matrix, matrixXml));
EXPECT_CONTAINS(
gCompatibilityMatrixConverter.lastError(),
"netutils-wrapper HAL must specify exactly one version x.0, but minor version is not 0. "
"Perhaps you mean '1.0'?");
matrixXml =
"<compatibility-matrix version=\"1.0\" type=\"device\">"
" <hal format=\"native\" optional=\"false\">"
" <name>netutils-wrapper</name>"
" <version>1.0</version>"
" <version>2.0</version>"
" </hal>"
"</compatibility-matrix>";
EXPECT_FALSE(gCompatibilityMatrixConverter(&matrix, matrixXml));
EXPECT_CONTAINS(
gCompatibilityMatrixConverter.lastError(),
"netutils-wrapper HAL must specify exactly one version x.0, but multiple <version> element "
"is specified.");
#endif // LIBVINTF_TARGET
}
TEST_F(LibVintfTest, NetutilsWrapperManifest) {
std::string manifestXml;
HalManifest manifest;
manifestXml =
"<manifest version=\"1.0\" type=\"framework\">"
" <hal format=\"native\">"
" <name>netutils-wrapper</name>"
" <version>1.0</version>"
" <version>2.0</version>"
" </hal>"
"</manifest>";
EXPECT_TRUE(gHalManifestConverter(&manifest, manifestXml)) << gHalManifestConverter.lastError();
// only host libvintf hardcodes netutils-wrapper version requirements
#ifndef LIBVINTF_TARGET
manifestXml =
"<manifest version=\"1.0\" type=\"framework\">"
" <hal format=\"native\">"
" <name>netutils-wrapper</name>"
" <version>1.1</version>"
" </hal>"
"</manifest>";
EXPECT_FALSE(gHalManifestConverter(&manifest, manifestXml));
EXPECT_CONTAINS(
gCompatibilityMatrixConverter.lastError(),
"netutils-wrapper HAL must specify exactly one version x.0, but multiple <version> element "
"is specified.");
manifestXml =
"<manifest version=\"1.0\" type=\"framework\">"
" <hal format=\"native\">"
" <name>netutils-wrapper</name>"
" <version>1.0</version>"
" <version>2.1</version>"
" </hal>"
"</manifest>";
EXPECT_FALSE(gHalManifestConverter(&manifest, manifestXml));
EXPECT_CONTAINS(
gCompatibilityMatrixConverter.lastError(),
"netutils-wrapper HAL must specify exactly one version x.0, but multiple <version> element "
"is specified.");
#endif // LIBVINTF_TARGET
}
TEST_F(LibVintfTest, KernelConfigConditionTest) {
std::string xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\">\n"
" <kernel version=\"3.18.22\"/>\n"
" <kernel version=\"3.18.22\">\n"
" <conditions>\n"
" <config>\n"
" <key>CONFIG_ARM</key>\n"
" <value type=\"tristate\">y</value>\n"
" </config>\n"
" </conditions>\n"
" <config>\n"
" <key>CONFIG_FOO</key>\n"
" <value type=\"tristate\">y</value>\n"
" </config>\n"
" </kernel>\n"
" <sepolicy>\n"
" <kernel-sepolicy-version>30</kernel-sepolicy-version>\n"
" <sepolicy-version>25.0</sepolicy-version>\n"
" </sepolicy>\n"
" <avb>\n"
" <vbmeta-version>2.1</vbmeta-version>\n"
" </avb>\n"
"</compatibility-matrix>\n";
CompatibilityMatrix cm;
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm, xml))
<< gCompatibilityMatrixConverter.lastError();
const auto& kernels = getKernels(cm);
ASSERT_GE(kernels.size(), 2u);
ASSERT_TRUE(kernels[0].conditions().empty());
const auto& kernel = kernels[1];
const auto& cond = kernel.conditions();
ASSERT_FALSE(cond.empty());
EXPECT_EQ("CONFIG_ARM", cond.begin()->first);
EXPECT_EQ(KernelConfigTypedValue(Tristate::YES), cond.begin()->second);
EXPECT_FALSE(kernel.configs().empty());
EXPECT_EQ(xml, gCompatibilityMatrixConverter(cm));
}
TEST_F(LibVintfTest, KernelConfigConditionEmptyTest) {
std::string xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\">\n"
" <kernel version=\"4.4.0\"/>\n"
" <kernel version=\"3.18.22\">\n"
" <conditions>\n"
" <config>\n"
" <key>CONFIG_ARM</key>\n"
" <value type=\"tristate\">y</value>\n"
" </config>\n"
" </conditions>\n"
" </kernel>\n"
"</compatibility-matrix>\n";
CompatibilityMatrix cm;
EXPECT_FALSE(gCompatibilityMatrixConverter(&cm, xml))
<< "Should not accept first kernel version with non-empty conditions";
EXPECT_EQ(
"First <kernel> for version 3.18 must have empty <conditions> "
"for backwards compatibility.",
gCompatibilityMatrixConverter.lastError());
}
TEST_F(LibVintfTest, KernelConfigConditionMatch) {
RuntimeInfo runtime = testRuntimeInfo();
std::string error;
std::string xml;
CompatibilityMatrix cm;
xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\">\n"
" <kernel version=\"3.18.22\"/>\n"
" <kernel version=\"3.18.22\">\n"
" <conditions>\n"
" <config>\n"
" <key>CONFIG_64BIT</key>\n"
" <value type=\"tristate\">y</value>\n"
" </config>\n"
" </conditions>\n"
" <config>\n"
" <key>CONFIG_ARCH_MMAP_RND_BITS</key>\n"
" <value type=\"int\">24</value>\n"
" </config>\n"
" </kernel>\n"
" <sepolicy>\n"
" <kernel-sepolicy-version>30</kernel-sepolicy-version>\n"
" </sepolicy>\n"
" <avb><vbmeta-version>2.1</vbmeta-version></avb>\n"
"</compatibility-matrix>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm, xml))
<< gCompatibilityMatrixConverter.lastError();
EXPECT_TRUE(runtime.checkCompatibility(cm, &error)) << error;
xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\">\n"
" <kernel version=\"3.18.22\"/>\n"
" <kernel version=\"3.18.22\">\n"
" <conditions>\n"
" <config>\n"
" <key>CONFIG_64BIT</key>\n"
" <value type=\"tristate\">y</value>\n"
" </config>\n"
" </conditions>\n"
" <config>\n"
" <key>CONFIG_ARCH_MMAP_RND_BITS</key>\n"
" <value type=\"int\">26</value>\n"
" </config>\n"
" </kernel>\n"
" <sepolicy>\n"
" <kernel-sepolicy-version>30</kernel-sepolicy-version>\n"
" </sepolicy>\n"
" <avb><vbmeta-version>2.1</vbmeta-version></avb>\n"
"</compatibility-matrix>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm, xml))
<< gCompatibilityMatrixConverter.lastError();
EXPECT_FALSE(runtime.checkCompatibility(cm, &error))
<< "conditions met, so CONFIG_ARCH_MMAP_RND_BITS should not match";
xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\">\n"
" <kernel version=\"3.18.22\"/>\n"
" <kernel version=\"3.18.22\">\n"
" <conditions>\n"
" <config>\n"
" <key>CONFIG_64BIT</key>\n"
" <value type=\"tristate\">n</value>\n"
" </config>\n"
" </conditions>\n"
" <config>\n"
" <key>CONFIG_ARCH_MMAP_RND_BITS</key>\n"
" <value type=\"int\">26</value>\n"
" </config>\n"
" </kernel>\n"
" <sepolicy>\n"
" <kernel-sepolicy-version>30</kernel-sepolicy-version>\n"
" </sepolicy>\n"
" <avb><vbmeta-version>2.1</vbmeta-version></avb>\n"
"</compatibility-matrix>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm, xml))
<< gCompatibilityMatrixConverter.lastError();
EXPECT_TRUE(runtime.checkCompatibility(cm, &error)) << error;
xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\">\n"
" <kernel version=\"3.18.22\"/>\n"
" <kernel version=\"3.18.22\">\n"
" <conditions>\n"
" <config>\n"
" <key>CONFIG_64BIT</key>\n"
" <value type=\"tristate\">y</value>\n"
" </config>\n"
" <config>\n"
" <key>CONFIG_ARCH_MMAP_RND_BITS</key>\n"
" <value type=\"int\">24</value>\n"
" </config>\n"
" </conditions>\n"
" <config>\n"
" <key>CONFIG_ILLEGAL_POINTER_VALUE</key>\n"
" <value type=\"int\">0xdead000000000000</value>\n"
" </config>\n"
" </kernel>\n"
" <sepolicy>\n"
" <kernel-sepolicy-version>30</kernel-sepolicy-version>\n"
" </sepolicy>\n"
" <avb><vbmeta-version>2.1</vbmeta-version></avb>\n"
"</compatibility-matrix>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm, xml))
<< gCompatibilityMatrixConverter.lastError();
EXPECT_TRUE(runtime.checkCompatibility(cm, &error));
xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\">\n"
" <kernel version=\"3.18.22\"/>\n"
" <kernel version=\"3.18.22\">\n"
" <conditions>\n"
" <config>\n"
" <key>CONFIG_64BIT</key>\n"
" <value type=\"tristate\">y</value>\n"
" </config>\n"
" <config>\n"
" <key>CONFIG_ARCH_MMAP_RND_BITS</key>\n"
" <value type=\"int\">24</value>\n"
" </config>\n"
" </conditions>\n"
" <config>\n"
" <key>CONFIG_ILLEGAL_POINTER_VALUE</key>\n"
" <value type=\"int\">0xbeaf000000000000</value>\n"
" </config>\n"
" </kernel>\n"
" <sepolicy>\n"
" <kernel-sepolicy-version>30</kernel-sepolicy-version>\n"
" </sepolicy>\n"
" <avb><vbmeta-version>2.1</vbmeta-version></avb>\n"
"</compatibility-matrix>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm, xml))
<< gCompatibilityMatrixConverter.lastError();
EXPECT_FALSE(runtime.checkCompatibility(cm, &error))
<< "conditions have 'and' relationship, so CONFIG_ILLEGAL_POINTER_VALUE should not match";
xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\">\n"
" <kernel version=\"3.18.22\"/>\n"
" <kernel version=\"3.18.22\">\n"
" <conditions>\n"
" <config>\n"
" <key>CONFIG_64BIT</key>\n"
" <value type=\"tristate\">y</value>\n"
" </config>\n"
" <config>\n"
" <key>CONFIG_ARCH_MMAP_RND_BITS</key>\n"
" <value type=\"int\">26</value>\n"
" </config>\n"
" </conditions>\n"
" <config>\n"
" <key>CONFIG_ILLEGAL_POINTER_VALUE</key>\n"
" <value type=\"int\">0xbeaf000000000000</value>\n"
" </config>\n"
" </kernel>\n"
" <sepolicy>\n"
" <kernel-sepolicy-version>30</kernel-sepolicy-version>\n"
" </sepolicy>\n"
" <avb><vbmeta-version>2.1</vbmeta-version></avb>\n"
"</compatibility-matrix>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm, xml))
<< gCompatibilityMatrixConverter.lastError();
EXPECT_TRUE(runtime.checkCompatibility(cm, &error)) << error;
xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\">\n"
" <kernel version=\"3.18.22\">\n"
" <config>\n"
" <key>CONFIG_BUILD_ARM64_APPENDED_DTB_IMAGE_NAMES</key>\n"
" <value type=\"string\"/>\n"
" </config>\n"
" </kernel>\n"
" <kernel version=\"3.18.22\">\n"
" <conditions>\n"
" <config>\n"
" <key>CONFIG_64BIT</key>\n"
" <value type=\"tristate\">y</value>\n"
" </config>\n"
" </conditions>\n"
" <config>\n"
" <key>CONFIG_ILLEGAL_POINTER_VALUE</key>\n"
" <value type=\"int\">0xdead000000000000</value>\n"
" </config>\n"
" </kernel>\n"
" <kernel version=\"3.18.22\">\n"
" <conditions>\n"
" <config>\n"
" <key>CONFIG_ARCH_MMAP_RND_BITS</key>\n"
" <value type=\"int\">24</value>\n"
" </config>\n"
" </conditions>\n"
" <config>\n"
" <key>CONFIG_ANDROID_BINDER_DEVICES</key>\n"
" <value type=\"string\">binder,hwbinder</value>\n"
" </config>\n"
" </kernel>\n"
" <sepolicy>\n"
" <kernel-sepolicy-version>30</kernel-sepolicy-version>\n"
" </sepolicy>\n"
" <avb><vbmeta-version>2.1</vbmeta-version></avb>\n"
"</compatibility-matrix>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm, xml))
<< gCompatibilityMatrixConverter.lastError();
EXPECT_TRUE(runtime.checkCompatibility(cm, &error)) << error;
xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\">\n"
" <kernel version=\"3.18.22\">\n"
" <config>\n"
" <key>CONFIG_BUILD_ARM64_APPENDED_DTB_IMAGE_NAMES</key>\n"
" <value type=\"string\"/>\n"
" </config>\n"
" </kernel>\n"
" <kernel version=\"3.18.22\">\n"
" <conditions>\n"
" <config>\n"
" <key>CONFIG_64BIT</key>\n"
" <value type=\"tristate\">y</value>\n"
" </config>\n"
" </conditions>\n"
" <config>\n"
" <key>CONFIG_ILLEGAL_POINTER_VALUE</key>\n"
" <value type=\"int\">0xbeaf000000000000</value>\n"
" </config>\n"
" </kernel>\n"
" <kernel version=\"3.18.22\">\n"
" <conditions>\n"
" <config>\n"
" <key>CONFIG_ARCH_MMAP_RND_BITS</key>\n"
" <value type=\"int\">24</value>\n"
" </config>\n"
" </conditions>\n"
" <config>\n"
" <key>CONFIG_ANDROID_BINDER_DEVICES</key>\n"
" <value type=\"string\">binder,hwbinder</value>\n"
" </config>\n"
" </kernel>\n"
" <sepolicy>\n"
" <kernel-sepolicy-version>30</kernel-sepolicy-version>\n"
" </sepolicy>\n"
" <avb><vbmeta-version>2.1</vbmeta-version></avb>\n"
"</compatibility-matrix>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm, xml))
<< gCompatibilityMatrixConverter.lastError();
EXPECT_FALSE(runtime.checkCompatibility(cm, &error)) << "all fragments should be used.";
xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\">\n"
" <kernel version=\"3.18.22\">\n"
" <config>\n"
" <key>CONFIG_BUILD_ARM64_APPENDED_DTB_IMAGE_NAMES</key>\n"
" <value type=\"string\"/>\n"
" </config>\n"
" </kernel>\n"
" <kernel version=\"3.18.22\">\n"
" <conditions>\n"
" <config>\n"
" <key>CONFIG_64BIT</key>\n"
" <value type=\"tristate\">y</value>\n"
" </config>\n"
" </conditions>\n"
" <config>\n"
" <key>CONFIG_ILLEGAL_POINTER_VALUE</key>\n"
" <value type=\"int\">0xdead000000000000</value>\n"
" </config>\n"
" </kernel>\n"
" <kernel version=\"3.18.22\">\n"
" <conditions>\n"
" <config>\n"
" <key>CONFIG_ARCH_MMAP_RND_BITS</key>\n"
" <value type=\"int\">24</value>\n"
" </config>\n"
" </conditions>\n"
" <config>\n"
" <key>CONFIG_ANDROID_BINDER_DEVICES</key>\n"
" <value type=\"string\">binder</value>\n"
" </config>\n"
" </kernel>\n"
" <sepolicy>\n"
" <kernel-sepolicy-version>30</kernel-sepolicy-version>\n"
" </sepolicy>\n"
" <avb><vbmeta-version>2.1</vbmeta-version></avb>\n"
"</compatibility-matrix>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm, xml))
<< gCompatibilityMatrixConverter.lastError();
EXPECT_FALSE(runtime.checkCompatibility(cm, &error)) << "all fragments should be used";
}
// Run KernelConfigParserInvalidTest on processComments = {true, false}
class KernelConfigParserInvalidTest : public ::testing::TestWithParam<bool> {};
TEST_P(KernelConfigParserInvalidTest, NonSet1) {
const std::string data = "# CONFIG_NOT_EXIST is not sat\n";
auto pair = processData(data, GetParam() /* processComments */, true /* relaxedFormat */);
ASSERT_EQ(OK, pair.second) << pair.first.error();
const auto& configs = pair.first.configs();
EXPECT_EQ(configs.find("CONFIG_NOT_EXIST"), configs.end())
<< "CONFIG_NOT_EXIST should not exist because of typo";
}
TEST_P(KernelConfigParserInvalidTest, InvalidLine1) {
const std::string data = "FOO_CONFIG=foo\n";
ASSERT_NE(OK,
processData(data, GetParam() /* processComments */, true /* relaxedFormat */).second);
}
TEST_P(KernelConfigParserInvalidTest, InvalidLine2) {
const std::string data = "CONFIG_BAR-BAZ=foo\n";
ASSERT_NE(OK,
processData(data, GetParam() /* processComments */, true /* relaxedFormat */).second);
}
INSTANTIATE_TEST_CASE_P(KernelConfigParser, KernelConfigParserInvalidTest, ::testing::Bool());
TEST_F(LibVintfTest, MatrixLevel) {
CompatibilityMatrix cm;
std::string xml;
xml = "<compatibility-matrix version=\"1.0\" type=\"framework\"/>";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm, xml))
<< gCompatibilityMatrixConverter.lastError();
EXPECT_EQ(Level::UNSPECIFIED, cm.level());
xml = "<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"legacy\"/>";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm, xml))
<< gCompatibilityMatrixConverter.lastError();
EXPECT_EQ(Level::LEGACY, cm.level());
xml = "<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"1\"/>";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm, xml))
<< gCompatibilityMatrixConverter.lastError();
EXPECT_EQ(1u, cm.level());
}
TEST_F(LibVintfTest, ManifestLevel) {
HalManifest manifest;
std::string xml;
xml = "<manifest version=\"1.0\" type=\"device\"/>";
EXPECT_TRUE(gHalManifestConverter(&manifest, xml)) << gHalManifestConverter.lastError();
EXPECT_EQ(Level::UNSPECIFIED, manifest.level());
xml = "<manifest version=\"1.0\" type=\"device\" target-level=\"legacy\"/>";
EXPECT_TRUE(gHalManifestConverter(&manifest, xml)) << gHalManifestConverter.lastError();
EXPECT_EQ(Level::LEGACY, manifest.level());
xml = "<manifest version=\"1.0\" type=\"device\" target-level=\"1\"/>";
EXPECT_TRUE(gHalManifestConverter(&manifest, xml)) << gHalManifestConverter.lastError();
EXPECT_EQ(1u, manifest.level());
}
TEST_F(LibVintfTest, AddOptionalHal) {
CompatibilityMatrix cm1;
CompatibilityMatrix cm2;
std::string error;
std::string xml;
xml = "<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"1\"/>";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm1, xml))
<< gCompatibilityMatrixConverter.lastError();
xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"2\">\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>1.0-1</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
"</compatibility-matrix>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm2, xml))
<< gCompatibilityMatrixConverter.lastError();
EXPECT_TRUE(addAllHalsAsOptional(&cm1, &cm2, &error)) << error;
xml = gCompatibilityMatrixConverter(cm1, SerializeFlags::HALS_ONLY);
EXPECT_EQ(xml,
"<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"1\">\n"
" <hal format=\"hidl\" optional=\"true\">\n"
" <name>android.hardware.foo</name>\n"
" <version>1.0-1</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
"</compatibility-matrix>\n");
}
TEST_F(LibVintfTest, AddOptionalHalMinorVersion) {
CompatibilityMatrix cm1;
CompatibilityMatrix cm2;
std::string error;
std::string xml;
xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"1\">\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>1.2-3</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
"</compatibility-matrix>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm1, xml))
<< gCompatibilityMatrixConverter.lastError();
xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"2\">\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>1.0-4</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
"</compatibility-matrix>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm2, xml))
<< gCompatibilityMatrixConverter.lastError();
EXPECT_TRUE(addAllHalsAsOptional(&cm1, &cm2, &error)) << error;
xml = gCompatibilityMatrixConverter(cm1, SerializeFlags::HALS_ONLY);
EXPECT_EQ(xml,
"<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"1\">\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>1.0-4</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
"</compatibility-matrix>\n");
}
TEST_F(LibVintfTest, AddOptionalHalMajorVersion) {
CompatibilityMatrix cm1;
CompatibilityMatrix cm2;
std::string error;
std::string xml;
xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"1\">\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>1.2-3</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
"</compatibility-matrix>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm1, xml))
<< gCompatibilityMatrixConverter.lastError();
xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"2\">\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>1.2-3</version>\n"
" <version>2.0-4</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
"</compatibility-matrix>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm2, xml))
<< gCompatibilityMatrixConverter.lastError();
EXPECT_TRUE(addAllHalsAsOptional(&cm1, &cm2, &error)) << error;
xml = gCompatibilityMatrixConverter(cm1, SerializeFlags::HALS_ONLY);
EXPECT_EQ(xml,
"<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"1\">\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>1.2-3</version>\n"
" <version>2.0-4</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
"</compatibility-matrix>\n");
}
TEST_F(LibVintfTest, AddOptionalHalMinorVersionDiffInstance) {
CompatibilityMatrix cm1;
CompatibilityMatrix cm2;
std::string error;
std::string xml;
xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"1\">\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>1.0-1</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
"</compatibility-matrix>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm1, xml))
<< gCompatibilityMatrixConverter.lastError();
xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"2\">\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>1.1-2</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>custom</instance>\n"
" </interface>\n"
" </hal>\n"
"</compatibility-matrix>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm2, xml))
<< gCompatibilityMatrixConverter.lastError();
EXPECT_TRUE(addAllHalsAsOptional(&cm1, &cm2, &error)) << error;
xml = gCompatibilityMatrixConverter(cm1, SerializeFlags::HALS_ONLY);
EXPECT_EQ(xml,
"<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"1\">\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>1.0-1</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
" <hal format=\"hidl\" optional=\"true\">\n"
" <name>android.hardware.foo</name>\n"
" <version>1.1-2</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>custom</instance>\n"
" </interface>\n"
" </hal>\n"
"</compatibility-matrix>\n");
}
TEST_F(LibVintfTest, AddRequiredHalOverlapInstance) {
CompatibilityMatrix cm1;
std::string error;
std::string xml;
xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"1\">\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>1.0</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" <instance>custom</instance>\n"
" </interface>\n"
" </hal>\n"
"</compatibility-matrix>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm1, xml))
<< gCompatibilityMatrixConverter.lastError();
{
// Test that 2.0 should be added to IFoo/default, so 1.0::IFoo/custom
// should be in a new <hal> tag
CompatibilityMatrix cm2;
xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"2\">\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>2.0</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
"</compatibility-matrix>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm2, xml))
<< gCompatibilityMatrixConverter.lastError();
EXPECT_TRUE(addAllHalsAsOptional(&cm1, &cm2, &error)) << error;
xml = gCompatibilityMatrixConverter(cm1, SerializeFlags::HALS_ONLY);
EXPECT_EQ(xml,
"<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"1\">\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>1.0</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>custom</instance>\n"
" </interface>\n"
" </hal>\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>1.0</version>\n"
" <version>2.0</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
"</compatibility-matrix>\n");
}
{
// Test that 2.0::IFoo/strong should be added as an optional <hal> tag.
CompatibilityMatrix cm2;
xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"2\">\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>2.0</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" <instance>strong</instance>\n"
" </interface>\n"
" </hal>\n"
"</compatibility-matrix>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm2, xml))
<< gCompatibilityMatrixConverter.lastError();
EXPECT_TRUE(addAllHalsAsOptional(&cm1, &cm2, &error)) << error;
xml = gCompatibilityMatrixConverter(cm1, SerializeFlags::HALS_ONLY);
EXPECT_EQ(xml,
"<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"1\">\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>1.0</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>custom</instance>\n"
" </interface>\n"
" </hal>\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>1.0</version>\n"
" <version>2.0</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
" <hal format=\"hidl\" optional=\"true\">\n"
" <name>android.hardware.foo</name>\n"
" <version>2.0</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>strong</instance>\n"
" </interface>\n"
" </hal>\n"
"</compatibility-matrix>\n");
}
}
TEST_F(LibVintfTest, AddRequiredHalOverlapInstanceSplit) {
CompatibilityMatrix cm1;
CompatibilityMatrix cm2;
std::string error;
std::string xml;
xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"1\">\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>1.0</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>1.0</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>custom</instance>\n"
" </interface>\n"
" </hal>\n"
"</compatibility-matrix>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm1, xml))
<< gCompatibilityMatrixConverter.lastError();
xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"2\">\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>2.0</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>2.0</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>strong</instance>\n"
" </interface>\n"
" </hal>\n"
"</compatibility-matrix>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm2, xml))
<< gCompatibilityMatrixConverter.lastError();
EXPECT_TRUE(addAllHalsAsOptional(&cm1, &cm2, &error)) << error;
xml = gCompatibilityMatrixConverter(cm1, SerializeFlags::HALS_ONLY);
EXPECT_EQ(
"<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"1\">\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>1.0</version>\n"
" <version>2.0</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>1.0</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>custom</instance>\n"
" </interface>\n"
" </hal>\n"
" <hal format=\"hidl\" optional=\"true\">\n"
" <name>android.hardware.foo</name>\n"
" <version>2.0</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>strong</instance>\n"
" </interface>\n"
" </hal>\n"
"</compatibility-matrix>\n",
xml);
}
TEST_F(LibVintfTest, AddOptionalXmlFile) {
CompatibilityMatrix cm1;
CompatibilityMatrix cm2;
std::string error;
std::string xml;
xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"1\">\n"
" <xmlfile format=\"xsd\" optional=\"true\">\n"
" <name>foo</name>\n"
" <version>1.0-2</version>\n"
" <path>/foo/bar/baz.xsd</path>\n"
" </xmlfile>\n"
"</compatibility-matrix>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm1, xml))
<< gCompatibilityMatrixConverter.lastError();
xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"2\">\n"
" <xmlfile format=\"xsd\" optional=\"true\">\n"
" <name>foo</name>\n"
" <version>1.1-3</version>\n"
" <path>/foo/bar/quux.xsd</path>\n"
" </xmlfile>\n"
"</compatibility-matrix>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm2, xml))
<< gCompatibilityMatrixConverter.lastError();
EXPECT_TRUE(addAllXmlFilesAsOptional(&cm1, &cm2, &error)) << error;
xml = gCompatibilityMatrixConverter(cm1, SerializeFlags::XMLFILES_ONLY);
EXPECT_EQ(xml,
"<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"1\">\n"
" <xmlfile format=\"xsd\" optional=\"true\">\n"
" <name>foo</name>\n"
" <version>1.0-2</version>\n"
" <path>/foo/bar/baz.xsd</path>\n"
" </xmlfile>\n"
" <xmlfile format=\"xsd\" optional=\"true\">\n"
" <name>foo</name>\n"
" <version>1.1-3</version>\n"
" <path>/foo/bar/quux.xsd</path>\n"
" </xmlfile>\n"
"</compatibility-matrix>\n");
}
TEST_F(LibVintfTest, VendorNdk) {
CompatibilityMatrix cm;
std::string error;
std::string xml;
xml =
"<compatibility-matrix version=\"1.0\" type=\"device\">\n"
" <vendor-ndk>\n"
" <version>P</version>\n"
" <library>libbase.so</library>\n"
" <library>libjpeg.so</library>\n"
" </vendor-ndk>\n"
"</compatibility-matrix>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm, xml))
<< gCompatibilityMatrixConverter.lastError();
EXPECT_EQ(xml, gCompatibilityMatrixConverter(cm));
EXPECT_EQ("P", cm.getVendorNdkVersion());
{
HalManifest manifest;
xml =
"<manifest version=\"1.0\" type=\"framework\">\n"
" <vendor-ndk>\n"
" <version>27</version>\n"
" <library>libbase.so</library>\n"
" <library>libjpeg.so</library>\n"
" </vendor-ndk>\n"
" <vendor-ndk>\n"
" <version>P</version>\n"
" <library>libbase.so</library>\n"
" <library>libjpeg.so</library>\n"
" <library>libtinyxml2.so</library>\n"
" </vendor-ndk>\n"
"</manifest>\n";
EXPECT_TRUE(gHalManifestConverter(&manifest, xml)) << gHalManifestConverter.lastError();
EXPECT_EQ(xml, gHalManifestConverter(manifest));
EXPECT_TRUE(manifest.checkCompatibility(cm, &error)) << error;
}
{
HalManifest manifest;
xml =
"<manifest version=\"1.0\" type=\"framework\">\n"
" <vendor-ndk>\n"
" <version>27</version>\n"
" <library>libbase.so</library>\n"
" <library>libjpeg.so</library>\n"
" </vendor-ndk>\n"
"</manifest>\n";
EXPECT_TRUE(gHalManifestConverter(&manifest, xml)) << gHalManifestConverter.lastError();
EXPECT_EQ(xml, gHalManifestConverter(manifest));
EXPECT_FALSE(manifest.checkCompatibility(cm, &error));
EXPECT_IN("Vndk version P is not supported.", error);
}
{
HalManifest manifest;
xml =
"<manifest version=\"1.0\" type=\"framework\">\n"
" <vendor-ndk>\n"
" <version>P</version>\n"
" <library>libbase.so</library>\n"
" </vendor-ndk>\n"
"</manifest>\n";
EXPECT_TRUE(gHalManifestConverter(&manifest, xml)) << gHalManifestConverter.lastError();
EXPECT_EQ(xml, gHalManifestConverter(manifest));
EXPECT_FALSE(manifest.checkCompatibility(cm, &error));
EXPECT_IN("Vndk libs incompatible for version P.", error);
EXPECT_IN("libjpeg.so", error);
}
}
TEST_F(LibVintfTest, MissingVendorNdkInMatrix) {
CompatibilityMatrix cm;
std::string xml;
std::string error;
xml = "<compatibility-matrix version=\"1.0\" type=\"device\"/>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm, xml))
<< gCompatibilityMatrixConverter.lastError();
{
HalManifest manifest;
xml = "<manifest version=\"1.0\" type=\"framework\"/>\n";
EXPECT_TRUE(gHalManifestConverter(&manifest, xml)) << gHalManifestConverter.lastError();
EXPECT_TRUE(manifest.checkCompatibility(cm, &error)) << error;
}
{
HalManifest manifest;
xml =
"<manifest version=\"1.0\" type=\"framework\">\n"
" <vendor-ndk>\n"
" <version>P</version>\n"
" <library>libbase.so</library>\n"
" </vendor-ndk>\n"
"</manifest>\n";
EXPECT_TRUE(gHalManifestConverter(&manifest, xml)) << gHalManifestConverter.lastError();
EXPECT_TRUE(manifest.checkCompatibility(cm, &error)) << error;
}
}
TEST_F(LibVintfTest, DuplicatedVendorNdkVersion) {
std::string error;
HalManifest manifest;
std::string xml =
"<manifest version=\"1.0\" type=\"framework\">\n"
" <vendor-ndk>\n"
" <version>27</version>\n"
" </vendor-ndk>\n"
" <vendor-ndk>\n"
" <version>27</version>\n"
" </vendor-ndk>\n"
"</manifest>\n";
EXPECT_FALSE(gHalManifestConverter(&manifest, xml));
EXPECT_EQ("Duplicated manifest.vendor-ndk.version 27", gHalManifestConverter.lastError());
}
TEST_F(LibVintfTest, ManifestHalOverride) {
HalManifest manifest;
std::string xml =
"<manifest version=\"1.0\" type=\"device\">\n"
" <hal format=\"hidl\" override=\"true\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <version>1.0</version>\n"
" </hal>\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.bar</name>\n"
" <transport>hwbinder</transport>\n"
" <version>1.0</version>\n"
" </hal>\n"
"</manifest>\n";
EXPECT_TRUE(gHalManifestConverter(&manifest, xml)) << gHalManifestConverter.lastError();
const auto& foo = getHals(manifest, "android.hardware.foo");
ASSERT_FALSE(foo.empty());
EXPECT_TRUE(foo.front()->isOverride());
const auto& bar = getHals(manifest, "android.hardware.bar");
ASSERT_FALSE(bar.empty());
EXPECT_FALSE(bar.front()->isOverride());
}
// Test functionality of override="true" tag
TEST_F(LibVintfTest, ManifestAddOverrideHalSimple) {
HalManifest manifest;
std::string xml = "<manifest version=\"1.0\" type=\"device\"/>\n";
EXPECT_TRUE(gHalManifestConverter(&manifest, xml)) << gHalManifestConverter.lastError();
HalManifest newManifest;
xml =
"<manifest version=\"1.0\" type=\"device\">\n"
" <hal format=\"hidl\" override=\"true\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <version>1.1</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
"</manifest>\n";
EXPECT_TRUE(gHalManifestConverter(&newManifest, xml)) << gHalManifestConverter.lastError();
manifest.addAllHals(&newManifest);
EXPECT_EQ(xml, gHalManifestConverter(manifest, SerializeFlags::HALS_NO_FQNAME));
}
TEST_F(LibVintfTest, ManifestAddOverrideHalSimpleOverride) {
HalManifest manifest;
std::string xml =
"<manifest version=\"1.0\" type=\"device\">\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <version>1.0</version>\n"
" </hal>\n"
"</manifest>\n";
EXPECT_TRUE(gHalManifestConverter(&manifest, xml)) << gHalManifestConverter.lastError();
HalManifest newManifest;
xml =
"<manifest version=\"1.0\" type=\"device\">\n"
" <hal format=\"hidl\" override=\"true\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <version>1.1</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
"</manifest>\n";
EXPECT_TRUE(gHalManifestConverter(&newManifest, xml)) << gHalManifestConverter.lastError();
manifest.addAllHals(&newManifest);
EXPECT_EQ(xml, gHalManifestConverter(manifest, SerializeFlags::HALS_NO_FQNAME));
}
// Existing major versions should be removed.
TEST_F(LibVintfTest, ManifestAddOverrideHalMultiVersion) {
HalManifest manifest;
std::string xml =
"<manifest version=\"1.0\" type=\"device\">\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <version>1.3</version>\n"
" <version>2.4</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>slot1</instance>\n"
" </interface>\n"
" </hal>\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.bar</name>\n"
" <transport>hwbinder</transport>\n"
" <version>1.3</version>\n"
" </hal>\n"
"</manifest>\n";
EXPECT_TRUE(gHalManifestConverter(&manifest, xml)) << gHalManifestConverter.lastError();
HalManifest newManifest;
xml =
"<manifest version=\"1.0\" type=\"device\">\n"
" <hal format=\"hidl\" override=\"true\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <version>1.1</version>\n"
" <version>3.1</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>slot2</instance>\n"
" </interface>\n"
" </hal>\n"
"</manifest>\n";
EXPECT_TRUE(gHalManifestConverter(&newManifest, xml)) << gHalManifestConverter.lastError();
manifest.addAllHals(&newManifest);
EXPECT_EQ(
"<manifest version=\"1.0\" type=\"device\">\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.bar</name>\n"
" <transport>hwbinder</transport>\n"
" <version>1.3</version>\n"
" </hal>\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <version>2.4</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>slot1</instance>\n"
" </interface>\n"
" </hal>\n"
" <hal format=\"hidl\" override=\"true\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <version>1.1</version>\n"
" <version>3.1</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>slot2</instance>\n"
" </interface>\n"
" </hal>\n"
"</manifest>\n",
gHalManifestConverter(manifest, SerializeFlags::HALS_NO_FQNAME));
}
TEST_F(LibVintfTest, ManifestAddOverrideHalMultiVersion2) {
HalManifest manifest;
std::string xml =
"<manifest version=\"1.0\" type=\"device\">\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <version>1.3</version>\n"
" <version>2.4</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>slot1</instance>\n"
" </interface>\n"
" </hal>\n"
"</manifest>\n";
EXPECT_TRUE(gHalManifestConverter(&manifest, xml)) << gHalManifestConverter.lastError();
HalManifest newManifest;
xml =
"<manifest version=\"1.0\" type=\"device\">\n"
" <hal format=\"hidl\" override=\"true\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <version>1.1</version>\n"
" <version>2.1</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>slot2</instance>\n"
" </interface>\n"
" </hal>\n"
"</manifest>\n";
EXPECT_TRUE(gHalManifestConverter(&newManifest, xml)) << gHalManifestConverter.lastError();
manifest.addAllHals(&newManifest);
EXPECT_EQ(xml, gHalManifestConverter(manifest, SerializeFlags::HALS_NO_FQNAME));
}
// if no <versions>, remove all existing <hal> with given <name>.
TEST_F(LibVintfTest, ManifestAddOverrideHalRemoveAll) {
HalManifest manifest;
std::string xml =
"<manifest version=\"1.0\" type=\"device\">\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <version>1.3</version>\n"
" <version>2.4</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>slot1</instance>\n"
" </interface>\n"
" </hal>\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <version>3.1</version>\n"
" <version>4.3</version>\n"
" <interface>\n"
" <name>IBar</name>\n"
" <instance>slot2</instance>\n"
" </interface>\n"
" </hal>\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.bar</name>\n"
" <transport>hwbinder</transport>\n"
" <version>1.3</version>\n"
" </hal>\n"
"</manifest>\n";
EXPECT_TRUE(gHalManifestConverter(&manifest, xml)) << gHalManifestConverter.lastError();
HalManifest newManifest;
xml =
"<manifest version=\"1.0\" type=\"device\">\n"
" <hal format=\"hidl\" override=\"true\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" </hal>\n"
"</manifest>\n";
EXPECT_TRUE(gHalManifestConverter(&newManifest, xml)) << gHalManifestConverter.lastError();
manifest.addAllHals(&newManifest);
EXPECT_EQ(
"<manifest version=\"1.0\" type=\"device\">\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.bar</name>\n"
" <transport>hwbinder</transport>\n"
" <version>1.3</version>\n"
" </hal>\n"
" <hal format=\"hidl\" override=\"true\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" </hal>\n"
"</manifest>\n",
gHalManifestConverter(manifest, SerializeFlags::HALS_ONLY));
}
// Make sure missing tags in old VINTF files does not cause incompatibilities.
TEST_F(LibVintfTest, Empty) {
CompatibilityMatrix cm;
HalManifest manifest;
std::string xml;
std::string error;
xml = "<compatibility-matrix version=\"1.0\" type=\"device\"/>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm, xml))
<< gCompatibilityMatrixConverter.lastError();
xml = "<manifest version=\"1.0\" type=\"framework\"/>\n";
EXPECT_TRUE(gHalManifestConverter(&manifest, xml)) << gHalManifestConverter.lastError();
EXPECT_TRUE(manifest.checkCompatibility(cm, &error)) << error;
}
TEST_F(LibVintfTest, SystemSdk) {
CompatibilityMatrix cm;
std::string xml;
std::string error;
xml =
"<compatibility-matrix version=\"1.0\" type=\"device\">\n"
" <system-sdk>\n"
" <version>1</version>\n"
" <version>P</version>\n"
" </system-sdk>\n"
"</compatibility-matrix>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm, xml))
<< gCompatibilityMatrixConverter.lastError();
EXPECT_EQ(xml, gCompatibilityMatrixConverter(cm, SerializeFlags::SSDK_ONLY));
{
HalManifest manifest;
xml =
"<manifest version=\"1.0\" type=\"framework\">\n"
" <system-sdk>\n"
" <version>1</version>\n"
" <version>P</version>\n"
" </system-sdk>\n"
"</manifest>\n";
EXPECT_TRUE(gHalManifestConverter(&manifest, xml)) << gHalManifestConverter.lastError();
EXPECT_EQ(xml, gHalManifestConverter(manifest, SerializeFlags::SSDK_ONLY));
EXPECT_TRUE(manifest.checkCompatibility(cm, &error)) << error;
}
{
HalManifest manifest;
xml =
"<manifest version=\"1.0\" type=\"framework\">\n"
" <system-sdk>\n"
" <version>1</version>\n"
" <version>3</version>\n"
" <version>P</version>\n"
" </system-sdk>\n"
"</manifest>\n";
EXPECT_TRUE(gHalManifestConverter(&manifest, xml)) << gHalManifestConverter.lastError();
EXPECT_TRUE(manifest.checkCompatibility(cm, &error));
}
{
HalManifest manifest;
xml =
"<manifest version=\"1.0\" type=\"framework\">\n"
" <system-sdk>\n"
" <version>1</version>\n"
" </system-sdk>\n"
"</manifest>\n";
EXPECT_TRUE(gHalManifestConverter(&manifest, xml)) << gHalManifestConverter.lastError();
EXPECT_FALSE(manifest.checkCompatibility(cm, &error));
EXPECT_TRUE(error.find("System SDK") != std::string::npos) << error;
}
}
TEST_F(LibVintfTest, ManifestLastError) {
HalManifest e;
// Set mLastError to something else before testing.
EXPECT_FALSE(gHalManifestConverter(&e, "<manifest/>"));
EXPECT_NE("Not a valid XML", gHalManifestConverter.lastError());
std::string error;
std::string prevError = gHalManifestConverter.lastError();
EXPECT_FALSE(gHalManifestConverter(&e, "", &error));
EXPECT_EQ("Not a valid XML", error);
EXPECT_EQ(prevError, gHalManifestConverter.lastError()) << "lastError() should not be modified";
}
TEST_F(LibVintfTest, MatrixLastError) {
CompatibilityMatrix e;
// Set mLastError to something else before testing.
EXPECT_FALSE(gCompatibilityMatrixConverter(&e, "<compatibility-matrix/>"));
EXPECT_NE("Not a valid XML", gCompatibilityMatrixConverter.lastError());
std::string error;
std::string prevError = gCompatibilityMatrixConverter.lastError();
EXPECT_FALSE(gCompatibilityMatrixConverter(&e, "", &error));
EXPECT_EQ("Not a valid XML", error);
EXPECT_EQ(prevError, gCompatibilityMatrixConverter.lastError())
<< "lastError() should not be modified";
}
TEST_F(LibVintfTest, MatrixDetailErrorMsg) {
std::string error;
std::string xml;
HalManifest manifest;
xml =
"<manifest version=\"1.0\" type=\"device\" target-level=\"103\">\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <version>1.0</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
"</manifest>\n";
ASSERT_TRUE(gHalManifestConverter(&manifest, xml, &error)) << error;
{
CompatibilityMatrix cm;
xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"100\">\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>1.2-3</version>\n"
" <version>4.5</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" <instance>slot1</instance>\n"
" </interface>\n"
" <interface>\n"
" <name>IBar</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
"</compatibility-matrix>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm, xml, &error)) << error;
EXPECT_FALSE(manifest.checkCompatibility(cm, &error));
EXPECT_IN("Manifest level = 103", error)
EXPECT_IN("Matrix level = 100", error)
EXPECT_IN(
"android.hardware.foo:\n"
" required: \n"
" (@1.2-3::IBar/default AND @1.2-3::IFoo/default AND @1.2-3::IFoo/slot1) OR\n"
" (@4.5::IBar/default AND @4.5::IFoo/default AND @4.5::IFoo/slot1)\n"
" provided: @1.0::IFoo/default",
error);
}
{
CompatibilityMatrix cm;
xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\">\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>1.2-3</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" <instance>slot1</instance>\n"
" </interface>\n"
" </hal>\n"
"</compatibility-matrix>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm, xml, &error)) << error;
EXPECT_FALSE(manifest.checkCompatibility(cm, &error));
EXPECT_IN(
"android.hardware.foo:\n"
" required: (@1.2-3::IFoo/default AND @1.2-3::IFoo/slot1)\n"
" provided: @1.0::IFoo/default",
error);
}
// the most frequent use case.
{
CompatibilityMatrix cm;
xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\">\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>1.2-3</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
"</compatibility-matrix>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm, xml, &error)) << error;
EXPECT_FALSE(manifest.checkCompatibility(cm, &error));
EXPECT_IN(
"android.hardware.foo:\n"
" required: @1.2-3::IFoo/default\n"
" provided: @1.0::IFoo/default",
error);
}
}
TEST_F(LibVintfTest, DisabledHal) {
std::string error;
std::string xml;
HalManifest manifest;
xml =
"<manifest version=\"1.0\" type=\"framework\">\n"
" <hal format=\"hidl\" override=\"true\">\n"
" <transport>hwbinder</transport>\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" </hal>\n"
" <hal format=\"hidl\" override=\"true\">\n"
" <name>android.hardware.bar</name>\n"
" <transport>hwbinder</transport>\n"
" <fqname>@1.1::IFoo/custom</fqname>\n"
" </hal>\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.baz</name>\n"
" <transport>hwbinder</transport>\n"
" </hal>\n"
"</manifest>\n";
ASSERT_TRUE(gHalManifestConverter(&manifest, xml, &error)) << error;
auto foo = getHals(manifest, "android.hardware.foo");
ASSERT_EQ(1u, foo.size());
EXPECT_TRUE(foo.front()->isDisabledHal());
auto bar = getHals(manifest, "android.hardware.bar");
ASSERT_EQ(1u, bar.size());
EXPECT_FALSE(bar.front()->isDisabledHal());
auto baz = getHals(manifest, "android.hardware.baz");
ASSERT_EQ(1u, baz.size());
EXPECT_FALSE(baz.front()->isDisabledHal());
}
TEST_F(LibVintfTest, FqNameValid) {
std::string error;
std::string xml;
CompatibilityMatrix cm;
xml =
"<compatibility-matrix version=\"1.0\" type=\"device\">\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>1.0</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>1.1</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>custom</instance>\n"
" </interface>\n"
" </hal>\n"
"</compatibility-matrix>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&cm, xml, &error)) << error;
{
HalManifest manifest;
xml =
"<manifest version=\"1.0\" type=\"framework\">\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <version>1.0</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" <instance>custom</instance>\n"
" </interface>\n"
" <fqname>@1.1::IFoo/custom</fqname>\n"
" </hal>\n"
"</manifest>\n";
ASSERT_TRUE(gHalManifestConverter(&manifest, xml, &error)) << error;
EXPECT_TRUE(manifest.checkCompatibility(cm, &error)) << error;
EXPECT_EQ(Transport::HWBINDER,
manifest.getTransport("android.hardware.foo", {1, 1}, "IFoo", "custom"));
}
{
HalManifest manifest;
xml =
"<manifest version=\"1.0\" type=\"framework\">\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <fqname>@1.0::IFoo/default</fqname>\n"
" <fqname>@1.1::IFoo/custom</fqname>\n"
" </hal>\n"
"</manifest>\n";
ASSERT_TRUE(gHalManifestConverter(&manifest, xml, &error)) << error;
EXPECT_TRUE(manifest.checkCompatibility(cm, &error)) << error;
}
{
HalManifest manifest;
xml =
"<manifest version=\"1.0\" type=\"framework\">\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <version>1.0</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" <instance>custom</instance>\n"
" </interface>\n"
" </hal>\n"
"</manifest>\n";
ASSERT_TRUE(gHalManifestConverter(&manifest, xml, &error)) << error;
EXPECT_FALSE(manifest.checkCompatibility(cm, &error));
EXPECT_IN(
"android.hardware.foo:\n"
" required: @1.1::IFoo/custom\n"
" provided: \n"
" @1.0::IFoo/custom\n"
" @1.0::IFoo/default",
error);
}
{
HalManifest manifest;
xml =
"<manifest version=\"1.0\" type=\"framework\">\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <fqname>@1.0::IFoo/default</fqname>\n"
" <fqname>@1.0::IFoo/custom</fqname>\n"
" </hal>\n"
"</manifest>\n";
ASSERT_TRUE(gHalManifestConverter(&manifest, xml, &error)) << error;
EXPECT_IN(
"android.hardware.foo:\n"
" required: @1.1::IFoo/custom\n"
" provided: \n"
" @1.0::IFoo/custom\n"
" @1.0::IFoo/default",
error);
}
}
TEST_F(LibVintfTest, FqNameInvalid) {
std::string error;
std::string xml;
ManifestHal hal;
xml =
"<hal format=\"hidl\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <fqname>@1.1::IFoo/custom</fqname>\n"
"</hal>\n";
EXPECT_TRUE(gManifestHalConverter(&hal, xml, &error)) << error;
xml =
"<hal format=\"hidl\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <fqname>1.1::IFoo/custom</fqname>\n"
"</hal>\n";
ASSERT_FALSE(gManifestHalConverter(&hal, xml, &error));
EXPECT_IN("Could not parse text \"1.1::IFoo/custom\" in element <fqname>", error);
xml =
"<hal format=\"hidl\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <fqname>android.hardware.foo@1.1::IFoo/custom</fqname>\n"
"</hal>\n";
ASSERT_FALSE(gManifestHalConverter(&hal, xml, &error));
EXPECT_IN("Should not specify package", error);
xml =
"<hal format=\"hidl\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <fqname>IFoo/custom</fqname>\n"
"</hal>\n";
ASSERT_FALSE(gManifestHalConverter(&hal, xml, &error));
EXPECT_IN("Should specify version", error);
xml =
"<hal format=\"hidl\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <fqname>@1.0::IFoo</fqname>\n"
"</hal>\n";
ASSERT_FALSE(gManifestHalConverter(&hal, xml, &error));
EXPECT_IN("Should specify instance", error);
xml =
"<hal format=\"hidl\">\n"
" <name>n07 4 v4l1d 1n73rf4c3</name>\n"
" <transport>hwbinder</transport>\n"
" <fqname>@1.0::IFoo/custom</fqname>\n"
"</hal>\n";
ASSERT_FALSE(gManifestHalConverter(&hal, xml, &error));
EXPECT_IN("Cannot create FqInstance", error);
EXPECT_IN("n07 4 v4l1d 1n73rf4c3", error);
}
TEST_F(LibVintfTest, RegexInstanceValid) {
CompatibilityMatrix matrix;
std::string error;
std::string xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\">\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>1.0</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <regex-instance>legacy/[0-9]+</regex-instance>\n"
" <regex-instance>slot[0-9]+</regex-instance>\n"
" <regex-instance>.*</regex-instance>\n"
" </interface>\n"
" </hal>\n"
"</compatibility-matrix>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&matrix, xml, &error)) << error;
}
TEST_F(LibVintfTest, RegexInstanceInvalid) {
CompatibilityMatrix matrix;
std::string error;
std::string xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\">\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>1.0</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <regex-instance>e{1,2,3}</regex-instance>\n"
" <regex-instance>*</regex-instance>\n"
" <regex-instance>+</regex-instance>\n"
" <regex-instance>[0-9]+</regex-instance>\n"
" <regex-instance>[0-9]+</regex-instance>\n"
" </interface>\n"
" </hal>\n"
"</compatibility-matrix>\n";
EXPECT_FALSE(gCompatibilityMatrixConverter(&matrix, xml, &error));
EXPECT_IN("Invalid regular expression 'e{1,2,3}'", error);
EXPECT_IN("Invalid regular expression '*'", error);
EXPECT_IN("Invalid regular expression '+'", error);
EXPECT_IN("Duplicated regex-instance '[0-9]+'", error);
}
TEST_F(LibVintfTest, RegexInstanceCompat) {
CompatibilityMatrix matrix;
std::string error;
std::string xml =
"<compatibility-matrix version=\"1.0\" type=\"framework\">\n"
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>1.0</version>\n"
" <version>3.1-2</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" <regex-instance>legacy/[0-9]+</regex-instance>\n"
" </interface>\n"
" </hal>\n"
" <sepolicy>\n"
" <kernel-sepolicy-version>0</kernel-sepolicy-version>\n"
" <sepolicy-version>0.0</sepolicy-version>\n"
" </sepolicy>\n"
"</compatibility-matrix>\n";
EXPECT_TRUE(gCompatibilityMatrixConverter(&matrix, xml))
<< gCompatibilityMatrixConverter.lastError();
{
std::string xml =
"<manifest version=\"1.0\" type=\"device\">\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <version>1.0</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" <instance>legacy/0</instance>\n"
" <instance>legacy/1</instance>\n"
" </interface>\n"
" </hal>\n"
"</manifest>\n";
HalManifest manifest;
EXPECT_TRUE(gHalManifestConverter(&manifest, xml));
EXPECT_TRUE(manifest.checkCompatibility(matrix, &error)) << error;
auto unused = checkUnusedHals(manifest, matrix);
EXPECT_TRUE(unused.empty())
<< "Contains unused HALs: " << android::base::Join(unused, "\n");
}
{
std::string xml =
"<manifest version=\"1.0\" type=\"device\">\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <version>1.0</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" <instance>legacy0</instance>\n"
" <instance>nonmatch/legacy/0</instance>\n"
" <instance>legacy/0/nonmatch</instance>\n"
" </interface>\n"
" </hal>\n"
"</manifest>\n";
HalManifest manifest;
EXPECT_TRUE(gHalManifestConverter(&manifest, xml));
EXPECT_FALSE(manifest.checkCompatibility(matrix, &error))
<< "Should not be compatible because no legacy/[0-9]+ is provided.";
auto unused = checkUnusedHals(manifest, matrix);
EXPECT_EQ((std::set<std::string>{"android.hardware.foo@1.0::IFoo/nonmatch/legacy/0",
"android.hardware.foo@1.0::IFoo/legacy/0/nonmatch",
"android.hardware.foo@1.0::IFoo/legacy0"}),
unused);
}
}
TEST_F(LibVintfTest, Regex) {
details::Regex regex;
EXPECT_FALSE(regex.compile("+"));
EXPECT_FALSE(regex.compile("*"));
ASSERT_TRUE(regex.compile("legacy/[0-9]+"));
EXPECT_TRUE(regex.matches("legacy/0"));
EXPECT_TRUE(regex.matches("legacy/000"));
EXPECT_FALSE(regex.matches("legacy/"));
EXPECT_FALSE(regex.matches("ssslegacy/0"));
EXPECT_FALSE(regex.matches("legacy/0sss"));
}
TEST_F(LibVintfTest, ManifestGetHalNamesAndVersions) {
HalManifest vm = testDeviceManifest();
EXPECT_EQ(vm.getHalNamesAndVersions(),
std::set<std::string>({"android.hardware.camera@2.0", "android.hardware.nfc@1.0"}));
}
TEST_F(LibVintfTest, KernelInfo) {
KernelInfo ki = testKernelInfo();
EXPECT_EQ(
"<kernel version=\"3.18.31\">\n"
" <config>\n"
" <key>CONFIG_64BIT</key>\n"
" <value>y</value>\n"
" </config>\n"
" <config>\n"
" <key>CONFIG_ANDROID_BINDER_DEVICES</key>\n"
" <value>\"binder,hwbinder\"</value>\n"
" </config>\n"
" <config>\n"
" <key>CONFIG_ARCH_MMAP_RND_BITS</key>\n"
" <value>24</value>\n"
" </config>\n"
" <config>\n"
" <key>CONFIG_BUILD_ARM64_APPENDED_DTB_IMAGE_NAMES</key>\n"
" <value>\"\"</value>\n"
" </config>\n"
" <config>\n"
" <key>CONFIG_ILLEGAL_POINTER_VALUE</key>\n"
" <value>0xdead000000000000</value>\n"
" </config>\n"
"</kernel>\n",
gKernelInfoConverter(ki, SerializeFlags::NO_TAGS.enableKernelConfigs()));
}
TEST_F(LibVintfTest, ManifestAddAllDeviceManifest) {
std::string xml1 = "<manifest version=\"1.0\" type=\"device\" />\n";
std::string xml2 =
"<manifest version=\"1.0\" type=\"device\" target-level=\"3\">\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <fqname>@1.0::IFoo/default</fqname>\n"
" </hal>\n"
" <sepolicy>\n"
" <version>25.5</version>\n"
" </sepolicy>\n"
" <kernel version=\"3.18.31\">\n"
" <config>\n"
" <key>CONFIG_64BIT</key>\n"
" <value>y</value>\n"
" </config>\n"
" </kernel>\n"
" <xmlfile>\n"
" <name>media_profile</name>\n"
" <version>1.0</version>\n"
" </xmlfile>\n"
"</manifest>\n";
std::string error;
HalManifest manifest1;
ASSERT_TRUE(gHalManifestConverter(&manifest1, xml1, &error)) << error;
HalManifest manifest2;
ASSERT_TRUE(gHalManifestConverter(&manifest2, xml2, &error)) << error;
ASSERT_TRUE(manifest1.addAll(&manifest2, &error)) << error;
EXPECT_EQ(xml2, gHalManifestConverter(manifest1));
}
TEST_F(LibVintfTest, ManifestAddAllFrameworkManifest) {
std::string xml1 = "<manifest version=\"1.0\" type=\"framework\" />\n";
std::string xml2 =
"<manifest version=\"1.0\" type=\"framework\">\n"
" <hal format=\"hidl\">\n"
" <name>android.hardware.foo</name>\n"
" <transport>hwbinder</transport>\n"
" <fqname>@1.0::IFoo/default</fqname>\n"
" </hal>\n"
" <vendor-ndk>\n"
" <version>P</version>\n"
" <library>libbase.so</library>\n"
" </vendor-ndk>\n"
" <system-sdk>\n"
" <version>1</version>\n"
" </system-sdk>\n"
" <xmlfile>\n"
" <name>media_profile</name>\n"
" <version>1.0</version>\n"
" </xmlfile>\n"
"</manifest>\n";
std::string error;
HalManifest manifest1;
ASSERT_TRUE(gHalManifestConverter(&manifest1, xml1, &error)) << error;
HalManifest manifest2;
ASSERT_TRUE(gHalManifestConverter(&manifest2, xml2, &error)) << error;
ASSERT_TRUE(manifest1.addAll(&manifest2, &error)) << error;
EXPECT_EQ(xml2, gHalManifestConverter(manifest1));
}
TEST_F(LibVintfTest, ManifestAddAllConflictLevel) {
std::string xml1 = "<manifest version=\"1.0\" type=\"device\" target-level=\"2\" />\n";
std::string xml2 = "<manifest version=\"1.0\" type=\"device\" target-level=\"3\" />\n";
std::string error;
HalManifest manifest1;
ASSERT_TRUE(gHalManifestConverter(&manifest1, xml1, &error)) << error;
HalManifest manifest2;
ASSERT_TRUE(gHalManifestConverter(&manifest2, xml2, &error)) << error;
ASSERT_FALSE(manifest1.addAll(&manifest2, &error));
EXPECT_IN("Conflicting target-level", error);
}
TEST_F(LibVintfTest, ManifestAddAllConflictSepolicy) {
std::string xml1 =
"<manifest version=\"1.0\" type=\"device\">\n"
" <sepolicy>\n"
" <version>25.5</version>\n"
" </sepolicy>\n"
"</manifest>\n";
std::string xml2 =
"<manifest version=\"1.0\" type=\"device\">\n"
" <sepolicy>\n"
" <version>30.0</version>\n"
" </sepolicy>\n"
"</manifest>\n";
std::string error;
HalManifest manifest1;
ASSERT_TRUE(gHalManifestConverter(&manifest1, xml1, &error)) << error;
HalManifest manifest2;
ASSERT_TRUE(gHalManifestConverter(&manifest2, xml2, &error)) << error;
ASSERT_FALSE(manifest1.addAll(&manifest2, &error));
EXPECT_IN("Conflicting sepolicy version", error);
}
TEST_F(LibVintfTest, ManifestAddAllConflictKernel) {
std::string xml1 =
"<manifest version=\"1.0\" type=\"device\">\n"
" <kernel version=\"3.18.0\" />\n"
"</manifest>\n";
std::string xml2 =
"<manifest version=\"1.0\" type=\"device\">\n"
" <kernel version=\"3.18.1\" />\n"
"</manifest>\n";
std::string error;
HalManifest manifest1;
ASSERT_TRUE(gHalManifestConverter(&manifest1, xml1, &error)) << error;
HalManifest manifest2;
ASSERT_TRUE(gHalManifestConverter(&manifest2, xml2, &error)) << error;
ASSERT_FALSE(manifest1.addAll(&manifest2, &error));
EXPECT_IN("Conflicting kernel", error);
}
struct FrameworkCompatibilityMatrixCombineTest : public LibVintfTest {
virtual void SetUp() override {
matrices = {
{"compatibility_matrix.1_1.xml", CompatibilityMatrix{}},
{"compatibility_matrix.1_2.xml", CompatibilityMatrix{}},
};
}
// Access to private methods.
std::unique_ptr<CompatibilityMatrix> combine(Level deviceLevel,
std::vector<Named<CompatibilityMatrix>>* matrices,
std::string* error) {
return CompatibilityMatrix::combine(deviceLevel, matrices, error);
}
std::vector<Named<CompatibilityMatrix>> matrices;
std::string error;
};
// Combining framework compatibility matrix with conflicting minlts fails
TEST_F(FrameworkCompatibilityMatrixCombineTest, ConflictMinlts) {
ASSERT_TRUE(gCompatibilityMatrixConverter(
&matrices[0].object,
"<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"1\">\n"
" <kernel version=\"3.18.5\" />\n"
"</compatibility-matrix>\n",
&error))
<< error;
ASSERT_TRUE(gCompatibilityMatrixConverter(
&matrices[1].object,
"<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"1\">\n"
" <kernel version=\"3.18.6\" />\n"
"</compatibility-matrix>\n",
&error))
<< error;
auto combined = combine(Level{1}, &matrices, &error);
ASSERT_EQ(nullptr, combined) << gCompatibilityMatrixConverter(*combined);
EXPECT_IN("Kernel version mismatch", error);
}
// <kernel> without <conditions> always comes first
TEST_F(FrameworkCompatibilityMatrixCombineTest, KernelNoConditions) {
std::string conditionedKernel =
" <kernel version=\"3.18.5\">\n"
" <conditions>\n"
" <config>\n"
" <key>CONFIG_ARM</key>\n"
" <value type=\"tristate\">y</value>\n"
" </config>\n"
" </conditions>\n"
" <config>\n"
" <key>CONFIG_FOO</key>\n"
" <value type=\"tristate\">y</value>\n"
" </config>\n"
" </kernel>\n";
std::string simpleKernel =
" <kernel version=\"3.18.5\">\n"
" <config>\n"
" <key>CONFIG_BAR</key>\n"
" <value type=\"tristate\">y</value>\n"
" </config>\n"
" </kernel>\n";
ASSERT_TRUE(gCompatibilityMatrixConverter(
&matrices[0].object,
"<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"1\">\n"
" <kernel version=\"3.18.5\" />\n" +
conditionedKernel + "</compatibility-matrix>\n",
&error))
<< error;
ASSERT_TRUE(gCompatibilityMatrixConverter(
&matrices[1].object,
"<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"1\">\n" + simpleKernel +
"</compatibility-matrix>\n",
&error))
<< error;
auto combined = combine(Level{1}, &matrices, &error);
ASSERT_NE(nullptr, combined);
EXPECT_EQ("", error);
EXPECT_EQ("<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"1\">\n" +
simpleKernel + conditionedKernel + "</compatibility-matrix>\n",
gCompatibilityMatrixConverter(*combined));
}
// Combining framework compatibility matrix with conflicting sepolicy fails
TEST_F(FrameworkCompatibilityMatrixCombineTest, ConflictSepolicy) {
ASSERT_TRUE(gCompatibilityMatrixConverter(
&matrices[0].object,
"<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"1\">\n"
" <sepolicy>\n"
" <kernel-sepolicy-version>30</kernel-sepolicy-version>\n"
" </sepolicy>\n"
"</compatibility-matrix>\n",
&error))
<< error;
ASSERT_TRUE(gCompatibilityMatrixConverter(
&matrices[1].object,
"<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"1\">\n"
" <sepolicy>\n"
" <kernel-sepolicy-version>29</kernel-sepolicy-version>\n"
" </sepolicy>\n"
"</compatibility-matrix>\n",
&error))
<< error;
auto combined = combine(Level{1}, &matrices, &error);
ASSERT_EQ(nullptr, combined) << gCompatibilityMatrixConverter(*combined);
EXPECT_IN("<sepolicy> is already defined", error);
}
// Combining framework compatibility matrix with conflicting avb fails
TEST_F(FrameworkCompatibilityMatrixCombineTest, ConflictAvb) {
ASSERT_TRUE(gCompatibilityMatrixConverter(
&matrices[0].object,
"<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"1\">\n"
" <avb>\n"
" <vbmeta-version>1.1</vbmeta-version>\n"
" </avb>\n"
"</compatibility-matrix>\n",
&error))
<< error;
ASSERT_TRUE(gCompatibilityMatrixConverter(
&matrices[1].object,
"<compatibility-matrix version=\"1.0\" type=\"framework\" level=\"1\">\n"
" <avb>\n"
" <vbmeta-version>1.0</vbmeta-version>\n"
" </avb>\n"
"</compatibility-matrix>\n",
&error))
<< error;
auto combined = combine(Level{1}, &matrices, &error);
ASSERT_EQ(nullptr, combined) << gCompatibilityMatrixConverter(*combined);
EXPECT_IN("<avb><vbmeta-version> is already defined", error);
}
struct DeviceCompatibilityMatrixCombineTest : public LibVintfTest {
virtual void SetUp() override {
matrices = {
{"compatibility_matrix.1.xml", CompatibilityMatrix{}},
{"compatibility_matrix.2.xml", CompatibilityMatrix{}},
};
}
// Access to private methods.
std::unique_ptr<CompatibilityMatrix> combine(std::vector<Named<CompatibilityMatrix>>* matrices,
std::string* error) {
return CompatibilityMatrix::combineDeviceMatrices(matrices, error);
}
std::vector<Named<CompatibilityMatrix>> matrices;
std::string error;
};
TEST_F(DeviceCompatibilityMatrixCombineTest, Success) {
std::string head{"<compatibility-matrix version=\"1.0\" type=\"device\">\n"};
std::string tail{"</compatibility-matrix>\n"};
std::string halFoo{
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.foo</name>\n"
" <version>1.0</version>\n"
" <interface>\n"
" <name>IFoo</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"};
std::string halBar{
" <hal format=\"hidl\" optional=\"false\">\n"
" <name>android.hardware.bar</name>\n"
" <version>1.0</version>\n"
" <interface>\n"
" <name>IBar</name>\n"
" <instance>default</instance>\n"
" </interface>\n"
" </hal>\n"};
ASSERT_TRUE(gCompatibilityMatrixConverter(&matrices[0].object, head + halFoo + tail, &error))
<< error;
ASSERT_TRUE(gCompatibilityMatrixConverter(&matrices[1].object, head + halBar + tail, &error))
<< error;
auto combined = combine(&matrices, &error);
ASSERT_NE(nullptr, combined) << error;
EXPECT_EQ("", error);
auto combinedXml = gCompatibilityMatrixConverter(*combined);
EXPECT_IN(halFoo, combinedXml);
EXPECT_IN(halBar, combinedXml);
}
TEST_F(DeviceCompatibilityMatrixCombineTest, ConflictVendorNdk) {
std::string vendorNdkP{
"<compatibility-matrix version=\"1.0\" type=\"device\">\n"
" <vendor-ndk>\n"
" <version>P</version>\n"
" </vendor-ndk>\n"
"</compatibility-matrix>\n"};
std::string vendorNdkQ{
"<compatibility-matrix version=\"1.0\" type=\"device\">\n"
" <vendor-ndk>\n"
" <version>Q</version>\n"
" </vendor-ndk>\n"
"</compatibility-matrix>\n"};
ASSERT_TRUE(gCompatibilityMatrixConverter(&matrices[0].object, vendorNdkP, &error)) << error;
ASSERT_TRUE(gCompatibilityMatrixConverter(&matrices[1].object, vendorNdkQ, &error)) << error;
auto combined = combine(&matrices, &error);
ASSERT_EQ(nullptr, combined) << gCompatibilityMatrixConverter(*combined);
EXPECT_IN("<vendor-ndk> is already defined", error);
}
} // namespace vintf
} // namespace android
int main(int argc, char **argv) {
::testing::InitGoogleTest(&argc, argv);
return RUN_ALL_TESTS();
}