Google Git
Sign in
android / platform / system / libvintf / 593a76995ae1c93173228540248953a604802291
commit593a76995ae1c93173228540248953a604802291[log] [tgz]
authorYifan Hong <elsk@google.com>Wed Jun 03 14:57:30 2020 -0700
committerElliott Hughes <enh@google.com>Thu Jun 04 19:07:39 2020 +0000
tree6fecd6e087e91adc8da45b76d41465694ecbaf4c
parentb6a86ff14f6e48b8f152929a6c883b483564648d [diff]
Stop using C++ streams.

libvintf used to use std::ifstream to read files but incorrectly
assumed that a non-zero value of errno implied failure. Because the
implementation retries reads that fail with EAGAIN, this isn't true:
a successful operation could still result in errno being set to EAGAIN.

Use ReadFileToString from libbase which gives a clear boolean
success/failure signal.

Test: stress test
Bug: 156701275
Change-Id: Ieedba32f61a76ffcf96f7c06d89df70b5f94813b
1 file changed
tree: 6fecd6e087e91adc8da45b76d41465694ecbaf4c
  1. analyze_matrix/
  2. include/
  3. include-test/
  4. libaidlvintf_test_helper/
  5. test/
  6. xsd/
  7. .clang-format
  8. Android.bp
  9. Android.mk
  10. assemble_vintf_main.cpp
  11. AssembleVintf.cpp
  12. check_vintf.cpp
  13. CompatibilityMatrix.cpp
  14. constants-private.h
  15. FileSystem.cpp
  16. HalInterface.cpp
  17. HalManifest.cpp
  18. KernelConfigParser.cpp
  19. KernelConfigTypedValue.cpp
  20. KernelInfo.cpp
  21. main.cpp
  22. ManifestHal.cpp
  23. ManifestInstance.cpp
  24. MatrixHal.cpp
  25. MatrixInstance.cpp
  26. MatrixKernel.cpp
  27. NOTICE
  28. OWNERS
  29. parse_string.cpp
  30. parse_xml.cpp
  31. PREUPLOAD.cfg
  32. PropertyFetcher.cpp
  33. Regex.cpp
  34. RuntimeInfo-host.cpp
  35. RuntimeInfo-target.cpp
  36. RuntimeInfo.cpp
  37. SystemSdk.cpp
  38. TEST_MAPPING
  39. TransportArch.cpp
  40. utils.h
  41. VintfObject.cpp
  42. XmlFile.cpp