tree 8170b985027bad54f2bfcc85f891b8b889fc3c7a
parent 7706f49b24f10d6943ca0c6ea516d959e066b802
author Jiyong Park <jiyong@google.com> 1639981078 +0900
committer Jiyong Park <jiyong@google.com> 1640917189 +0900

ASSERT/EXPECT_RESULT_OK follows gtest style.

Like other macros ASSERT_* and EXPECT_* from gtest, ASSERT_RESULT_OK and
EXPECT_RESULT_OK now accepts additional error message via "<<" operator
at the end. e.g.

ASSERT_RESULT_OK(stmt) << "custom message";

This change also fixes a bug that "tmp.ok()" is printed instead of the
expression that is given to the macro.

In addition, this change removes CHECK_RESULT_OK which is not used
anywhere.  It has had a potential problem due to its dependency to
android-base/logging.h because that header is not available everywhere.

Test: build and run the following statement.
ASSERT_RESULT_OK([]() -> Result<int> { return Error(EPERM) << "custom error"; }()) << "assertion message";

It builds, and the output is ...

system/libbase/result_test.cpp:604: Failure
Failed
Value of: []() -> Result<int> { return Error(EPERM) << "custom error"; }()
  Actual: custom error: Operation not permitted
Expected: is ok
assertion message

Bug: 210629279
Change-Id: I6abcededec71e3edfb7e5c8bf28d56074c69d623