commit | 8488208aafafbe1b26da13b2bb6915cca91bc3bd | [log] [tgz] |
---|---|---|
author | mtk80905 <xiao.liu@mediatek.com> | Tue Jan 04 15:47:22 2022 +0800 |
committer | Lili Lin <lili.lin@mediatek.com> | Tue Jan 11 10:23:20 2022 +0800 |
tree | 191427356c4472ca6e3983258caf19d394018e68 | |
parent | cc4244fadfe7b7164beea074aa5e7819f7df128c [diff] |
Fix issue: Fastboot flash image bigger than 4GB will fail When fastboot flash image bigger than 4GB, host will split it to small packages, the function MapViewOfFile parameter do not pass the higher part of file offset, this will cause file offset bigger than 32bit lost and flashed data that offset bigger than 4GB will be messed up Fix method: pass file offset higher part to MapViewOfFile Test method: flash image bigger than 4GB, and read back the data which offset is bigger than 4GB, and compare it with original file Bug: 205510206 Test: fastboot.exe flash super super-8G.img Change-Id: Ic38f3b23b74f59f1e6eacfb8fcb154d7e1751a38
This library is a collection of convenience functions to make common tasks easier and less error-prone.
In this context, “error-prone” covers both “hard to do correctly” and “hard to do with good performance”, but as a general purpose library, libbase's primary focus is on making it easier to do things easily and correctly when a compromise has to be made between “simplest API” on the one hand and “fastest implementation” on the other. Though obviously the ideal is to have both.
The intention is to cover the 80% use cases, not be all things to all users.
If you have a routine that‘s really useful in your project, congratulations. But that doesn’t mean it should be here rather than just in your project.
The question for libbase is “should everyone be doing this?”/“does this make everyone's code cleaner/safer?”. Historically we've considered the bar for inclusion to be “are there at least three unrelated projects that would be cleaned up by doing so”.
If your routine is actually something from a future C++ standard (that isn‘t yet in libc++), or it’s widely used in another library, that helps show that there's precedent. Being able to say “so-and-so has used this API for n years” is a good way to reduce concerns about API choices.
Unlike most Android code, code in libbase has to build for Mac and Windows too.
Code here is also expected to have good test coverage.
By its nature, it‘s difficult to change libbase API. It’s often best to start using your routine just in your project, and let it “graduate” after you're certain that the API is solid.