commit c7c5db80460b4a6d19371165941cf1caa345bc7c
author Steven Moreland <smoreland@google.com> Thu Mar 21 16:01:13 2019 -0700
committer android-build-merger <android-build-merger@google.com> Thu Mar 21 16:01:13 2019 -0700
tree b10e44bb55e43be04d1af35be8807a7dd7b7a621
parent 3ddeb74685e1f7e1be89e75d39b24b4be8936ec5
parent 62729eea877bdce41dc4341072422664b95c3f26

Log for duplicate service registration. am: d90d9f2bc9 am: 2137299e95
am: 62729eea87

Change-Id: I60240ae17be65c5126412039442404ea71455964

service.cpp

diff --git a/service.cpp b/service.cpp
index c7c2a95..9dd1aee 100644
--- a/service.cpp
+++ b/service.cpp
@@ -50,6 +50,8 @@
 // libhidl
 using android::hardware::handleTransportPoll;
 using android::hardware::setRequestingSid;
+using android::hardware::HidlReturnRestriction;
+using android::hardware::setProcessHidlReturnRestriction;
 using android::hardware::setupTransportPolling;
 using android::hardware::toBinder;
 
@@ -137,15 +139,19 @@
 };
 
 int main() {
+    // If hwservicemanager crashes, the system may be unstable and hard to debug. This is both why
+    // we log this and why we care about this at all.
+    setProcessHidlReturnRestriction(HidlReturnRestriction::ERROR_IF_UNCHECKED);
+
     sp<ServiceManager> manager = new ServiceManager();
     setRequestingSid(manager, true);
 
-    if (!manager->add(serviceName, manager)) {
+    if (!manager->add(serviceName, manager).withDefault(false)) {
         ALOGE("Failed to register hwservicemanager with itself.");
     }
 
     sp<TokenManager> tokenManager = new TokenManager();
-    if (!manager->add(serviceName, tokenManager)) {
+    if (!manager->add(serviceName, tokenManager).withDefault(false)) {
         ALOGE("Failed to register ITokenManager with hwservicemanager.");
     }