simpleperf: report.py: import tkinter only when needed It's to fix https://github.com/android/ndk/issues/2135. Bug: none Test: run report.py Change-Id: I4f2253bee6dd32b19ecf8be2f6c35b490547854d
diff --git a/simpleperf/scripts/report.py b/simpleperf/scripts/report.py index 973d93e..d93f87f 100755 --- a/simpleperf/scripts/report.py +++ b/simpleperf/scripts/report.py
@@ -31,15 +31,6 @@ import subprocess import sys -try: - from tkinter import * - from tkinter.font import Font - from tkinter.ttk import * -except ImportError: - from Tkinter import * - from tkFont import Font - from ttk import * - from simpleperf_utils import * PAD_X = 3 @@ -195,6 +186,10 @@ """A window used to display report file.""" def __init__(self, main, report_context, title_line, report_items): + from tkinter import Frame, Label, Scrollbar, X, Y, W, BOTTOM, LEFT, RIGHT, BOTH, HORIZONTAL + from tkinter.font import Font + from tkinter.ttk import Treeview + frame = Frame(main) frame.pack(fill=BOTH, expand=1) @@ -270,6 +265,8 @@ def display_report_file(report_file, self_kill_after_sec): + from tkinter import Tk, Toplevel + fh = open(report_file, 'r') lines = fh.readlines() fh.close()