commit ee6b1ffe6011b34f391ecfa9bde7c6906fb136f7
author Alexandre Courbot <acourbot@chromium.org> Sun Jun 30 11:57:11 2024 +0900
committer Alexandre Courbot <gnurou@gmail.com> Thu Jul 11 23:47:07 2024 +0900
tree d7bbc7fa88bf1be13e719a403b874eccd7ee50aa
parent 64cbe7cbbc11bf352216469e242116f5481b21af

codec/h264/nalu_reader: store cur_byte as u8

This is more accurate.

src/codec/h264/nalu_reader.rs

diff --git a/src/codec/h264/nalu_reader.rs b/src/codec/h264/nalu_reader.rs
index 6a92598..10bb9f2 100644
--- a/src/codec/h264/nalu_reader.rs
+++ b/src/codec/h264/nalu_reader.rs
@@ -16,7 +16,7 @@
     data: Cursor<&'a [u8]>,
     /// Contents of the current byte. First unread bit starting at position 8 -
     /// num_remaining_bits_in_curr_bytes.
-    curr_byte: u32,
+    curr_byte: u8,
     /// Number of bits remaining in `curr_byte`
     num_remaining_bits_in_curr_byte: usize,
     /// Used in epb detection.
@@ -69,15 +69,15 @@
         }
 
         let mut bits_left = num_bits;
-        let mut out = 0;
+        let mut out = 0u32;
 
         while self.num_remaining_bits_in_curr_byte < bits_left {
-            out |= self.curr_byte << (bits_left - self.num_remaining_bits_in_curr_byte);
+            out |= (self.curr_byte as u32) << (bits_left - self.num_remaining_bits_in_curr_byte);
             bits_left -= self.num_remaining_bits_in_curr_byte;
             self.update_curr_byte()?;
         }
 
-        out |= self.curr_byte >> (self.num_remaining_bits_in_curr_byte - bits_left);
+        out |= (self.curr_byte >> (self.num_remaining_bits_in_curr_byte - bits_left)) as u32;
         out &= (1 << num_bits) - 1;
         self.num_remaining_bits_in_curr_byte -= bits_left;
 
@@ -220,7 +220,7 @@
         self.num_remaining_bits_in_curr_byte = 8;
         self.prev_two_bytes = (self.prev_two_bytes << 8) | u16::from(byte);
 
-        self.curr_byte = u32::from(byte);
+        self.curr_byte = byte;
         Ok(())
     }
 }