Google Git
Sign in
android / platform / system / bt / 8e9ecc72b837c148b71f23830b5b609e50ce9755
commit8e9ecc72b837c148b71f23830b5b609e50ce9755[log] [tgz]
authorCheney Ni <cheneyni@google.com>Thu Nov 21 02:49:12 2019 +0800
committerCheney Ni <cheneyni@google.com>Fri Nov 22 17:05:53 2019 +0800
tree175d291a7b987040c619f29d5f2fbda9e48624bf
parent0d629305bf74b2715b73064b856f1853ff48e214 [diff]
A2DP: Do AV suspend / stop at the stack main thread

Because Bluetooth stack cleaned up peers at its main thread, there would
be a race condition if audio HAL asked to suspend / stop the stream at
the same time. These tasks were handled by the called-in thread like
HwBinder, and was segmentation fault since peers were cleaned. This CL
moves audio control tasks to the stack main thread to prevent it.

Besides, this CL also modified the check of audio HAL A2DP CMDs:
* A2DP_Start should be successful if streaming already, and is because
  we only have this HAL as our input. It did not make scense to have
  streaming without a provider.
* A2DP_Stop should not check whether the media tick was scheduled or not
  for a hardware offloading case.

Bug: 139646747
Bug: 144067743
Test: A2DP playback
Change-Id: I736b308628b0da75ceb91e57cfe1854c6767233d
2 files changed
tree: 175d291a7b987040c619f29d5f2fbda9e48624bf
  1. audio_a2dp_hw/
  2. audio_bluetooth_hw/
  3. audio_hal_interface/
  4. audio_hearing_aid_hw/
  5. binder/
  6. bta/
  7. btcore/
  8. btif/
  9. build/
  10. common/
  11. conf/
  12. device/
  13. doc/
  14. embdrv/
  15. gd/
  16. hci/
  17. include/
  18. internal_include/
  19. linux_include/
  20. main/
  21. osi/
  22. packet/
  23. profile/
  24. proto/
  25. service/
  26. stack/
  27. test/
  28. tools/
  29. types/
  30. udrv/
  31. utils/
  32. vendor_libs/
  33. vnd/
  34. .clang-format
  35. .gitignore
  36. .gn
  37. Android.bp
  38. AndroidTestTemplate.xml
  39. BUILD.gn
  40. CleanSpec.mk
  41. EventLogTags.logtags
  42. MODULE_LICENSE_APACHE2
  43. NOTICE
  44. OWNERS
  45. PREUPLOAD.cfg
  46. README.md
  47. TEST_MAPPING
README.md

Fluoride Bluetooth stack

Building and running on AOSP

Just build AOSP - Fluoride is there by default.

Building and running on Linux

Instructions for Ubuntu, tested on 14.04 with Clang 3.5.0 and 16.10 with Clang 3.8.0

Download source

mkdir ~/fluoride
cd ~/fluoride
git clone https://android.googlesource.com/platform/system/bt

Install dependencies (require sudo access):

cd ~/fluoride/bt
build/install_deps.sh

Then fetch third party dependencies:

cd ~/fluoride/bt
mkdir third_party
cd third_party
git clone https://github.com/google/googletest.git
git clone https://android.googlesource.com/platform/external/aac
git clone https://android.googlesource.com/platform/external/libchrome
git clone https://android.googlesource.com/platform/external/libldac
git clone https://android.googlesource.com/platform/external/modp_b64
git clone https://android.googlesource.com/platform/external/tinyxml2

And third party dependencies of third party dependencies:

cd fluoride/bt/third_party/libchrome/base/third_party
mkdir valgrind
cd valgrind
curl https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/valgrind.h?format=TEXT | base64 -d > valgrind.h
curl https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/memcheck.h?format=TEXT | base64 -d > memcheck.h

NOTE: If system/bt is checked out under AOSP, then create symbolic links instead of downloading sources

cd system/bt
mkdir third_party
cd third_party
ln -s ../../../external/aac aac
ln -s ../../../external/libchrome libchrome
ln -s ../../../external/libldac libldac
ln -s ../../../external/modp_b64 modp_b64
ln -s ../../../external/tinyxml2 tinyxml2
ln -s ../../../external/googletest googletest

Generate your build files

cd ~/fluoride/bt
gn gen out/Default

Build

cd ~/fluoride/bt
ninja -C out/Default all

This will build all targets (the shared library, executables, tests, etc) and put them in out/Default. To build an individual target, replace “all” with the target of your choice, e.g. ninja -C out/Default net_test_osi.

Run

cd ~/fluoride/bt/out/Default
LD_LIBRARY_PATH=./ ./bluetoothtbd -create-ipc-socket=fluoride

Eclipse IDE Support

  1. Follows the Chromium project Eclipse Setup Instructions until “Optional: Building inside Eclipse” section (don't do that section, we will set it up differently)

  2. Generate Eclipse settings:

cd system/bt
gn gen --ide=eclipse out/Default

  1. In Eclipse, do File->Import->C/C++->C/C++ Project Settings, choose the XML location under system/bt/out/Default

  2. Right click on the project. Go to Preferences->C/C++ Build->Builder Settings. Uncheck “Use default build command”, but instead using “ninja -C out/Default”

  3. Goto Behaviour tab, change clean command to “-t clean”