commit | 80e24410b7c42288f02869543555e682d88213f7 | [log] [tgz] |
---|---|---|
author | Ajay Panicker <apanicke@google.com> | Fri Dec 14 14:55:02 2018 -0800 |
committer | android-build-team Robot <android-build-team-robot@google.com> | Wed Mar 13 18:02:49 2019 +0000 |
tree | ba4f5f306328a81c1de7e0ca689a895a95500842 | |
parent | 04c6c2121729853e02a762dba4be1a17d4b325b5 [diff] |
DO NOT MERGE: Use a weak pointer to deliver updates to AVRCP devices. If a device disconnects right before a update message gets queued, the device becomes null and there is a crash when the callback for the update executes on the disconnected device. This patch switches the device reference from being Unretained to using a weak pointer so that the callback just doesn't execute if the device is disconnected. Bug: 120431125 Bug: 120445479 Test: Use the same test as b/120477414 as that bug causes a disconnect at the same time as a media update. Change-Id: I1dcc08e5c9866106e7ec0dad52505e34b42da600 (cherry picked from commit f083d1e076ea97e6feaa363f03dab3656bd03ee0)
Just build AOSP - Fluoride is there by default.
Instructions for Ubuntu, tested on 14.04 with Clang 3.5.0 and 16.10 with Clang 3.8.0
mkdir ~/fluoride cd ~/fluoride git clone https://android.googlesource.com/platform/system/bt
Install dependencies (require sudo access):
cd ~/fluoride/bt build/install_deps.sh
Then fetch third party dependencies:
cd ~/fluoride/bt mkdir third_party cd third_party git clone https://github.com/google/googletest.git git clone https://android.googlesource.com/platform/external/aac git clone https://android.googlesource.com/platform/external/libchrome git clone https://android.googlesource.com/platform/external/libldac git clone https://android.googlesource.com/platform/external/modp_b64 git clone https://android.googlesource.com/platform/external/tinyxml2
And third party dependencies of third party dependencies:
cd fluoride/bt/third_party/libchrome/base/third_party mkdir valgrind cd valgrind curl https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/valgrind.h?format=TEXT | base64 -d > valgrind.h curl https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/memcheck.h?format=TEXT | base64 -d > memcheck.h
NOTE: If system/bt is checked out under AOSP, then create symbolic links instead of downloading sources
cd system/bt mkdir third_party cd third_party ln -s ../../../external/aac aac ln -s ../../../external/libchrome libchrome ln -s ../../../external/libldac libldac ln -s ../../../external/modp_b64 modp_b64 ln -s ../../../external/tinyxml2 tinyxml2 ln -s ../../../external/googletest googletest
cd ~/fluoride/bt gn gen out/Default
cd ~/fluoride/bt ninja -C out/Default all
This will build all targets (the shared library, executables, tests, etc) and put them in out/Default. To build an individual target, replace “all” with the target of your choice, e.g. ninja -C out/Default net_test_osi
.
cd ~/fluoride/bt/out/Default LD_LIBRARY_PATH=./ ./bluetoothtbd -create-ipc-socket=fluoride
Follows the Chromium project Eclipse Setup Instructions until “Optional: Building inside Eclipse” section (don't do that section, we will set it up differently)
Generate Eclipse settings:
cd system/bt gn gen --ide=eclipse out/Default
In Eclipse, do File->Import->C/C++->C/C++ Project Settings, choose the XML location under system/bt/out/Default
Right click on the project. Go to Preferences->C/C++ Build->Builder Settings. Uncheck “Use default build command”, but instead using “ninja -C out/Default”
Goto Behaviour tab, change clean command to “-t clean”