commit | 73e73fad13e31623c1edf8e147536a6f59ce1c05 | [log] [tgz] |
---|---|---|
author | Sharvil Nanavati <sharvil@google.com> | Sun Apr 10 17:29:11 2016 -0700 |
committer | Andre Eisenbach <eisenbach@google.com> | Wed Apr 13 18:37:47 2016 +0000 |
tree | 1d992c6dba6cb2b441ca75f4b23df85fbb6865fa | |
parent | 17a8221910d4f5ed99f2585aa41390aa80d50f4f [diff] |
Fix use of uninitialized value in btm_acl_update_busy_level Caught by valgrind: Thread 7 bt_jni_workqueue: Conditional jump or move depends on uninitialised value(s) at 0x5682870: btif_dm_upstreams_evt (btif_dm.c:1800) by 0x56817EF: btif_context_switched (btif_core.c:180) by 0x56817EF: bt_jni_msg_ready (btif_core.c:290) by 0x571D1D7: work_queue_read_cb (thread.c:233) by 0x571C1F9: run_reactor (reactor.c:275) by 0x571CF3D: run_thread (thread.c:206) by 0x4A5B7B3: __pthread_start(void*) (in /system/lib/libc.so) Uninitialised value was created by a stack allocation at 0x56D9CC6: btm_acl_update_busy_level (btm_acl.c:503) Bug: 28113318 Change-Id: I21ffa2f6c48d3bb96dcdc71fee6ab74634e57333
Just build AOSP - Fluoride is there by default.
Instructions for Ubuntu, tested on 15.10 with GCC 5.2.1.
sudo apt-get install libevent-dev
sudo apt-get install ninja-build
or download binary from https://github.com/ninja-build/ninja/releases
Get sha1 of current version from here and then download corresponding executable:
wget -O gn http://storage.googleapis.com/chromium-gn/<gn.sha1>
i.e. if sha1 is “3491f6687bd9f19946035700eb84ce3eed18c5fa” (value from 24 Feb 2016) do
wget -O gn http://storage.googleapis.com/chromium-gn/3491f6687bd9f19946035700eb84ce3eed18c5fa
Then make binary executable and put it on your PATH, i.e.:
chmod a+x ./gn sudo mv ./gn /usr/bin
mkdir ~/fluoride cd ~/fluoride git clone https://android.googlesource.com/platform/system/bt
Then fetch third party dependencies:
cd ~/fluoride/bt mkdir third_party cd third_party git clone https://github.com/google/googletest.git git clone https://android.googlesource.com/platform/external/libchrome git clone https://android.googlesource.com/platform/external/modp_b64 git clone https://android.googlesource.com/platform/external/tinyxml2
And third party dependencies of third party dependencies:
cd fluoride/bt/third_party/libchrome/base/third_party mkdir valgrind cd valgrind curl https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/valgrind.h?format=TEXT | base64 -d > valgrind.h curl https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/memcheck.h?format=TEXT | base64 -d > memcheck.h
Fluoride currently has dependency on some internal Android projects, which also need to be downloaded. This will be removed in future:
cd ~/fluoride git clone https://android.googlesource.com/platform/system/core git clone https://android.googlesource.com/platform/hardware/libhardware git clone https://android.googlesource.com/platform/system/media
We need to configure some paths to make the build successful. Run:
cd ~/fluoride/bt gn args out/Default
This will prompt you to fill the contents of your “out/Default/args.gn” file. Make it look like below. Replace “/home/job” with path to your home directory, and don't use “~” in build arguments:
# Build arguments go here. Examples: # is_component_build = true # is_debug = false # See "gn args <out_dir> --list" for available build arguments. libhw_include_path = "/home/job/fluoride/libhardware/include" core_include_path = "/home/job/fluoride/core/include" audio_include_path = "/home/job/fluoride/media/audio/include"
Then generate your build files by calling
cd ~/fluoride/bt gn gen out/Default
cd ~/fluoride/bt ninja -C out/Default all
This will build all targets (the shared library, executables, tests, etc) and put them in out/Default. To build an individual target, replace “all” with the target of your choice, e.g. ninja -C out/Default net_test_osi
.
cd ~/fluoride/bt/out/Default LD_LIBRARY_PATH=./ ./bluetoothtbd -create-ipc-socket=fluoride